Patches: Browse | Submit New | Admin

[#7833] Incorrectly subclassed method, Gruff::Base#normalize in Gruff::Line

Date:
2007-01-15 04:01
Priority:
3
Submitted By:
Badrinath Janakiraman (badrinathj)
Assigned To:
Nobody (None)
Category:
None
State:
Open
Summary:
Incorrectly subclassed method, Gruff::Base#normalize in Gruff::Line

Detailed description
My name is Badrinath J. I am currently working for ThoughtWorks and was using the Gruff library to generate some graphs
for one of our projects. While doing this, we came across a method that was subclassed incorrectly.

While the Gruff::Base class defines the normalize method with an optional argument of force, set by default to false,
the method, subclassed in Gruff::Line does not define this argument.

We made a local patch that fixes this issue for us, but because we did not see any unit tests, we have not been able
to verify that this is a complete and sound fix. I am submitting the diff created by subversion. I hope that this is
the correct format for submitting a fix.

If correct, it would be great to see it incorporated soon so that we can remove our local monkey patch :)

Thanks a lot for your hard work in creating and maintaining this library.

Add A Comment: Notepad

Please login


Followup

No Followups Have Been Posted

Attached Files:

Name Description Download
normalize.patch Download

Changes:

Field Old Value Date By
File Added1122: normalize.patch2007-01-15 04:01badrinathj