| Message |
 |
Date: 2009-05-15 17:33
Sender: Leif Baradoy
Sounds like a good plan. I definitely think scheduling time for
stablilization/bug fix is critical. |
Date: 2009-05-15 17:11
Sender: Jeff Rickard
Unless you are going to actually use it, I would bundle more
fucntionality together for a release. I think we should look
to deploy it maybe a couple days before we are scheduled to wrap
up the project and use the last two days as a stabilization/low
priority bug fixes.
Otherwise I think the code is fine, I am working on 25240 (or
whatever the date validation piece is) I think that there will
be more changes to come and no real cleanup is necessary, I checked
all my changes before I committed them so we are good to
go there. |
Date: 2009-05-15 16:47
Sender: Leif Baradoy
This works well for the following scenerios:
- join campaign then join team
- join through team directly
- join campaign then create team
If there is any code cleanup you need to do then do your finishing
touches now. If not, Assign back to me and I'll keep it in my
queue until we're ready to deploy.
I suppose we could actually deploy these the join team and leave
team now. I don't see any harm in it. Thoughts? |
Date: 2009-05-15 16:11
Sender: Jeff Rickard
I am a little confused here as to what exactly to do, so I modified
a couple of the paths and where they were pointing. I just pushed
it up to test, give it a try and let me know if that is what
you were thinking. |
Date: 2009-05-15 15:59
Sender: Leif Baradoy
Yikes. I hadn't even tested the scenario you just laid out. I
was testing:
Pre-conditions: user is not logged in and not in the system
1. Goto campaign
2. click join event
3. get the participant profile page with the create account
section
5. enter all information necessary and press submit
6. Go back to campaign home and browse teams
7. Join team
8. SHOULD get confirmation msg and stay on the team profile page
(as you noted in your msg).
For the scenario you laid out on #6 go with a redirect to the
personal profile page is the user joins the campaign via the
team. |
Date: 2009-05-15 15:50
Sender: Jeff Rickard
Do you mean you want the following process:
pre-conditions: user is not logged in and not in the system
1. goto campaign
2. goto team
3. click join team
4. get the participant profile page with the create account
section
5. enter all information necessary and press submit
6. redirected to team page? (or should this be redirected to
participant page, the last page that you pressed submit on was
your participant page)
However, when you are already a participant in the campaign,
if you click join team it will redirect you to the team page
that you clicked on the button from.
Does this sound right?
|
Date: 2009-05-15 15:05
Sender: Leif Baradoy
For a new account user, this works well. One modification: when
I join a team, I am directed to my public profile page w/ the
confirmation message. Instead, when I join a team, I should
stay on the team profile page and get the confirmation message.
I think this is very close to completion.
I'll resend a wider version of the Leave This Team button as
the current width look awkward. |
Date: 2009-05-14 21:54
Sender: Jeff Rickard
Good catch on that profile edit bug. I found that the update
was looking for a variable that did not always exist. That is
fixed now. Also hid the join this team button, must have been
mucking with the logic on that one.
Fixed in revision 3086. |
Date: 2009-05-14 21:18
Sender: Leif Baradoy
It also looks like I'm still able to join other teams or create
a new team even though I am a member of a team (that I didn't
create) |
Date: 2009-05-14 21:09
Sender: Leif Baradoy
If the user joins a team after joining a campaign, the user is
brought to an edit profile screen with a message above saying
I joined the team. When I hit update for the profile, I get
a 500 error and a message (Page successfully updated). It appears
that I did not join the team. In fact, it completely deletes
my profile details. I had to rejoin (I could even create a personal
URL using the same one I had used before).
I tried this twice and it broke both times.
If I don't hit update on the personal profile page, it works
perfectly.
It appears to be a problem with updating the personal profile
page, as I can't seem to do that anyway.
Solution: When you join a team you stay on the team hompage and
the confirmation message appears under the nav bar (don't send
people to profile edit page).
Not sure when editting profiles got borked. Thoughts?
|
Date: 2009-05-14 20:41
Sender: Jeff Rickard
implemented in revision 3085 |
Date: 2009-05-14 19:39
Sender: Leif Baradoy
Sounds good!
Perhaps add a note when people are creating a team that says
you can't leave teams you create. |
Date: 2009-05-14 19:31
Sender: Jeff Rickard
-- Quotation --
Looks like we need to build in some more logic for people who
create teams... Perhaps, if you are a team creator, then you
cannot leave it?
-- End Quotation --
That sounds fine to me, does that work for you? I will just
hide the button if this is the case. |
Date: 2009-05-14 18:44
Sender: Leif Baradoy
I joined a campaign as a new user and then joined a team! Worked
perfect. I tried to join another team and saw the message that
I can't do it becuase I'm already a member of another team.
Can we change that message to "You are already taking part
in (campaign name) as a member of a (current team name), so you
can't join (team use has attempted to join)."
On the Sandbox, I just logged in as a user who created a team.
When I left the team I was directed to the Campaign Homepage
and say a message confirming I left the Team (good!) and the
Create team Option (good).
Yet, the team I created did not show that I left it (it still
had two members).
Then, I was able to join another team. Right now, I'm a member
of two teams.
Looks like we need to build in some more logic for people who
create teams... Perhaps, if you are a team creator, then you
cannot leave it? |
Date: 2009-05-14 17:55
Sender: Jeff Rickard
I don't get the scenario 1 error, I am going to deploy the other
changes though, perhaps it is fixe now. |
Date: 2009-05-14 17:13
Sender: Leif Baradoy
A few items. If I am a member of the general campaign team, I
should see the "Create a Team Option"
Scenario 1: Logged in User Who is already a participant trying
to join a Team
Error 500.
Scenerio 2: New user without an account trying to join a team
Worked fine.
|
Date: 2009-05-14 16:36
Sender: Jeff Rickard
Revision 3081 now skips the new participant page when joining
a team when you were already a member of the campaign. |
Date: 2009-05-14 16:08
Sender: Jeff Rickard
Can you try this again in the sandbox, I just re-deployed it
to test and I don't get the crossover of information between
campaigns.
I will work on bypassing the new page for joining a new team
in the interim |
Date: 2009-05-14 15:54
Sender: Leif Baradoy
Yes. If someone already had a profile, they should not be directed
to edit it when they join a new team. It isn't critical that
we fix this element though.
I have no clue why the profile data from another campaign is
showing up. I'm fearful that the model assumes one profile for
all campaigns or something silly like that. Ensuring that the
right data is in the field is critical. |
Date: 2009-05-14 15:40
Sender: Jeff Rickard
-- Quotation --
After I successfully joined the campaign in general, I went to
join a team. When I joined the team I was taken to
http://slice2.christmasfuture.org:3000/dt/teams/30/participants/n
ew.
For some reason, I was then asked to create a personal profile
for myself again, even though I had already created a personal
profile. This should not be!
-- End Quotation --
I think it you look you will see that the fields are already
auto-populated with your information, this is because you are
actually just editting your participation, not creating it again.
However, I think we should be able to bypass this completely,
which is what I think you want to do here, is that correct?
Hmmmm, it had data from your other campaign? I will have to
look into that, I thought it would have the data from the current
campaign's default team...
|
Date: 2009-05-14 15:10
Sender: Leif Baradoy
When I tested this, following the current join process (which
will change when #25899 is done), I selected "Join as Just
me", then was directed to log in. After I logged in I was
taken back to the campaign homepage but I wasn't a participant.
After logging in, I should be taken to the account profile page.
That said, you don't need to fix this, because the change on
#25899 will remedy the issue.
After I successfully joined the campaign in general, I went to
join a team. When I joined the team I was taken to
http://slice2.christmasfuture.org:3000/dt/teams/30/participants/new.
For some reason, I was then asked to create a personal profile
for myself again, even though I had already created a personal
profile. This should not be!
Moreover, the profile that it directed me to create was already
populated with data from my OneYoga profile! Not good.
When I clicked join I got a 500 error.
Can you tease out a few of the bugs, rework, and test again?
If not call me and I'll be more clear in my explanation of what
occurred. |
Date: 2009-05-13 21:06
Sender: Leif Baradoy
We should send the user to the page created via #23791( Allow
account creation simultaneously when joining a campaign). This
will be used if there is NO registration fee for the event (we'll
have to add some complexity for the reg fee). |
Date: 2009-05-13 21:04
Sender: Leif Baradoy
We should send the user to the page created via #23791( Allow
account creation simultaneously when joining a campaign). This
will be used if there is NO registration fee for the event (we'll
have to add some complexity for the reg fee). |
Date: 2009-05-13 20:57
Sender: Jeff Rickard
Check revision 3079
Note from 25238:
Try this again now. This problem was stemming from the user
not being logged in. I now forced a redirect to the login page
if the user is not logged in and tries to join the event. Let
me know if this does not work for you. |
Date: 2009-05-13 20:48
Sender: Jeff Rickard
Fixed an issue where a user that was not logged in tried to join
a team. Now this will redirect a non logged in user to the login
page. |
Date: 2009-05-13 16:35
Sender: Leif Baradoy
When you join a campaign, you come to a disambiguation page that
says:
"What type of participant are you?
* Individual: I want raise support as just me
* Team Member: I want to raise support with a team or group
* Team Leader: I want to create a new team that others can
join"
This page is no longer necessary and can be removed.
When I select "I want to raise support as just me"
I get a 500 error (Status: 500 Internal Server Error Content-Type:
text/html
500 Internal Server Error) and can go no further.
I was testing without being logged in and I tried to join Campaign
#3. |
Date: 2009-05-12 21:48
Sender: Jeff Rickard
This is completed in commit 3075/3076. You can now join a campaign
and join a team.
When you leave a team your funds come with you up into the default
team. I changed some of the aggregation subroutines as well
to reflect this.
When testing pay special attention to the pledge amounts and
the summing of the data. Also make sure to test joining across
seperate campaigns and make sure there is nothing funny happening
with where the money is getting allocated or the way it is being
displayed. I am pretty sure it is only getting saved in one
spot, but making sure the money adds up is critical.
Let me know if you find anything.
I committed this bug and 25236 at the same time. |
Date: 2009-05-12 21:48
Sender: Jeff Rickard
This is completed in commit 3075/3076. You can now join a campaign
and join a team.
When you leave a team your funds come with you up into the default
team. I changed some of the aggregation subroutines as well
to reflect this.
When testing pay special attention to the pledge amounts and
the summing of the data. Also make sure to test joining across
seperate campaigns and make sure there is nothing funny happening
with where the money is getting allocated or the way it is being
displayed. I am pretty sure it is only getting saved in one
spot, but making sure the money adds up is critical.
Let me know if you find anything.
I committed this bug and 25531 at the same time. |
Date: 2009-05-11 22:10
Sender: Jeff Rickard
Can you send me a 'Join This Campaign' button and a 'Leave this
Team' button as well.
Thank! |
Date: 2009-05-06 16:48
Sender: Leif Baradoy
Hi Jeff,
This structure makes sense.
I believe that the site already automatically joins new users
to a general campaign team. This default team might be automatically
setup when creating a campaign (play with it on testing).
Either way, having this structure seems to make sense to me.
L |
Date: 2009-05-06 16:39
Sender: Jeff Rickard
Hey Leif, there was some talk about how you wanted this structured.
You had mentioned that perhaps we should create a default team
that the campaign would hold as it's primary team which anyone
who joins at the campaign level would be a part of.
The advantage of this is that you would be able to report on
this team, just like any other team in the system. The downside
is that come time for deployment you will need to make sure that
the default team for every existing campaign exists.
I think that adding the default team is probably the way to go,
but I want to ensure there are no crazy impacts that I am not
aware of. |
Date: 2009-05-04 22:25
Sender: Jeff Rickard
It is the case that we need to have the ability for a user to
join a campaign individually, or join a team which would automatically
make them join the campaign that the team is a part of.
Look in show.html.erb in app/views/dt/campaigns |
Date: 2009-05-04 21:02
Sender: Jeff Rickard
Are you saying that you must first join a campaign and then join
a team or can you perform any of the actions in any order.
For instance, I could join a team, leave the team and join the
campaign.
- or -
I could join a campaign and then join a team. |
Date: 2009-04-07 21:44
Sender: Leif Baradoy
Joes anticipates this will take 4 hours to complete. |
