Bugs: Browse | Submit New | Admin

[#2452] Sparklines.smooth boolean options do not work with rails tag

Date:
2005-09-11 03:29
Priority:
3
Submitted By:
Nobody
Assigned To:
Nobody (None)
Category:
None
State:
Open
Summary:
Sparklines.smooth boolean options do not work with rails tag

Detailed description
The :has_max, :has_min, and :has_last options do not work with the Rails sparkline_tag.  A suggested fix is to change
the line

if has_min == true

to 

if has_min


and repeat that fix for all three of those options.  I think this is failing because Rails passes the string "true"
to the Sparklines class, which is not the same thing as the boolean value "true".  But they're both true in
the logical sense.

Add A Comment: Notepad

Please login


Followup

Message
Date: 2006-01-04 18:52
Sender: Geoffrey Grosenbach

Sorry for the delay...looking into it now.
Date: 2005-09-11 11:39
Sender: Nobody

Ok, so that suggested fix is buggy itself (since if someone sets
:has_max to "false" in the sparkline_tag, then

if has_max

will still evaluate to true.  So, feel free to ignore that part
of the report :)

Attached Files:

Name Description Download
No Files Currently Attached

Changes:

No Changes Have Been Made to This Item