| Message |
 |
Date: 2009-04-07 15:19
Sender: Leif Baradoy
Hi Joe,
Can you review this then assign it to Tim Glen to be deployed?
Thanks!
Leif |
Date: 2009-04-01 21:38
Sender: Steven Hines
Refactoring has been checked in with revision 3042 and 3043 and
is ready for testing on slice2.
Joe - can you please review my changes to make sure they don't
clash with any of the other campaigns functionality you've developed
and suggest some refactoring solutions for the TODOs I have left
in the participants_controller. Make those suggestions in this
bug report and then assign back to me to implement them. |
Date: 2009-03-31 23:16
Sender: Leif Baradoy
Looks great! Worked well.
When you've cleaned it up you can assign it directly to Tim.
Thank you so much! |
Date: 2009-03-31 22:43
Sender: Steven Hines
Sorry about that. Looks like an ID10T error on my part :-)
Should be deployed now. |
Date: 2009-03-31 22:25
Sender: Leif Baradoy
Hi Steven,
This doesn't seem to be deployed as per my previous comments.
I'm still seeing the same layout as before (eg.
http://slice2.christmasfuture.org:3000/dt/teams/5/participants/ne
w)
I've cleared my cache on my browser but still no dice--thoughts?
Am I suppose to be testing something else? |
Date: 2009-03-31 22:17
Sender: Steven Hines
Fixed in revision 3040 and ready for testing on slice2.
Once you're happy Leif, assign back to me so that I can look
at refactoring some code. |
Date: 2009-03-31 01:34
Sender: Leif Baradoy
Hi Steven,
I've tested this twice now and it seems to work well. My only
complaint is that the signup page is rather long, with all the
Headers, etc.
Although I'm not going to thrust the look/feel on you, I think
it would be worthwhile to put a bunch of stuff under the same
heading called Create Account
I imagine it being laid out like:
Create Account
* Login/Email
* Display Name
You must enter a display name will be used to identify you
on our website.
* Password
* Confirm Password
Please provide a password. It must be longer than 4 characters
and try to make it something you'll remember.
* Country
* Terms of Service
I have read the terms of use and agree
LET ME HAVE A LOOK ONCE YOU MAKE THIS HAPPEN.
Leif
|
Date: 2009-03-30 23:31
Sender: Steven Hines
Fixed in revision 3036 and ready for testing on slice2.
Please give this a damn good thrashing to find some bugs as there
were a couple of other pieces of work that needed to be done
as precursors for this. Once testing is complete and you are
happy that the requirements have been met, please assign back
to me (not Tim) because the code is still a little untidy with
a few TODOs that need a code review and some refactoring. |