Bugs: Browse | Submit New | Admin

[#22232] invoice_id in recurring.new

Date:
2008-09-30 02:43
Priority:
3
Submitted By:
Nobody
Assigned To:
Nobody (None)
Category:
None
State:
Open
Summary:
invoice_id in recurring.new

Detailed description
recurring.new tries to set invoice_id, should be recurring_id

Add A Comment: Notepad

Please login


Followup

Message
Date: 2009-03-24 00:53
Sender: David Koontz

I second this, it's a really trivial fix (but annoying since
we have this gem on multiple machines).  Here's the diff.

*** freshbooks.rb.orig	2009-03-23 17:47:49.000000000 -0700
--- freshbooks.rb	2009-03-23 17:46:49.000000000 -0700
***************
*** 435,441 ****
  
  
    class Recurring
!     TYPE_MAPPINGS = { 'client_id' => Fixnum, 'lines' =>
Array,
        'po_number' => Fixnum, 'discount' => Float, 'amount'
=> Float,
        'occurrences' => Fixnum }
  
--- 435,441 ----
  
  
    class Recurring
!     TYPE_MAPPINGS = { 'recurring_id' => Fixnum, 'client_id'
=> Fixnum, 'lines' => Array,
        'po_number' => Fixnum, 'discount' => Float, 'amount'
=> Float,
        'occurrences' => Fixnum }
  
***************
*** 447,456 ****
      def create
        resp = FreshBooks::call_api('recurring.create', 'recurring'
=> self)
        if resp.success?
!         self.invoice_id = resp.elements[1].text.to_i
        end
  
!       resp.success? ? self.invoice_id : nil
      end
  
      def update
--- 447,456 ----
      def create
        resp = FreshBooks::call_api('recurring.create', 'recurring'
=> self)
        if resp.success?
!         self.recurring_id = resp.elements[1].text.to_i
        end
  
!       resp.success? ? self.recurring_id : nil
      end
  
      def update

Attached Files:

Name Description Download
No Files Currently Attached

Changes:

No Changes Have Been Made to This Item