Bugs: Browse | Submit New | Admin

[#19530] Pison operation to delete old checked our directories is not atomic.

Date:
2008-04-15 00:27		 Priority:
3
Submitted By:
Nobody 		Assigned To:
Nobody (None)
Category:
None		 State:
Open
Summary:
Pison operation to delete old checked our directories is not atomic.

Detailed description 
Let's say I have several svn:externals declarations. Piston loops through all of them and if they are ready to be converted,
Piston does FileUtils.rm_rf(local_dir)
This is all good but if, let's say, the last svn:externals declarations have a local modification or some other error,
Piston exits and you have to do "svn up" in order to retrieve again the files from the remote repositories.

I suggest you move this FileUtils.rm_rf(local_dir) after you have checked the local directories for errors or modifications
so that if there are any problems with converting to Piston, then at least there will be no changes made.

HTH,
Kiril

Add A Comment: Notepad

Please login


Followup

Message 
Date: 2008-04-15 00:32
Sender: François Beausoleil

Thanks for this new bug report.  I will take care of this issue
in Piston 2.0.
Date: 2008-04-15 00:31
Sender: Kiril Angov

I reported this...

Attached Files:

Name Description Download
No Files Currently Attached

Changes:

No Changes Have Been Made to This Item