Patches: Browse | Submit New | Admin

[#17236] Backwards compatibility fix and tests for image_path overriding

Date:
2008-01-19 18:14		 Priority:
3
Submitted By:
Stephan Seyboth (steffe) 		Assigned To:
Nobody (None)
Category:
None		 State:
Open
Summary:
Backwards compatibility fix and tests for image_path overriding

Detailed description 
The code that overrides image_path in r68 does not work for Rails 1.2 since it ends up calling super for path_to_image
which does not exist. I factored out the path fiddling instead, plus added some tests. That should also make the code
more robust in the face of future image_path/path_to_image changes in Rails.

Add A Comment: Notepad

Please login


Followup

Message 
Date: 2008-08-09 18:27
Sender: Gerald Bauer

FYI: The official RFacebook forum/mailing list (including
the core RFacebook developers) is @
http://groups.google.com/group/rfacebook

If you want to get the issue resolved that's the best place
to start. Cheers.
Date: 2008-01-20 13:26
Sender: Stephan Seyboth

Doh, there seem to be too many things to make compatibility
with Rails 1.* worthwhile. The tests might still be useful,
though.

Attached Files:

Name Description Download
image_path_compat.diff Compatibility fix and tests for image_path overriding Download

Changes:

Field Old Value Date By
File Added3131: image_path_compat.diff2008-01-19 18:14steffe