Patches: Browse | Submit New | Admin

[#16767] Pure windows support

Date:
2008-01-02 15:21
Priority:
3
Submitted By:
Aslak Hellesøy (aslak_hellesoy)
Assigned To:
Luis Lavena (luislavena)
Category:
vlad
State:
Open
Summary:
Pure windows support

Detailed description
Attached is a patch (against vlad 1.1.0) that makes vlad run on Windows (no cygwin - cygwin bad). It assumes plink.exe
(the defacto windows ssh client) is on the PATH and uses the cross-platform POpen4 gem and win32/process which ships
with the windows ruby installer. I had to double-quote the command to make plink understand it - this may break if the
command already has double quotes in it. Finally, waitpid2 on windows doesn't return a Process::Status, but an int,
so I had to treat it like an int.

Cheers,
Aslak

Add A Comment: Notepad

Please login


Followup

Message
Date: 2009-07-05 16:04
Sender: Luis Lavena

Hey Guys,

chiming in.

This patch is good, but has some flaws.

Uses PLATFORM instead of RUBY_PLATFORM. In 1.9 PLATFORM
is deprecated.

Compares PLATFROM to /win/, which would fail under Darwin (OSX).

It should be using Gem.windows? or /mingw|mswin/ as platform
comparison.

One last point: it adds the Platform gem dependency, but I don't
see directly how that is used by the patched code itself.

Except from these points, looks good.

Aslak: what do you think? please let me know if you can work
on a alternate patch for newest version, or I can hack something
along these lines.

Cheers and apologizes for my delayed reply.
Date: 2009-03-03 00:15
Sender: Ryan Davis

updated the patch. didn't apply cleanly.

Attached Files:

Name Description Download
windows_support.diff Download
updated_patch.diff Download

Changes:

Field Old Value Date By
resolution_idNone2009-07-05 16:04luislavena
assigned_tozenspider2009-03-03 00:16zenspider
File Added4387: updated_patch.diff2009-03-03 00:15zenspider
category_idNone2009-02-18 01:37zenspider
assigned_tonone2009-02-18 01:37zenspider
File Added3034: windows_support.diff2008-01-02 15:21aslak_hellesoy