Date: 2009-07-05 16:04
Sender: Luis Lavena
Hey Guys,
chiming in.
This patch is good, but has some flaws.
Uses PLATFORM instead of RUBY_PLATFORM. In 1.9 PLATFORM
is deprecated.
Compares PLATFROM to /win/, which would fail under Darwin (OSX).
It should be using Gem.windows? or /mingw|mswin/ as platform
comparison.
One last point: it adds the Platform gem dependency, but I don't
see directly how that is used by the patched code itself.
Except from these points, looks good.
Aslak: what do you think? please let me know if you can work
on a alternate patch for newest version, or I can hack something
along these lines.
Cheers and apologizes for my delayed reply.
|