Patches: Browse | Submit New | Admin

[#15746] 1) structured COMM, APIC, TXXX, and WXXX; 2) correctly saves multiple tags of the same kind

Date:
2007-11-20 02:02
Priority:
3
Submitted By:
Sam LeRoy (tipcsi)
Assigned To:
Guillaume Pierronnet (moumar)
Category:
None
State:
Open
Summary:
1) structured COMM, APIC, TXXX, and WXXX; 2) correctly saves multiple tags of the same kind

Detailed description
sorry for spamming :)

changes since the previous version i posted earlier today

1) COMM is a hash with keys :lang, :desc, :text
   APIC is a hash with keys :desc, :mime_type, :type_code, :data
   TXXX and WXXX are hashes with keys :desc, :text

2) it no longer only reads multiple tags of the same kind, it can
   save them as well; no check for validity, though, because existing
   apps seem to violate standards anyway (e.g. iTunes stores multiple
   APIC elements with the same description, which is a boo-boo)

3) no unnecessary terminating 0's; the ones we do need are appended to 
   the text fields before the conversion so we correctly have 1 zero
   for latin-1 and 2 zeros for iso

4) options had no more use: language is explicitly given for each
   comment entry, encoding is automatically done to/from utf-8 each
   time we read/write a text field

TODO:
 - update docs to reflect changes
 - there are a lot more composite frames
 - code is getting messy with more and more frame types, so...
   i think they should have separate classes

Add A Comment: Notepad

Please login


Followup

Message
Date: 2007-12-04 15:28
Sender: Guillaume Pierronnet

i'm currently checking your patch. I need to update the unit
test, and, after that, i'll commit it in svn.

Thanks
Date: 2007-11-20 02:06
Sender: Sam LeRoy

Hi Guillaume,

I'm pretty new here... I uploaded a file here, but didn't
change the version, etc...

Could you check it, pls?

Thanks!

Attached Files:

Name Description Download
id3v2.rb Download

Changes:

Field Old Value Date By
assigned_tonone2007-11-20 02:06tipcsi
File Added2846: id3v2.rb2007-11-20 02:02tipcsi