Bugs: Browse | Submit New | Admin

[#11229] rb_thread_critical should be marked deprecated

Date:
2007-05-30 14:08		 Priority:
3
Submitted By:
Paul Brannan (cout) 		Assigned To:
Yukihiro Matsumoto (matz)
Category:
External APIs / Interfacing		 State:
Open
Platform:
  
Summary:
rb_thread_critical should be marked deprecated

Detailed description 
Using Thread.critical emits a warning, so using rb_thread_critical probably should too.

There are still some places in eval.c and gc.c that use rb_thread_critical.  These should probably be fixed.

Index: rubysig.h
===================================================================
--- rubysig.h   (revision 12409)
+++ rubysig.h   (working copy)
@@ -72,7 +72,7 @@
 RUBY_EXTERN rb_atomic_t rb_trap_pending;
 void rb_trap_restore_mask(void);
 
-RUBY_EXTERN int rb_thread_critical;
+DEPRECATED(RUBY_EXTERN int rb_thread_critical);
 void rb_thread_schedule(void);
 
 #endif /* ifndef RUBYSIG_H */

Add A Comment: Notepad

Please login


Followup

No Followups Have Been Posted

Attached Files:

Name Description Download
No Files Currently Attached

Changes:

Field Old Value Date By
assigned_toshyouhei2008-11-08 03:34shyouhei