Dean,

Under ruby 1.8.5 (2006-08-25) [x86_64-linux], Aquarium 0.4.3 appears to
append join point information to exceptions thrown in advised methods.
For example, the small program beneath my sig generates 12k of output
(attached), mostly the stderr dump of "(joinpoint = JoinPoint: ...)".
It also appears to prepend information about about which advice it was
in when the exception was processed.

Both the appending and the prepending violate my first-blush
expectations.  In particular, the appending makes deciphering app errors
quite difficult, as the exception is too large for the eye.

Are my expectations wrong?  Is this behavior normal or perhaps even
desirable?  Have I inflicted this on myself by API misuse or similar?

Thanks.

Regards,
----

$ cat aquarium-exc.rb #!/usr/bin/env ruby

require 'rubygems'
require 'aquarium'

class A
 def foo
   raise "Aiiiieeeeeeeeeeeee"
 end
end

Aquarium::Aspects::Aspect.new :around,
 :calls_to => 'foo', :in_type => A do |jp, obj, *args|
   jp.proceed
end

puts "ruby #{RUBY_VERSION}"
puts "aquarium #{Aquarium::VERSION::STRING}"
A.new.foo

$ ruby aquarium-exc.rb > /tmp/stdout-and-stderr 2>&1


The stdout and stderr output:

aquarium-exc.rb:8:in `_aspect_saved_A_foo': Exception raised while executing "around" advice for "A#foo": Exception raised while executing "around" advice for "A#foo": Aiiiieeeeeeeeeeeee (join_point = JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 @parameters=[], @current_advice_node=#<Aquarium::Aspects::AroundAdviceChainNode:0x2b3eacdb0478 @logger=#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, @join_points=#<Set: {}>, @types_and_ancestors=#<Set: {}>, @types_and_nested_types=#<Set: {}>, @next_node=#<Aquarium::Aspects::NoAdviceChainNode:0x2b3eacdb4988 @next_node=nil, @alias_method_name=:_aspect_saved_A_foo, @aspect=nil, @advice_kind=:none, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}>, @exclude_pointcuts=#<Set: {}>, @exclude_methods=#<Set: {}>, @method_options=#<Set: {:instance}>, @types_and_descendents=#<Set: {}>, @last_advice_kind=[:around], @exclude_types_and_descendents=#<Set: {}>, @pointcuts=#<Set: {}>, @ignore_no_matching_join_points=#<Set: {}>, @exclude_types_calculated=[], @exclude_types=#<Set: {}>, @attributes=#<Set: {}>, @exclude_named_pointcuts=#<Set: {}>, @types=#<Set: {A}>, @aspect=Aspect: {specification: {:types_and_descendents=>#<Set: {}>, :types=>#<Set: {A}>, :advice=>#<Set: {}>, :methods=>#<Set: {"foo"}>, :default_objects=>#<Set: {}>, :types_and_ancestors=>#<Set: {}>, :exclude_pointcuts=>#<Set: {}>, :exclude_types=>#<Set: {}>, :named_pointcuts=>#<Set: {}>, :exclude_types_and_ancestors=>#<Set: {}>, :objects=>#<Set: {}>, :exceptions=>#<Set: {}>, :exclude_join_points=>#<Set: {}>, :join_points=>#<Set: {}>, :ignore_no_matching_join_points=>#<Set: {}>, :method_options=>#<Set: {:instance}>, :exclude_named_pointcuts=>#<Set: {}>, :exclude_types_calculated=>[], :noop=>#<Set: {false}>, :exclude_objects=>#<Set: {}>, :exclude_types_and_nested_types=>#<Set: {}>, :types_and_nested_types=>#<Set: {}>, :logger=>#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, :exclude_types_and_descendents=>#<Set: {}>, :attribute_options=>#<Set: {}>, :pointcuts=>#<Set: {}>, :around=>#<Set: {}>, :exclude_methods=>#<Set: {}>, :attributes=>#<Set: {}>}, pointcuts: #<Set: {Pointcut: {specification: {:types_and_descendents=>#<Set: {}>, :types=>#<Set: {A}>, :types_and_ancestors=>#<Set: {}>, :default_objects=>#<Set: {}>, :methods=>#<Set: {"foo"}>, :exclude_pointcuts=>#<Set: {}>, :exclude_types=>#<Set: {}>, :exclude_types_and_ancestors=>#<Set: {}>, :objects=>#<Set: {}>, :exclude_join_points=>#<Set: {}>, :join_points=>#<Set: {}>, :method_options=>#<Set: {:instance}>, :exclude_types_calculated=>#<Set: {}>, :noop=>#<Set: {false}>, :exclude_objects=>#<Set: {}>, :exclude_types_and_nested_types=>#<Set: {}>, :types_and_nested_types=>#<Set: {}>, :logger=>#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, :exclude_types_and_descendents=>#<Set: {}>, :attribute_options=>#<Set: {}>, :exclude_methods=>#<Set: {}>, :attributes=>#<Set: {}>}, candidate_types: FinderResult: {matched: {A=>#<Set: {}>}, not_matched: {}}, candidate_types_excluded: FinderResult: {matched: {}, not_matched: {}}, candidate_objects: FinderResult: {matched: {}, not_matched: {}}, join_points_matched: #<Set: {JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb7b10 @parameters=[], @advised_object=#<Aquarium::Utils::NilObject:0x2b3eace347f0>, @advice_kind="unknown">}}>, join_points_not_matched: #<Set: {}>}}>, advice: #<Proc:0x00002b3eac2432c0@aquarium-exc.rb:12>}, @attribute_options=#<Set: {}>, @objects=#<Set: {}>, @default_objects=#<Set: {}>, @noop=#<Set: {false}>, @named_pointcuts=#<Set: {}>, @advice_kind=:around, @last_advice_node=nil, @around=#<Set: {}>, @exclude_join_points=#<Set: {}>, @advice=#<Proc:0x00002b3eac2432c0@aquarium-exc.rb:12>, @methods=#<Set: {"foo"}>, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}, @exclude_types_and_nested_types=#<Set: {}>, @exceptions=#<Set: {}>, @exclude_objects=#<Set: {}>, @exclude_types_and_ancestors=#<Set: {}>>, @block_for_method=nil, @advised_object=#<A:0x2b3eacdb6c88>, @proceed_proc=#<Aquarium::Aspects::NoAdviceChainNode:0x2b3eacdb4988 @next_node=nil, @alias_method_name=:_aspect_saved_A_foo, @aspect=nil, @advice_kind=:none, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}>, @advice_kind=:around>}) (join_point = JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 @parameters=[], @current_advice_node=#<Aquarium::Aspects::AroundAdviceChainNode:0x2b3eacdb0478 @logger=#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, @join_points=#<Set: {}>, @types_and_ancestors=#<Set: {}>, @types_and_nested_types=#<Set: {}>, @next_node=#<Aquarium::Aspects::NoAdviceChainNode:0x2b3eacdb4988 @next_node=nil, @alias_method_name=:_aspect_saved_A_foo, @aspect=nil, @advice_kind=:none, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}>, @exclude_pointcuts=#<Set: {}>, @exclude_methods=#<Set: {}>, @method_options=#<Set: {:instance}>, @types_and_descendents=#<Set: {}>, @last_advice_kind=[:around], @exclude_types_and_descendents=#<Set: {}>, @pointcuts=#<Set: {}>, @ignore_no_matching_join_points=#<Set: {}>, @exclude_types_calculated=[], @exclude_types=#<Set: {}>, @attributes=#<Set: {}>, @exclude_named_pointcuts=#<Set: {}>, @types=#<Set: {A}>, @aspect=Aspect: {specification: {:types_and_descendents=>#<Set: {}>, :types=>#<Set: {A}>, :advice=>#<Set: {}>, :methods=>#<Set: {"foo"}>, :default_objects=>#<Set: {}>, :types_and_ancestors=>#<Set: {}>, :exclude_pointcuts=>#<Set: {}>, :exclude_types=>#<Set: {}>, :named_pointcuts=>#<Set: {}>, :exclude_types_and_ancestors=>#<Set: {}>, :objects=>#<Set: {}>, :exceptions=>#<Set: {}>, :exclude_join_points=>#<Set: {}>, :join_points=>#<Set: {}>, :ignore_no_matching_join_points=>#<Set: {}>, :method_options=>#<Set: {:instance}>, :exclude_named_pointcuts=>#<Set: {}>, :exclude_types_calculated=>[], :noop=>#<Set: {false}>, :exclude_objects=>#<Set: {}>, :exclude_types_and_nested_types=>#<Set: {}>, :types_and_nested_types=>#<Set: {}>, :logger=>#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, :exclude_types_and_descendents=>#<Set: {}>, :attribute_options=>#<Set: {}>, :pointcuts=>#<Set: {}>, :around=>#<Set: {}>, :exclude_methods=>#<Set: {}>, :attributes=>#<Set: {}>}, pointcuts: #<Set: {Pointcut: {specification: {:types_and_descendents=>#<Set: {}>, :types=>#<Set: {A}>, :types_and_ancestors=>#<Set: {}>, :default_objects=>#<Set: {}>, :methods=>#<Set: {"foo"}>, :exclude_pointcuts=>#<Set: {}>, :exclude_types=>#<Set: {}>, :exclude_types_and_ancestors=>#<Set: {}>, :objects=>#<Set: {}>, :exclude_join_points=>#<Set: {}>, :join_points=>#<Set: {}>, :method_options=>#<Set: {:instance}>, :exclude_types_calculated=>#<Set: {}>, :noop=>#<Set: {false}>, :exclude_objects=>#<Set: {}>, :exclude_types_and_nested_types=>#<Set: {}>, :types_and_nested_types=>#<Set: {}>, :logger=>#<Set: {#<Logger:0x2b3eaced9750 @default_formatter=#<Logger::Formatter:0x2b3eaced9700 @datetime_format=nil>, @progname=nil, @logdev=#<Logger::LogDevice:0x2b3eaced96b0 @mutex=#<Logger::LogDevice::LogDeviceMutex:0x2b3eaced9660 @mon_entering_queue=[], @mon_count=0, @mon_owner=nil, @mon_waiting_queue=[]>, @dev=#<IO:0x2b3eac250038>, @shift_size=nil, @shift_age=nil, @filename=nil>, @level=2, @formatter=nil>}>, :exclude_types_and_descendents=>#<Set: {}>, :attribute_options=>#<Set: {}>, :exclude_methods=>#<Set: {}>, :attributes=>#<Set: {}>}, candidate_types: FinderResult: {matched: {A=>#<Set: {}>}, not_matched: {}}, candidate_types_excluded: FinderResult: {matched: {}, not_matched: {}}, candidate_objects: FinderResult: {matched: {}, not_matched: {}}, join_points_matched: #<Set: {JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb7b10 @parameters=[], @advised_object=#<Aquarium::Utils::NilObject:0x2b3eace347f0>, @advice_kind="unknown">}}>, join_points_not_matched: #<Set: {}>}}>, advice: #<Proc:0x00002b3eac2432c0@aquarium-exc.rb:12>}, @attribute_options=#<Set: {}>, @objects=#<Set: {}>, @default_objects=#<Set: {}>, @noop=#<Set: {false}>, @named_pointcuts=#<Set: {}>, @advice_kind=:around, @last_advice_node=nil, @around=#<Set: {}>, @exclude_join_points=#<Set: {}>, @advice=#<Proc:0x00002b3eac2432c0@aquarium-exc.rb:12>, @methods=#<Set: {"foo"}>, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}, @exclude_types_and_nested_types=#<Set: {}>, @exceptions=#<Set: {}>, @exclude_objects=#<Set: {}>, @exclude_types_and_ancestors=#<Set: {}>>, @block_for_method=nil, @advised_object=#<A:0x2b3eacdb6c88>, @proceed_proc=#<Aquarium::Aspects::NoAdviceChainNode:0x2b3eacdb4988 @next_node=nil, @alias_method_name=:_aspect_saved_A_foo, @aspect=nil, @advice_kind=:none, @static_join_point=JoinPoint: {target_type = A, target_object = nil, method_name = foo, instance_method? true, context = #<Aquarium::Aspects::JoinPoint::Context:0x2b3eacdb4ca8 ...>}>, @advice_kind=:around>}) (RuntimeError)
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:148:in `send'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:148:in `advice_wrapper'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:66:in `call'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/join_point.rb:49:in `proceed'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/join_point.rb:153:in `proceed'
	from aquarium-exc.rb:14
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:60:in `call'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:60:in `call_advice'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:251:in `advice_wrapper'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/advice.rb:66:in `call'
	from /usr/lib64/ruby/gems/1.8/gems/aquarium-0.4.3/lib/aquarium/aspects/aspect.rb:408:in `foo'
	from aquarium-exc.rb:19
ruby 1.8.5
aquarium 0.4.3