Patches: Browse | Submit New | Admin

[#8316] to_param should return a stringified key in resource generator's controller spec

Date:
2007-01-30 17:24
Priority:
3
Submitted By:
Chris Anderson (jchris)
Assigned To:
David Chelimsky (dchelimsky)
Category:
rails plugin
State:
Closed
Summary:
to_param should return a stringified key in resource generator's controller spec

Detailed description
Rails expects a string here, raising errors like:

TypeError in 'Requesting /venues using POST should create a new venue'
can't convert Fixnum into String
(eval):19:in `venue_url'

when given a Fixnum param.

This patch simply adds a few quote marks to the rspec resource generator's controller spec template.

Add A Comment: Notepad

Please login


Followup

Message
Date: 2007-01-31 00:18
Sender: Deepak Jois

A similar patch needs to be applied to the view spec generators
too..

Index: show_rhtml_spec.rb
=================================================================
==
--- show_rhtml_spec.rb  (revision 136)
+++ show_rhtml_spec.rb  (working copy)
@@ -5,7 +5,7 @@
   
   setup do
     @<%= file_name %> = mock("<%= file_name
%>")
-    @<%= file_name %>.stub!(:to_param).and_return(99)
+    @<%= file_name %>.stub!(:to_param).and_return("99
")
     @<%= file_name %>.stub!(:errors).and_return(@errors)<%
for attribute in attributes -%>
     @<%= file_name %>.should_receive(:<%= attribute.name
%>).and_return(<%= attribute.default_value %>)<%
end -%>
 
Index: edit_rhtml_spec.rb
=================================================================
==
--- edit_rhtml_spec.rb  (revision 136)
+++ edit_rhtml_spec.rb  (working copy)
@@ -8,7 +8,7 @@
     @errors.stub!(:count).and_return(0)
 
     @<%= file_name %> = mock("<%= file_name
%>")
-    @<%= file_name %>.stub!(:to_param).and_return(99)
+    @<%= file_name %>.stub!(:to_param).and_return("99
")
     @<%= file_name %>.stub!(:errors).and_return(@errors)<%
for attribute in attributes -%>
     @<%= file_name %>.should_receive(:<%= attribute.name
%>).and_return(<%= attribute.default_value %>)<%
end -%>
 
Index: new_rhtml_spec.rb
=================================================================
==
--- new_rhtml_spec.rb   (revision 136)
+++ new_rhtml_spec.rb   (working copy)
@@ -8,7 +8,7 @@
     @errors.stub!(:count).and_return(0)
 
     @<%= file_name %> = mock("<%= file_name
%>")
-    @<%= file_name %>.stub!(:to_param).and_return(99)
+    @<%= file_name %>.stub!(:to_param).and_return("99
")
     @<%= file_name %>.stub!(:errors).and_return(@errors)<%
for attribute in attributes -%>
     @<%= file_name %>.should_receive(:<%= attribute.name
%>).and_return(<%= attribute.default_value %>)<%
end -%>
Date: 2007-01-30 18:38
Sender: David Chelimsky

Applied in rev 1445

Attached Files:

Name Description Download
to_param_string.diff adds quotes to to_param stub Download

Changes:

Field Old Value Date By
resolution_idNone2007-01-30 18:38dchelimsky
category_idNone2007-01-30 18:38dchelimsky
assigned_tonone2007-01-30 18:38dchelimsky
close_date2007-01-30 18:382007-01-30 18:38dchelimsky
status_idOpen2007-01-30 18:38dchelimsky
File Added1191: to_param_string.diff2007-01-30 17:24jchris