[Wtr-development] Fwd: [GitHub] Legal attribute name fix [bret/watir GH-5]

Ethan notethan at gmail.com
Thu Oct 7 14:32:03 EDT 2010


presumably not - it's an issue with the rather poor method firewatir uses of
passing values to javascript and back. watir doesn't do any passing around
of unescaped strings that could have some particular meaning in js.

On Thu, Oct 7, 2010 at 13:38, Jarmo <jarmo.p at gmail.com> wrote:

> I wonder if the same bug also exists in Watir. Anyone cares to try?
>
> Jarmo
>
>
> ---------- Forwarded message ----------
> From: GitHub <noreply at github.com>
> Date: Thu, Sep 30, 2010 at 5:58 AM
> Subject: [GitHub] Legal attribute name fix [bret/watir GH-5]
> To: jarmo.p at gmail.com
>
>
> alanshields wants someone to pull from alanshields:attribute_js_fix:
>
> HTML5 allows arbitrary attributes on elements provided that the
> attribute begins with "data-". Even before HTML5, this was done by a
> few people.
>
> Unfortunately, current code will fail, interpreting
> attribute_value("foo-bar") as "foo - bar".
>
> This has now been fixed and (more importantly) unit tested.
>
> Thank you,
> Alan Shields
>
> View Pull Request: http://github.com/bret/watir/pull/5
> _______________________________________________
> Wtr-development mailing list
> Wtr-development at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wtr-development
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/wtr-development/attachments/20101007/11746608/attachment.html>


More information about the Wtr-development mailing list