[Wtr-development] [JIRA] Commented: (WTR-154) Remove :beforeText and :afterText

Ethan (JIRA) watirjira at gmail.com
Mon Oct 4 13:48:30 EDT 2010


    [ http://jira.openqa.org/browse/WTR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19895#action_19895 ] 

Ethan commented on WTR-154:
---------------------------

These methods are named quite the opposite of what's intuitive. beforeText does not return the text before the element, it returns the text after the end of the element (implementation is getAdjacentText("afterEnd")) and afterText returns the text before the element (getAdjacentText("beforeBegin")). makes no sense and they should be deprecated. 

the functionality itself is useful, and you'll get complaints if it's removed. I've reimplemented this in vapir with names that make sense, see: 

http://github.com/vapir/vapir/blob/3791a7a1f6d3c760cf94387f19bfb19b8ccb33e5/vapir-ie/lib/vapir-ie/element.rb#L44

lines 44-70. 

> Remove :beforeText and :afterText
> ---------------------------------
>
>                 Key: WTR-154
>                 URL: http://jira.openqa.org/browse/WTR-154
>             Project: Watir
>          Issue Type: Improvement
>          Components: HTML Controls
>            Reporter: Bret Pettichord
>             Fix For: Soon
>
>
> These don't seem to work the way people expect and won't port to Firewatir, etc anyway.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.openqa.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the Wtr-development mailing list