From bret at pettichord.com Wed Apr 1 11:49:49 2009 From: bret at pettichord.com (Bret Pettichord) Date: Wed, 1 Apr 2009 10:49:49 -0500 Subject: [Wtr-development] rexml In-Reply-To: <7ac2300c0903260405m194310dma55152e7251c0328@mail.gmail.com> References: <7ac2300c0903260405m194310dma55152e7251c0328@mail.gmail.com> Message-ID: Aidy, Can you provide more information about what you are doing and what error you are seeing? I can also say that I have had good luck with github support, both on their support site and on the #github irc channel. Bret On Thu, Mar 26, 2009 at 6:05 AM, aidy lewis wrote: > Hi, > > I forked Watir, but everyone time I edit I am asked for a new > admistration name. I cannot proceed with the current name. > > Aidy > > On 26/03/2009, ?eljko Filipin wrote: > > > From: Adrian Lewis > > > I am having problems forking on git hub. > > > > Aidy, > > > > I have been there recently too. :) > > > > Could you be more specific? What is the problem? > > > > ?eljko > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Sat Apr 11 11:56:40 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 16:56:40 +0100 Subject: [Wtr-development] git questions Message-ID: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> Hi,. I have forked Watir, cloned to a working copy and made rexml => nokogiri changes. I have changed the ie-class.rb, added a nokogiri test and deleted the rexml test. git sees data as blobs based on a hash-key, so do I need to add these files then commit to my local repo? Then do I push? Watir will also now depend on nokogiri, so do I add this line in the the gemspec s.add_dependency 'nokogiri' ? Thanks Aidy From aidy.lewis at googlemail.com Sat Apr 11 13:03:00 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 18:03:00 +0100 Subject: [Wtr-development] git questions In-Reply-To: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> Message-ID: <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> Hi, I seem to have made a commit and a push http://github.com/aidylewis/watir/commits/ But how do I view my changes? Aidy 2009/4/11 aidy lewis : > Hi,. > > I have forked Watir, cloned to a working copy and made rexml => > nokogiri changes. > > I have changed the ie-class.rb, added a nokogiri test and deleted the > rexml test. git sees data as blobs based on a hash-key, so do I need > to add these files then commit to my local repo? Then do I push? > > Watir will also now depend on nokogiri, so do I add this line in the the gemspec > > s.add_dependency 'nokogiri' ? > > Thanks > > Aidy > From aidy.lewis at googlemail.com Sat Apr 11 14:28:26 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 19:28:26 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> Message-ID: <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> Thanks Bret, I managed to commit, push to my repo and made a pull request to yours (I think). Aidy 2009/4/11 Bret Pettichord : > > > On Sat, Apr 11, 2009 at 12:03 PM, aidy lewis > wrote: >> >> Hi, >> >> I seem to have made a commit and a push >>to >> http://github.com/aidylewis/watir/commits/ >> >> But how do I view my changes? > > You can click on the commit links on this page. > > I've also found gitk to be a handy tool for viewing history locally. > > Bret > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From aidy.lewis at googlemail.com Mon Apr 13 12:37:29 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 13 Apr 2009 17:37:29 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> Message-ID: <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> Bret, 2009/4/13 Bret Pettichord : > I took a quick look at the code. I'm wondering if you had a chance to run > the xpath tests? Were there any issues? Was it faster? Ran the xpath tests some time ago with complete success. Around 3-5 times faster, but I am sure you would like empirical data. Aidy From aidy.lewis at googlemail.com Mon Apr 13 13:15:49 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 13 Apr 2009 18:15:49 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> Message-ID: <7ac2300c0904131015u7f27c17aka95628aeb44b1e82@mail.gmail.com> Bret, Let me do some more test on the fork and get back to you. Aidy On 13/04/2009, Bret Pettichord wrote: > On Mon, Apr 13, 2009 at 11:37 AM, aidy lewis > wrote: > > > Bret, > > > > 2009/4/13 Bret Pettichord : > > > > > I took a quick look at the code. I'm wondering if you had a chance to > run > > > the xpath tests? Were there any issues? Was it faster? > > > > Ran the xpath tests some time ago with complete success. Around 3-5 > > times faster, but I am sure you would like empirical data. > > No, that sounds good. > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From aidy.lewis at googlemail.com Mon Apr 20 10:26:15 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 20 Apr 2009 15:26:15 +0100 Subject: [Wtr-development] aidy_lewis fork Message-ID: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> H Bret This fork: http://github.com/aidylewis/watir/tree/master seems stable and significantly increases xpath speed. Aidy -- blog: www.agiletester.co.uk twitter: http://twitter.com/aidy_lewis From rslawrence at gmail.com Mon Apr 20 11:15:33 2009 From: rslawrence at gmail.com (Richard Lawrence) Date: Mon, 20 Apr 2009 09:15:33 -0600 Subject: [Wtr-development] aidy_lewis fork In-Reply-To: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> References: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> Message-ID: Hi Aidy, Does the switch to nokogiri mean that CSS selectors are supported in Watir now? Thanks, Richard On Mon, Apr 20, 2009 at 8:26 AM, aidy lewis wrote: > H Bret > > This fork: > > http://github.com/aidylewis/watir/tree/master > > seems stable and significantly increases xpath speed. > > Aidy > > -- > blog: www.agiletester.co.uk > twitter: http://twitter.com/aidy_lewis > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From aidy.lewis at googlemail.com Mon Apr 20 12:29:01 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 20 Apr 2009 17:29:01 +0100 Subject: [Wtr-development] aidy_lewis fork In-Reply-To: References: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> Message-ID: <7ac2300c0904200929s7a37d5eeg62a64c769dd0f72d@mail.gmail.com> Nope. Just a direct substitute for REXML to increase performance. Aidy 2009/4/20 Richard Lawrence : > Hi Aidy, > > Does the switch to nokogiri mean that CSS selectors are supported in Watir now? > > Thanks, > > Richard > > On Mon, Apr 20, 2009 at 8:26 AM, aidy lewis wrote: >> H Bret >> >> This fork: >> >> http://github.com/aidylewis/watir/tree/master >> >> seems stable and significantly increases xpath speed. >> >> Aidy >> >> -- >> blog: www.agiletester.co.uk >> twitter: http://twitter.com/aidy_lewis >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- blog: www.agiletester.co.uk twitter: http://twitter.com/aidy_lewis From zeljko.filipin at wa-research.ch Tue Apr 21 03:57:43 2009 From: zeljko.filipin at wa-research.ch (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 21 Apr 2009 09:57:43 +0200 Subject: [Wtr-development] Watir.com migration In-Reply-To: References: Message-ID: On Tue, Apr 21, 2009 at 00:46, Bret Pettichord wrote: > I have time this week to help, although I really don't know anything about how to administer these systems. Same here. I will not sleep if needed, just to get watir.com live. :) But I have no idea what has to be done. Alister, if you need any help, let me know. ?eljko -------------- next part -------------- An HTML attachment was scrubbed... URL: From zeljko.filipin at wa-research.ch Tue Apr 21 04:09:01 2009 From: zeljko.filipin at wa-research.ch (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 21 Apr 2009 10:09:01 +0200 Subject: [Wtr-development] New Release of Watir In-Reply-To: References: Message-ID: On Tue, Apr 21, 2009 at 08:59, Alex Collins wrote: > I would lean towards 1.7.0 +1 ?eljko -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at gmail.com Tue Apr 21 19:06:47 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 00:06:47 +0100 Subject: [Wtr-development] FireWatir - Separation of JSSH code into separate class Message-ID: All, I've spent a little time over the past few days trying to separate out the existing JSSH interface into a separate class in an attempt to clean up this interface. The original intention was to implement the NoMethodError when you call a method that does not exist. I have not yet added this, although I have added a test for it. I have also amended a FireWatir unit test and the commonwatir watir- unittest.rb; I discovered a unit test incorrectly assigning to a local variable 'browser' when it ought to have been reassigning $browser. There is now an accessor method, so test methods can can self.browser=new_browser to reassign the browser, if required. I would appreciate any review of the code changes / testing / issue reports etc. My fork is on github: http://github.com/ajcollins/watir/tree/master git clone git://github.com/ajcollins/watir.git Information about my changes: I have cut out much of the JSSH code and reduced it to a single method, #execute(command) which prepares and sends the command, retrieves the result and checks for errors. This cuts down on repetitive code elsewhere - some of which still requires removal - additional stripping of new lines, for example. My new test is failing, others are all ok on OS X. However, I have added a workaround for 5 of these: test_table_with_hidden_or_visible_rows(TC_Tables_Buttons) test_simple_table_buttons(TC_Tables_Buttons) test_using_text_on_form(TC_Forms4) test_objects_in_span(TC_Divs) test_objects_in_div(TC_Divs) I believe at present (although may be incorrect) that these tests should previously have failed because elements.rb#fire_event / #click issues an invalid jssh command when constructing events if @container.document_var is nil. However, as the #send and #read_socket pairing did not check for errors, these issues were concealed. This now results in an exception as follows, we can see that the document element is missing from the .createEvent call: test_objects_in_div(TC_Divs): JSSHInterface::JSSyntaxError: syntax error Command: var event = .createEvent("HTMLEvents"); event.initEvent("select", true, true); elements_0_input[0].dispatchEvent(event); Response: SyntaxError: syntax error Fixing this requires finishing the code surrounding document_var etc in firefox.rb and frame.rb and understanding / documenting it. For the time being, I have added a check to elements.rb#fire_event that executes the jssh command unless @container.document_var.empty? This is accompanied by a TODO. I have incremented my version to 1.7.0-unstable for testing. This does not include any of Aidy's changes. Alex From taku at toi-planning.net Tue Apr 21 21:15:08 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 10:15:08 +0900 Subject: [Wtr-development] maxlength patch for TextField#doKeyPress of FireWatir Message-ID: <20090422101508.02638f5e.taku@toi-planning.net> Dear Bret, My name is Taku Amano and I want to contribute to the project of Watier. This patch fixed TextField#doKeyPress in FireWatir. In TextField#doKeyPress of FireWatir, maxlength attributes was checked, but when the value had already been set to the field, it was not checked correctly. This patch include test code of textfield's maxlength and fixed code of TextField#doKeyPress. Test: http://github.com/usualoma/watir/commit/ed6350e880d1f1c9943350cc0ccd32fe19467726 http://github.com/usualoma/watir/commit/24a60eeb186f0f07c4b134c46ca23fe8ba59a06d TextField#doKeyPress: http://github.com/usualoma/watir/commit/d5fce9a24b5baedeed4e18493e9e4d024b425091 And, because I have only poor English skill, I hope you will correct log message if the expression is not correct. Thanks, -- Name: Taku Amano Mail: taku at toi-planning.net From taku at toi-planning.net Tue Apr 21 21:17:03 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 10:17:03 +0900 Subject: [Wtr-development] Insert multibyte characters into field Message-ID: <20090422101703.76d3575e.taku@toi-planning.net> Dear Bret, This patch enabled to insert multibyte characters into field. At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. Test: http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 Handling of Multibyte characters: http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 Thanks, -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at gmail.com Wed Apr 22 03:11:08 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 08:11:08 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090422101703.76d3575e.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> Message-ID: Taku, I get several unit test failures when running with these patches. Did you expect this? Alex On 22 Apr 2009, at 02:17, Taku Amano wrote: > Dear Bret, > > This patch enabled to insert multibyte characters into field. > > At FireWatir, multi byte character was not able to be inserted into > the text field due to the problem on the JSSh. > In this patch, that problem is solved by sending the character that > encodes URI, and restoring it with JavaScript's decodeURIComponent. > I hope to be included into trunk for the improvement of the > portability though this patch becomes a mere overhead in the > environment that doesn't use multibyte character. > > Test: > http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 > > Handling of Multibyte characters: > http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 > > Thanks, > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 04:18:24 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 17:18:24 +0900 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: References: <20090422101703.76d3575e.taku@toi-planning.net> Message-ID: <20090422171824.035f049c.taku@toi-planning.net> Alex, Thank you for testing my code. And I am sorry for wasting your time. The bug was included in the patch that I had sent ahead. Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. I did not notice because my development environment is ruby 1.8.7 (Integer#ord backported to 1.8.7). Could you try this? http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c Thanks, Taku On Wed, 22 Apr 2009 08:11:08 +0100 Alex Collins wrote: >Taku, > >I get several unit test failures when running with these patches. Did you expect this? > >Alex > >On 22 Apr 2009, at 02:17, Taku Amano wrote: > >> Dear Bret, >> >> This patch enabled to insert multibyte characters into field. >> >> At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. >> In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. >> I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. >> >> Test: >> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >> >> Handling of Multibyte characters: >> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >> >> Thanks, >> >> -- >> Name: Taku Amano >> Mail: taku at toi-planning.net >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development > >_______________________________________________ >Wtr-development mailing list >Wtr-development at rubyforge.org >http://rubyforge.org/mailman/listinfo/wtr-development > -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at gmail.com Wed Apr 22 15:46:04 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 20:46:04 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090422171824.035f049c.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> Message-ID: Taku, It wasn't a waste of my time at all. Glad you found the cause. Sorry I didn't have a chance to send more info - I had to get to a meeting. I have now integrated your code into my fork. I had a few issues although thankfully easy to resolve: 1) The new multibyte tests needed to be moved to their own class. Being in the same class (TC_Fields) and having the same method names, they 'overwrote' some other test methods that were failing. 2) Added a UTF-8 header to the HTML page - my default encoding meant it didn't get interpreted correctly. 3) Create separate fields in the HTML to avoid any execution order issues with the tests' actions. 4) Corrected the existing text_field tests which were failing - you'd added another text field for the new test so an index and count had changed. The only outstanding failure on my fork is the NoMethodError. I might look into implementing this shortly. Perhaps you could confirm that the multi byte code still works for you from my fork? My commit: http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 Alex On 22 Apr 2009, at 09:18, Taku Amano wrote: > Alex, > > Thank you for testing my code. > And I am sorry for wasting your time. > > The bug was included in the patch that I had sent ahead. > Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. > I did not notice because my development environment is ruby 1.8.7 > (Integer#ord backported to 1.8.7). > > Could you try this? > http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c > > Thanks, > > Taku > > On Wed, 22 Apr 2009 08:11:08 +0100 > Alex Collins wrote: > >> Taku, >> >> I get several unit test failures when running with these patches. >> Did you expect this? >> >> Alex >> >> On 22 Apr 2009, at 02:17, Taku Amano wrote: >> >>> Dear Bret, >>> >>> This patch enabled to insert multibyte characters into field. >>> >>> At FireWatir, multi byte character was not able to be inserted >>> into the text field due to the problem on the JSSh. >>> In this patch, that problem is solved by sending the character >>> that encodes URI, and restoring it with JavaScript's >>> decodeURIComponent. >>> I hope to be included into trunk for the improvement of the >>> portability though this patch becomes a mere overhead in the >>> environment that doesn't use multibyte character. >>> >>> Test: >>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>> >>> Handling of Multibyte characters: >>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>> >>> Thanks, >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 17:16:13 2009 From: taku at toi-planning.net (Taku Amano) Date: Thu, 23 Apr 2009 06:16:13 +0900 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> Message-ID: <20090423061613.e1bbd3fb.taku@toi-planning.net> Alex, Thank you for confirming and integrating. And thank you very much for fixing of 1-4. I confirmed the test of this committing did not fail. >My commit: >http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 Confirmed in these environment. -------------------------------- OS: Debian GNU/Linux Firefox: 3.0.7 Ruby: 1.8.7 -------------------------------- OS: Windows Vista Firefox: 3.0.9 Ruby: 1.8.6 -------------------------------- Is there anything I can do? Thanks, Taku On Wed, 22 Apr 2009 20:46:04 +0100 Alex Collins wrote: >Taku, > >It wasn't a waste of my time at all. Glad you found the cause. Sorry I didn't have a chance to send more info - I had to get to a meeting. > >I have now integrated your code into my fork. I had a few issues although thankfully easy to resolve: > >1) The new multibyte tests needed to be moved to their own class. Being in the same class (TC_Fields) and having the same method names, they 'overwrote' some other test methods that were failing. >2) Added a UTF-8 header to the HTML page - my default encoding meant it didn't get interpreted correctly. >3) Create separate fields in the HTML to avoid any execution order issues with the tests' actions. >4) Corrected the existing text_field tests which were failing - you'd added another text field for the new test so an index and count had changed. > >The only outstanding failure on my fork is the NoMethodError. I might look into implementing this shortly. > >Perhaps you could confirm that the multi byte code still works for you from my fork? > >My commit: >http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > >Alex > > >On 22 Apr 2009, at 09:18, Taku Amano wrote: > >> Alex, >> >> Thank you for testing my code. >> And I am sorry for wasting your time. >> >> The bug was included in the patch that I had sent ahead. >> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >> I did not notice because my development environment is ruby 1.8.7 (Integer#ord backported to 1.8.7). >> >> Could you try this? >> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >> >> Thanks, >> >> Taku >> >> On Wed, 22 Apr 2009 08:11:08 +0100 >> Alex Collins wrote: >> >>> Taku, >>> >>> I get several unit test failures when running with these patches. Did you expect this? >>> >>> Alex >>> >>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>> >>>> Dear Bret, >>>> >>>> This patch enabled to insert multibyte characters into field. >>>> >>>> At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. >>>> In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. >>>> I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. >>>> >>>> Test: >>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>> >>>> Handling of Multibyte characters: >>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>> >>>> Thanks, >>>> >>>> -- >>>> Name: Taku Amano >>>> Mail: taku at toi-planning.net >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >> >> >> -- >> Name: Taku Amano >> Mail: taku at toi-planning.net >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development > >_______________________________________________ >Wtr-development mailing list >Wtr-development at rubyforge.org >http://rubyforge.org/mailman/listinfo/wtr-development > -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at cantab.net Wed Apr 22 17:50:12 2009 From: a.j.collins.02 at cantab.net (Alex Collins) Date: Wed, 22 Apr 2009 22:50:12 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090423061613.e1bbd3fb.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> <20090423061613.e1bbd3fb.taku@toi-planning.net> Message-ID: <955C51B4-8D3C-458A-A140-E6795D49DAFC@cantab.net> Taku, I'm still playing with fitting in the NoMethodError exception. I seem to break something wherever I place the check. Super work confirming it on both Linux and Vista. I've not yet fired up the virtual machines for this. I doubt that there is anything else to do - really it is up to Bret, I think. Alex On 22 Apr 2009, at 22:16, Taku Amano wrote: > Alex, > > Thank you for confirming and integrating. > And thank you very much for fixing of 1-4. > > I confirmed the test of this committing did not fail. >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > Confirmed in these environment. > -------------------------------- > OS: Debian GNU/Linux > Firefox: 3.0.7 > Ruby: 1.8.7 > -------------------------------- > OS: Windows Vista > Firefox: 3.0.9 > Ruby: 1.8.6 > -------------------------------- > > Is there anything I can do? > > Thanks, > > Taku > > On Wed, 22 Apr 2009 20:46:04 +0100 > Alex Collins wrote: > >> Taku, >> >> It wasn't a waste of my time at all. Glad you found the cause. >> Sorry I didn't have a chance to send more info - I had to get to a >> meeting. >> >> I have now integrated your code into my fork. I had a few issues >> although thankfully easy to resolve: >> >> 1) The new multibyte tests needed to be moved to their own class. >> Being in the same class (TC_Fields) and having the same method >> names, they 'overwrote' some other test methods that were failing. >> 2) Added a UTF-8 header to the HTML page - my default encoding >> meant it didn't get interpreted correctly. >> 3) Create separate fields in the HTML to avoid any execution order >> issues with the tests' actions. >> 4) Corrected the existing text_field tests which were failing - >> you'd added another text field for the new test so an index and >> count had changed. >> >> The only outstanding failure on my fork is the NoMethodError. I >> might look into implementing this shortly. >> >> Perhaps you could confirm that the multi byte code still works for >> you from my fork? >> >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 >> >> Alex >> >> >> On 22 Apr 2009, at 09:18, Taku Amano wrote: >> >>> Alex, >>> >>> Thank you for testing my code. >>> And I am sorry for wasting your time. >>> >>> The bug was included in the patch that I had sent ahead. >>> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >>> I did not notice because my development environment is ruby 1.8.7 >>> (Integer#ord backported to 1.8.7). >>> >>> Could you try this? >>> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >>> >>> Thanks, >>> >>> Taku >>> >>> On Wed, 22 Apr 2009 08:11:08 +0100 >>> Alex Collins wrote: >>> >>>> Taku, >>>> >>>> I get several unit test failures when running with these patches. >>>> Did you expect this? >>>> >>>> Alex >>>> >>>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>>> >>>>> Dear Bret, >>>>> >>>>> This patch enabled to insert multibyte characters into field. >>>>> >>>>> At FireWatir, multi byte character was not able to be inserted >>>>> into the text field due to the problem on the JSSh. >>>>> In this patch, that problem is solved by sending the character >>>>> that encodes URI, and restoring it with JavaScript's >>>>> decodeURIComponent. >>>>> I hope to be included into trunk for the improvement of the >>>>> portability though this patch becomes a mere overhead in the >>>>> environment that doesn't use multibyte character. >>>>> >>>>> Test: >>>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>>> >>>>> Handling of Multibyte characters: >>>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>>> >>>>> Thanks, >>>>> >>>>> -- >>>>> Name: Taku Amano >>>>> Mail: taku at toi-planning.net >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> Wtr-development at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From a.j.collins.02 at gmail.com Wed Apr 22 17:50:56 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 22:50:56 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090423061613.e1bbd3fb.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> <20090423061613.e1bbd3fb.taku@toi-planning.net> Message-ID: <719FA674-87D5-4181-876B-129C9971C3DA@gmail.com> Taku, I'm still playing with fitting in the NoMethodError exception. I seem to break something wherever I place the check. Super work confirming it on both Linux and Vista. I've not yet fired up the virtual machines for this. I doubt that there is anything else to do - really it is up to Bret, I think. Alex On 22 Apr 2009, at 22:16, Taku Amano wrote: > Alex, > > Thank you for confirming and integrating. > And thank you very much for fixing of 1-4. > > I confirmed the test of this committing did not fail. >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > Confirmed in these environment. > -------------------------------- > OS: Debian GNU/Linux > Firefox: 3.0.7 > Ruby: 1.8.7 > -------------------------------- > OS: Windows Vista > Firefox: 3.0.9 > Ruby: 1.8.6 > -------------------------------- > > Is there anything I can do? > > Thanks, > > Taku > > On Wed, 22 Apr 2009 20:46:04 +0100 > Alex Collins wrote: > >> Taku, >> >> It wasn't a waste of my time at all. Glad you found the cause. >> Sorry I didn't have a chance to send more info - I had to get to a >> meeting. >> >> I have now integrated your code into my fork. I had a few issues >> although thankfully easy to resolve: >> >> 1) The new multibyte tests needed to be moved to their own class. >> Being in the same class (TC_Fields) and having the same method >> names, they 'overwrote' some other test methods that were failing. >> 2) Added a UTF-8 header to the HTML page - my default encoding >> meant it didn't get interpreted correctly. >> 3) Create separate fields in the HTML to avoid any execution order >> issues with the tests' actions. >> 4) Corrected the existing text_field tests which were failing - >> you'd added another text field for the new test so an index and >> count had changed. >> >> The only outstanding failure on my fork is the NoMethodError. I >> might look into implementing this shortly. >> >> Perhaps you could confirm that the multi byte code still works for >> you from my fork? >> >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 >> >> Alex >> >> >> On 22 Apr 2009, at 09:18, Taku Amano wrote: >> >>> Alex, >>> >>> Thank you for testing my code. >>> And I am sorry for wasting your time. >>> >>> The bug was included in the patch that I had sent ahead. >>> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >>> I did not notice because my development environment is ruby 1.8.7 >>> (Integer#ord backported to 1.8.7). >>> >>> Could you try this? >>> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >>> >>> Thanks, >>> >>> Taku >>> >>> On Wed, 22 Apr 2009 08:11:08 +0100 >>> Alex Collins wrote: >>> >>>> Taku, >>>> >>>> I get several unit test failures when running with these patches. >>>> Did you expect this? >>>> >>>> Alex >>>> >>>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>>> >>>>> Dear Bret, >>>>> >>>>> This patch enabled to insert multibyte characters into field. >>>>> >>>>> At FireWatir, multi byte character was not able to be inserted >>>>> into the text field due to the problem on the JSSh. >>>>> In this patch, that problem is solved by sending the character >>>>> that encodes URI, and restoring it with JavaScript's >>>>> decodeURIComponent. >>>>> I hope to be included into trunk for the improvement of the >>>>> portability though this patch becomes a mere overhead in the >>>>> environment that doesn't use multibyte character. >>>>> >>>>> Test: >>>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>>> >>>>> Handling of Multibyte characters: >>>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>>> >>>>> Thanks, >>>>> >>>>> -- >>>>> Name: Taku Amano >>>>> Mail: taku at toi-planning.net >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> Wtr-development at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 20:51:30 2009 From: taku at toi-planning.net (Taku Amano) Date: Thu, 23 Apr 2009 09:51:30 +0900 Subject: [Wtr-development] Fixed a method TC_Button#test_not_found_with_multi Message-ID: <20090423095130.8914c051.taku@toi-planning.net> This patch fixed a method TC_Button#test_not_found_with_multi At my environment (ruby 1.8.7), the original version of test_not_found_with_multi caused the following errors. --------------------------------------------------------------------------------------------------- 1) Failure: test_not_found_with_multi(TC_Button2) [/home/taku/watir/commonwatir/unittests/buttons_test.rb:204]: <"Unable to locate element, using {:index=>2, :value=>\"Click Me\"}"> expected but was <"Unable to locate element, using {:value=>\"Click Me\", :index=>2}">. --------------------------------------------------------------------------------------------------- This patch include the code from which dependence on the environment is removed. http://github.com/usualoma/watir/commit/bd534e98c3dbb05e46f51ecc86071465051e17e0 Taku -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at gmail.com Thu Apr 23 02:36:13 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Thu, 23 Apr 2009 07:36:13 +0100 Subject: [Wtr-development] Fixed a method TC_Button#test_not_found_with_multi In-Reply-To: <20090423095130.8914c051.taku@toi-planning.net> References: <20090423095130.8914c051.taku@toi-planning.net> Message-ID: Taku, Patch works fine for me on Ruby 1.8.6 / Mac OS X 10.5. Alex On 23 Apr 2009, at 01:51, Taku Amano wrote: > This patch fixed a method TC_Button#test_not_found_with_multi > > At my environment (ruby 1.8.7), the original version of > test_not_found_with_multi > caused the following errors. > --------------------------------------------------------------------------------------------------- > 1) Failure: > test_not_found_with_multi(TC_Button2) [/home/taku/watir/commonwatir/ > unittests/buttons_test.rb:204]: > <"Unable to locate element, using {:index=>2, :value=>\"Click Me > \"}"> expected but was > <"Unable to locate element, using {:value=>\"Click Me\", :index=>2}">. > --------------------------------------------------------------------------------------------------- > > This patch include the code from which dependence on the environment > is removed. > http://github.com/usualoma/watir/commit/bd534e98c3dbb05e46f51ecc86071465051e17e0 > > > Taku > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From bret at pettichord.com Wed Apr 1 11:49:49 2009 From: bret at pettichord.com (Bret Pettichord) Date: Wed, 1 Apr 2009 10:49:49 -0500 Subject: [Wtr-development] rexml In-Reply-To: <7ac2300c0903260405m194310dma55152e7251c0328@mail.gmail.com> References: <7ac2300c0903260405m194310dma55152e7251c0328@mail.gmail.com> Message-ID: Aidy, Can you provide more information about what you are doing and what error you are seeing? I can also say that I have had good luck with github support, both on their support site and on the #github irc channel. Bret On Thu, Mar 26, 2009 at 6:05 AM, aidy lewis wrote: > Hi, > > I forked Watir, but everyone time I edit I am asked for a new > admistration name. I cannot proceed with the current name. > > Aidy > > On 26/03/2009, ?eljko Filipin wrote: > > > From: Adrian Lewis > > > I am having problems forking on git hub. > > > > Aidy, > > > > I have been there recently too. :) > > > > Could you be more specific? What is the problem? > > > > ?eljko > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Sat Apr 11 11:56:40 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 16:56:40 +0100 Subject: [Wtr-development] git questions Message-ID: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> Hi,. I have forked Watir, cloned to a working copy and made rexml => nokogiri changes. I have changed the ie-class.rb, added a nokogiri test and deleted the rexml test. git sees data as blobs based on a hash-key, so do I need to add these files then commit to my local repo? Then do I push? Watir will also now depend on nokogiri, so do I add this line in the the gemspec s.add_dependency 'nokogiri' ? Thanks Aidy From aidy.lewis at googlemail.com Sat Apr 11 13:03:00 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 18:03:00 +0100 Subject: [Wtr-development] git questions In-Reply-To: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> Message-ID: <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> Hi, I seem to have made a commit and a push http://github.com/aidylewis/watir/commits/ But how do I view my changes? Aidy 2009/4/11 aidy lewis : > Hi,. > > I have forked Watir, cloned to a working copy and made rexml => > nokogiri changes. > > I have changed the ie-class.rb, added a nokogiri test and deleted the > rexml test. git sees data as blobs based on a hash-key, so do I need > to add these files then commit to my local repo? Then do I push? > > Watir will also now depend on nokogiri, so do I add this line in the the gemspec > > s.add_dependency 'nokogiri' ? > > Thanks > > Aidy > From bret at pettichord.com Sat Apr 11 14:05:25 2009 From: bret at pettichord.com (Bret Pettichord) Date: Sat, 11 Apr 2009 13:05:25 -0500 Subject: [Wtr-development] git questions In-Reply-To: <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> Message-ID: On Sat, Apr 11, 2009 at 12:03 PM, aidy lewis wrote: > Hi, > > I seem to have made a commit and a push > > http://github.com/aidylewis/watir/commits/ > > But how do I view my changes? You can click on the commit links on this page. I've also found gitk to be a handy tool for viewing history locally. Bret -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Sat Apr 11 14:28:26 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Sat, 11 Apr 2009 19:28:26 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> Message-ID: <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> Thanks Bret, I managed to commit, push to my repo and made a pull request to yours (I think). Aidy 2009/4/11 Bret Pettichord : > > > On Sat, Apr 11, 2009 at 12:03 PM, aidy lewis > wrote: >> >> Hi, >> >> I seem to have made a commit and a push >>to >> http://github.com/aidylewis/watir/commits/ >> >> But how do I view my changes? > > You can click on the commit links on this page. > > I've also found gitk to be a handy tool for viewing history locally. > > Bret > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From bret at pettichord.com Mon Apr 13 10:39:24 2009 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 13 Apr 2009 09:39:24 -0500 Subject: [Wtr-development] git questions In-Reply-To: <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> Message-ID: I took a quick look at the code. I'm wondering if you had a chance to run the xpath tests? Were there any issues? Was it faster? Not sure if I'll get a chance to look at this this week. Any one else want to look at this and give Aidy some feedback? Bret On Sat, Apr 11, 2009 at 1:28 PM, aidy lewis wrote: > Thanks Bret, > > I managed to commit, push to my repo and made a pull request to yours (I > think). > > Aidy > > 2009/4/11 Bret Pettichord : > > > > > > On Sat, Apr 11, 2009 at 12:03 PM, aidy lewis > > wrote: > >> > >> Hi, > >> > >> I seem to have made a commit and a push > >>to > >> http://github.com/aidylewis/watir/commits/ > >> > >> But how do I view my changes? > > > > You can click on the commit links on this page. > > > > I've also found gitk to be a handy tool for viewing history locally. > > > > Bret > > > > -- > > Bret Pettichord > > CTO, WatirCraft LLC, www.watircraft.com > > Lead Developer, Watir, www.watir.com > > > > Blog, www.io.com/~wazmo/blog > > Twitter, www.twitter.com/bpettichord > > GTalk: bpettichord at gmail.com > > > > Watir Training: Portland/Beaverton April 16-17 > > www.watircraft.com/training > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Mon Apr 13 12:37:29 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 13 Apr 2009 17:37:29 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> Message-ID: <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> Bret, 2009/4/13 Bret Pettichord : > I took a quick look at the code. I'm wondering if you had a chance to run > the xpath tests? Were there any issues? Was it faster? Ran the xpath tests some time ago with complete success. Around 3-5 times faster, but I am sure you would like empirical data. Aidy From bret at pettichord.com Mon Apr 13 12:41:57 2009 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 13 Apr 2009 11:41:57 -0500 Subject: [Wtr-development] git questions In-Reply-To: <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> Message-ID: On Mon, Apr 13, 2009 at 11:37 AM, aidy lewis wrote: > Bret, > > 2009/4/13 Bret Pettichord : > > I took a quick look at the code. I'm wondering if you had a chance to run > > the xpath tests? Were there any issues? Was it faster? > > Ran the xpath tests some time ago with complete success. Around 3-5 > times faster, but I am sure you would like empirical data. No, that sounds good. -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Mon Apr 13 13:15:49 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 13 Apr 2009 18:15:49 +0100 Subject: [Wtr-development] git questions In-Reply-To: References: <7ac2300c0904110856l2fc74bdfm54acd806f6b002c7@mail.gmail.com> <7ac2300c0904111003g22011cf8q1b6e7fa856b0d3ea@mail.gmail.com> <7ac2300c0904111128jd09453bj1c2828b02732a384@mail.gmail.com> <7ac2300c0904130937g7225a942i214b268b87cc89f6@mail.gmail.com> Message-ID: <7ac2300c0904131015u7f27c17aka95628aeb44b1e82@mail.gmail.com> Bret, Let me do some more test on the fork and get back to you. Aidy On 13/04/2009, Bret Pettichord wrote: > On Mon, Apr 13, 2009 at 11:37 AM, aidy lewis > wrote: > > > Bret, > > > > 2009/4/13 Bret Pettichord : > > > > > I took a quick look at the code. I'm wondering if you had a chance to > run > > > the xpath tests? Were there any issues? Was it faster? > > > > Ran the xpath tests some time ago with complete success. Around 3-5 > > times faster, but I am sure you would like empirical data. > > No, that sounds good. > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From paul.rogers at shaw.ca Fri Apr 17 11:35:43 2009 From: paul.rogers at shaw.ca (Paul Rogers) Date: Fri, 17 Apr 2009 09:35:43 -0600 Subject: [Wtr-development] Fwd: [Win32utils-devel] Please update your rubygems In-Reply-To: <000301c9bf1a$829f9080$87deb180$@com> References: <000301c9bf1a$829f9080$87deb180$@com> Message-ID: does this affect anything in watir? ---------- Forwarded message ---------- From: Daniel Berger Date: Thu, Apr 16, 2009 at 11:08 PM Subject: [Win32utils-devel] Please update your rubygems To: win32utils-devel at rubyforge.org Hi folks, I know, it's been a while since I posted. I've devoted most of my energy in the last few months to the latest release of rubygems. I highly recommend upgrading to 1.3.2 if you haven't done so already, as it fixes an issue brought up by Montgomery Kosma where require'ing any file after require'ing win32-file would cause a LoadError. It also fixed an issue with rubygems creating extraneous quotation marks when generating .bat files. In other news, one of the next issues in rubygems we will need to tackle (brought up by Luis Lavena) is how to tag gems for specific versions of Ruby. Specifically, if you want to generate two separate binary gems with the same name, but for different versions of ruby, there's no way to distinguish the gems short of using a different version number. This is largely an MS Windows issue, so I thought it worthwhile to bring up here. See http://rubyforge.org/pipermail/rubygems-developers/2009-April/004522.html and following. Suggestions welcome. Regards, Dan _______________________________________________ win32utils-devel mailing list win32utils-devel at rubyforge.org http://rubyforge.org/mailman/listinfo/win32utils-devel -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Mon Apr 20 10:26:15 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 20 Apr 2009 15:26:15 +0100 Subject: [Wtr-development] aidy_lewis fork Message-ID: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> H Bret This fork: http://github.com/aidylewis/watir/tree/master seems stable and significantly increases xpath speed. Aidy -- blog: www.agiletester.co.uk twitter: http://twitter.com/aidy_lewis From bret at pettichord.com Mon Apr 20 10:31:17 2009 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 20 Apr 2009 09:31:17 -0500 Subject: [Wtr-development] aidy_lewis fork In-Reply-To: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> References: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> Message-ID: ok thanks. i would like to release a new version of Watir this week. Bret On Mon, Apr 20, 2009 at 9:26 AM, aidy lewis wrote: > H Bret > > This fork: > > http://github.com/aidylewis/watir/tree/master > > seems stable and significantly increases xpath speed. > > Aidy > > -- > blog: www.agiletester.co.uk > twitter: http://twitter.com/aidy_lewis > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From rslawrence at gmail.com Mon Apr 20 11:15:33 2009 From: rslawrence at gmail.com (Richard Lawrence) Date: Mon, 20 Apr 2009 09:15:33 -0600 Subject: [Wtr-development] aidy_lewis fork In-Reply-To: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> References: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> Message-ID: Hi Aidy, Does the switch to nokogiri mean that CSS selectors are supported in Watir now? Thanks, Richard On Mon, Apr 20, 2009 at 8:26 AM, aidy lewis wrote: > H Bret > > This fork: > > http://github.com/aidylewis/watir/tree/master > > seems stable and significantly increases xpath speed. > > Aidy > > -- > blog: www.agiletester.co.uk > twitter: http://twitter.com/aidy_lewis > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From bret at pettichord.com Mon Apr 20 11:25:53 2009 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 20 Apr 2009 10:25:53 -0500 Subject: [Wtr-development] New Release of Watir Message-ID: I would like to get a new release of Watir out shortly. There is a lot of fixes and features in trunk that need to be released. We also have some contributions on forks (e.g. Aidy's xml improvement) that need to be merged into master. I will probably do a build and release to the Wiki first, to get some beta testing on the release. I need to compile release notes on the work to date in trunk. Our last release was last fall. We need to decide what to call this. We could call it 1.6.3 or 1.7.0; i'm leaning towards the latter, but am interested in opinions on this. I need your help with patches. If there are patches in Jira that we should consider, please consider reviewing them. If you have a change you want to see in this release, please speak up. Bret -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From aidy.lewis at googlemail.com Mon Apr 20 12:29:01 2009 From: aidy.lewis at googlemail.com (aidy lewis) Date: Mon, 20 Apr 2009 17:29:01 +0100 Subject: [Wtr-development] aidy_lewis fork In-Reply-To: References: <7ac2300c0904200726s4d140c0ata30645263ceac2e1@mail.gmail.com> Message-ID: <7ac2300c0904200929s7a37d5eeg62a64c769dd0f72d@mail.gmail.com> Nope. Just a direct substitute for REXML to increase performance. Aidy 2009/4/20 Richard Lawrence : > Hi Aidy, > > Does the switch to nokogiri mean that CSS selectors are supported in Watir now? > > Thanks, > > Richard > > On Mon, Apr 20, 2009 at 8:26 AM, aidy lewis wrote: >> H Bret >> >> This fork: >> >> http://github.com/aidylewis/watir/tree/master >> >> seems stable and significantly increases xpath speed. >> >> Aidy >> >> -- >> blog: www.agiletester.co.uk >> twitter: http://twitter.com/aidy_lewis >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- blog: www.agiletester.co.uk twitter: http://twitter.com/aidy_lewis From bret at pettichord.com Mon Apr 20 18:46:59 2009 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 20 Apr 2009 17:46:59 -0500 Subject: [Wtr-development] Watir.com migration Message-ID: Alister, Just talked to Charley. He doesn't have the time to complete the Watir.com migration. He says you have all the passwords. Are you willing and able to finish the migration? I have time this week to help, although I really don't know anything about how to administer these systems. Bret -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Watir Training: Portland/Beaverton April 16-17 www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at cantab.net Tue Apr 21 02:59:02 2009 From: a.j.collins.02 at cantab.net (Alex Collins) Date: Tue, 21 Apr 2009 07:59:02 +0100 Subject: [Wtr-development] New Release of Watir In-Reply-To: References: Message-ID: Bret, I've separated out the JSSH code into a separate class to make it a little easier to understand what is going on and to tidy up the calling code. I still have a little more tidying up to do on this, including hooking in a NoMethodFound exception (reason for pulling the JSSH together). However, I am keen to get this into the release (or one in the near future). I'll try and get this finished this evening and pushed back to my fork. I would lean towards 1.7.0 given Aidy's change and potentially mine, above. Alex On 20 Apr 2009, at 16:25, Bret Pettichord wrote: > I would like to get a new release of Watir out shortly. There is a > lot of fixes and features in trunk that need to be released. We also > have some contributions on forks (e.g. Aidy's xml improvement) that > need to be merged into master. > > I will probably do a build and release to the Wiki first, to get > some beta testing on the release. > > I need to compile release notes on the work to date in trunk. Our > last release was last fall. > > We need to decide what to call this. We could call it 1.6.3 or > 1.7.0; i'm leaning towards the latter, but am interested in opinions > on this. > > I need your help with patches. If there are patches in Jira that we > should consider, please consider reviewing them. > > If you have a change you want to see in this release, please speak up. > > Bret > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at gmail.com Tue Apr 21 02:59:24 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Tue, 21 Apr 2009 07:59:24 +0100 Subject: [Wtr-development] New Release of Watir In-Reply-To: References: Message-ID: Bret, I've separated out the JSSH code into a separate class to make it a little easier to understand what is going on and to tidy up the calling code. I still have a little more tidying up to do on this, including hooking in a NoMethodFound exception (reason for pulling the JSSH together). However, I am keen to get this into the release (or one in the near future). I'll try and get this finished this evening and pushed back to my fork. I would lean towards 1.7.0 given Aidy's change and potentially mine, above. Alex On 20 Apr 2009, at 16:25, Bret Pettichord wrote: > I would like to get a new release of Watir out shortly. There is a > lot of fixes and features in trunk that need to be released. We also > have some contributions on forks (e.g. Aidy's xml improvement) that > need to be merged into master. > > I will probably do a build and release to the Wiki first, to get > some beta testing on the release. > > I need to compile release notes on the work to date in trunk. Our > last release was last fall. > > We need to decide what to call this. We could call it 1.6.3 or > 1.7.0; i'm leaning towards the latter, but am interested in opinions > on this. > > I need your help with patches. If there are patches in Jira that we > should consider, please consider reviewing them. > > If you have a change you want to see in this release, please speak up. > > Bret > > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Watir Training: Portland/Beaverton April 16-17 > www.watircraft.com/training > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development -------------- next part -------------- An HTML attachment was scrubbed... URL: From zeljko.filipin at wa-research.ch Tue Apr 21 03:57:43 2009 From: zeljko.filipin at wa-research.ch (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 21 Apr 2009 09:57:43 +0200 Subject: [Wtr-development] Watir.com migration In-Reply-To: References: Message-ID: On Tue, Apr 21, 2009 at 00:46, Bret Pettichord wrote: > I have time this week to help, although I really don't know anything about how to administer these systems. Same here. I will not sleep if needed, just to get watir.com live. :) But I have no idea what has to be done. Alister, if you need any help, let me know. ?eljko -------------- next part -------------- An HTML attachment was scrubbed... URL: From zeljko.filipin at wa-research.ch Tue Apr 21 04:09:01 2009 From: zeljko.filipin at wa-research.ch (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 21 Apr 2009 10:09:01 +0200 Subject: [Wtr-development] New Release of Watir In-Reply-To: References: Message-ID: On Tue, Apr 21, 2009 at 08:59, Alex Collins wrote: > I would lean towards 1.7.0 +1 ?eljko -------------- next part -------------- An HTML attachment was scrubbed... URL: From charley.baker at gmail.com Tue Apr 21 13:01:17 2009 From: charley.baker at gmail.com (Charley Baker) Date: Tue, 21 Apr 2009 10:01:17 -0700 Subject: [Wtr-development] New Release of Watir In-Reply-To: References: Message-ID: If we do include Alex and Aidy's changes along with the existing fixes and changes, I'd also vote for 1.7.0. -c On Tue, Apr 21, 2009 at 1:09 AM, ?eljko Filipin wrote: > On Tue, Apr 21, 2009 at 08:59, Alex Collins > wrote: > > I would lean towards 1.7.0 > > +1 > > ?eljko > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at gmail.com Tue Apr 21 19:06:47 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 00:06:47 +0100 Subject: [Wtr-development] FireWatir - Separation of JSSH code into separate class Message-ID: All, I've spent a little time over the past few days trying to separate out the existing JSSH interface into a separate class in an attempt to clean up this interface. The original intention was to implement the NoMethodError when you call a method that does not exist. I have not yet added this, although I have added a test for it. I have also amended a FireWatir unit test and the commonwatir watir- unittest.rb; I discovered a unit test incorrectly assigning to a local variable 'browser' when it ought to have been reassigning $browser. There is now an accessor method, so test methods can can self.browser=new_browser to reassign the browser, if required. I would appreciate any review of the code changes / testing / issue reports etc. My fork is on github: http://github.com/ajcollins/watir/tree/master git clone git://github.com/ajcollins/watir.git Information about my changes: I have cut out much of the JSSH code and reduced it to a single method, #execute(command) which prepares and sends the command, retrieves the result and checks for errors. This cuts down on repetitive code elsewhere - some of which still requires removal - additional stripping of new lines, for example. My new test is failing, others are all ok on OS X. However, I have added a workaround for 5 of these: test_table_with_hidden_or_visible_rows(TC_Tables_Buttons) test_simple_table_buttons(TC_Tables_Buttons) test_using_text_on_form(TC_Forms4) test_objects_in_span(TC_Divs) test_objects_in_div(TC_Divs) I believe at present (although may be incorrect) that these tests should previously have failed because elements.rb#fire_event / #click issues an invalid jssh command when constructing events if @container.document_var is nil. However, as the #send and #read_socket pairing did not check for errors, these issues were concealed. This now results in an exception as follows, we can see that the document element is missing from the .createEvent call: test_objects_in_div(TC_Divs): JSSHInterface::JSSyntaxError: syntax error Command: var event = .createEvent("HTMLEvents"); event.initEvent("select", true, true); elements_0_input[0].dispatchEvent(event); Response: SyntaxError: syntax error Fixing this requires finishing the code surrounding document_var etc in firefox.rb and frame.rb and understanding / documenting it. For the time being, I have added a check to elements.rb#fire_event that executes the jssh command unless @container.document_var.empty? This is accompanied by a TODO. I have incremented my version to 1.7.0-unstable for testing. This does not include any of Aidy's changes. Alex From taku at toi-planning.net Tue Apr 21 21:15:08 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 10:15:08 +0900 Subject: [Wtr-development] maxlength patch for TextField#doKeyPress of FireWatir Message-ID: <20090422101508.02638f5e.taku@toi-planning.net> Dear Bret, My name is Taku Amano and I want to contribute to the project of Watier. This patch fixed TextField#doKeyPress in FireWatir. In TextField#doKeyPress of FireWatir, maxlength attributes was checked, but when the value had already been set to the field, it was not checked correctly. This patch include test code of textfield's maxlength and fixed code of TextField#doKeyPress. Test: http://github.com/usualoma/watir/commit/ed6350e880d1f1c9943350cc0ccd32fe19467726 http://github.com/usualoma/watir/commit/24a60eeb186f0f07c4b134c46ca23fe8ba59a06d TextField#doKeyPress: http://github.com/usualoma/watir/commit/d5fce9a24b5baedeed4e18493e9e4d024b425091 And, because I have only poor English skill, I hope you will correct log message if the expression is not correct. Thanks, -- Name: Taku Amano Mail: taku at toi-planning.net From taku at toi-planning.net Tue Apr 21 21:17:03 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 10:17:03 +0900 Subject: [Wtr-development] Insert multibyte characters into field Message-ID: <20090422101703.76d3575e.taku@toi-planning.net> Dear Bret, This patch enabled to insert multibyte characters into field. At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. Test: http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 Handling of Multibyte characters: http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 Thanks, -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at gmail.com Wed Apr 22 03:11:08 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 08:11:08 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090422101703.76d3575e.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> Message-ID: Taku, I get several unit test failures when running with these patches. Did you expect this? Alex On 22 Apr 2009, at 02:17, Taku Amano wrote: > Dear Bret, > > This patch enabled to insert multibyte characters into field. > > At FireWatir, multi byte character was not able to be inserted into > the text field due to the problem on the JSSh. > In this patch, that problem is solved by sending the character that > encodes URI, and restoring it with JavaScript's decodeURIComponent. > I hope to be included into trunk for the improvement of the > portability though this patch becomes a mere overhead in the > environment that doesn't use multibyte character. > > Test: > http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 > > Handling of Multibyte characters: > http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 > > Thanks, > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 04:18:24 2009 From: taku at toi-planning.net (Taku Amano) Date: Wed, 22 Apr 2009 17:18:24 +0900 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: References: <20090422101703.76d3575e.taku@toi-planning.net> Message-ID: <20090422171824.035f049c.taku@toi-planning.net> Alex, Thank you for testing my code. And I am sorry for wasting your time. The bug was included in the patch that I had sent ahead. Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. I did not notice because my development environment is ruby 1.8.7 (Integer#ord backported to 1.8.7). Could you try this? http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c Thanks, Taku On Wed, 22 Apr 2009 08:11:08 +0100 Alex Collins wrote: >Taku, > >I get several unit test failures when running with these patches. Did you expect this? > >Alex > >On 22 Apr 2009, at 02:17, Taku Amano wrote: > >> Dear Bret, >> >> This patch enabled to insert multibyte characters into field. >> >> At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. >> In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. >> I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. >> >> Test: >> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >> >> Handling of Multibyte characters: >> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >> >> Thanks, >> >> -- >> Name: Taku Amano >> Mail: taku at toi-planning.net >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development > >_______________________________________________ >Wtr-development mailing list >Wtr-development at rubyforge.org >http://rubyforge.org/mailman/listinfo/wtr-development > -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at gmail.com Wed Apr 22 15:46:04 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 20:46:04 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090422171824.035f049c.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> Message-ID: Taku, It wasn't a waste of my time at all. Glad you found the cause. Sorry I didn't have a chance to send more info - I had to get to a meeting. I have now integrated your code into my fork. I had a few issues although thankfully easy to resolve: 1) The new multibyte tests needed to be moved to their own class. Being in the same class (TC_Fields) and having the same method names, they 'overwrote' some other test methods that were failing. 2) Added a UTF-8 header to the HTML page - my default encoding meant it didn't get interpreted correctly. 3) Create separate fields in the HTML to avoid any execution order issues with the tests' actions. 4) Corrected the existing text_field tests which were failing - you'd added another text field for the new test so an index and count had changed. The only outstanding failure on my fork is the NoMethodError. I might look into implementing this shortly. Perhaps you could confirm that the multi byte code still works for you from my fork? My commit: http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 Alex On 22 Apr 2009, at 09:18, Taku Amano wrote: > Alex, > > Thank you for testing my code. > And I am sorry for wasting your time. > > The bug was included in the patch that I had sent ahead. > Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. > I did not notice because my development environment is ruby 1.8.7 > (Integer#ord backported to 1.8.7). > > Could you try this? > http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c > > Thanks, > > Taku > > On Wed, 22 Apr 2009 08:11:08 +0100 > Alex Collins wrote: > >> Taku, >> >> I get several unit test failures when running with these patches. >> Did you expect this? >> >> Alex >> >> On 22 Apr 2009, at 02:17, Taku Amano wrote: >> >>> Dear Bret, >>> >>> This patch enabled to insert multibyte characters into field. >>> >>> At FireWatir, multi byte character was not able to be inserted >>> into the text field due to the problem on the JSSh. >>> In this patch, that problem is solved by sending the character >>> that encodes URI, and restoring it with JavaScript's >>> decodeURIComponent. >>> I hope to be included into trunk for the improvement of the >>> portability though this patch becomes a mere overhead in the >>> environment that doesn't use multibyte character. >>> >>> Test: >>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>> >>> Handling of Multibyte characters: >>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>> >>> Thanks, >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 17:16:13 2009 From: taku at toi-planning.net (Taku Amano) Date: Thu, 23 Apr 2009 06:16:13 +0900 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> Message-ID: <20090423061613.e1bbd3fb.taku@toi-planning.net> Alex, Thank you for confirming and integrating. And thank you very much for fixing of 1-4. I confirmed the test of this committing did not fail. >My commit: >http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 Confirmed in these environment. -------------------------------- OS: Debian GNU/Linux Firefox: 3.0.7 Ruby: 1.8.7 -------------------------------- OS: Windows Vista Firefox: 3.0.9 Ruby: 1.8.6 -------------------------------- Is there anything I can do? Thanks, Taku On Wed, 22 Apr 2009 20:46:04 +0100 Alex Collins wrote: >Taku, > >It wasn't a waste of my time at all. Glad you found the cause. Sorry I didn't have a chance to send more info - I had to get to a meeting. > >I have now integrated your code into my fork. I had a few issues although thankfully easy to resolve: > >1) The new multibyte tests needed to be moved to their own class. Being in the same class (TC_Fields) and having the same method names, they 'overwrote' some other test methods that were failing. >2) Added a UTF-8 header to the HTML page - my default encoding meant it didn't get interpreted correctly. >3) Create separate fields in the HTML to avoid any execution order issues with the tests' actions. >4) Corrected the existing text_field tests which were failing - you'd added another text field for the new test so an index and count had changed. > >The only outstanding failure on my fork is the NoMethodError. I might look into implementing this shortly. > >Perhaps you could confirm that the multi byte code still works for you from my fork? > >My commit: >http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > >Alex > > >On 22 Apr 2009, at 09:18, Taku Amano wrote: > >> Alex, >> >> Thank you for testing my code. >> And I am sorry for wasting your time. >> >> The bug was included in the patch that I had sent ahead. >> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >> I did not notice because my development environment is ruby 1.8.7 (Integer#ord backported to 1.8.7). >> >> Could you try this? >> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >> >> Thanks, >> >> Taku >> >> On Wed, 22 Apr 2009 08:11:08 +0100 >> Alex Collins wrote: >> >>> Taku, >>> >>> I get several unit test failures when running with these patches. Did you expect this? >>> >>> Alex >>> >>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>> >>>> Dear Bret, >>>> >>>> This patch enabled to insert multibyte characters into field. >>>> >>>> At FireWatir, multi byte character was not able to be inserted into the text field due to the problem on the JSSh. >>>> In this patch, that problem is solved by sending the character that encodes URI, and restoring it with JavaScript's decodeURIComponent. >>>> I hope to be included into trunk for the improvement of the portability though this patch becomes a mere overhead in the environment that doesn't use multibyte character. >>>> >>>> Test: >>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>> >>>> Handling of Multibyte characters: >>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>> >>>> Thanks, >>>> >>>> -- >>>> Name: Taku Amano >>>> Mail: taku at toi-planning.net >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >> >> >> -- >> Name: Taku Amano >> Mail: taku at toi-planning.net >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development > >_______________________________________________ >Wtr-development mailing list >Wtr-development at rubyforge.org >http://rubyforge.org/mailman/listinfo/wtr-development > -- Name: Taku Amano Mail: taku at toi-planning.net From a.j.collins.02 at cantab.net Wed Apr 22 17:50:12 2009 From: a.j.collins.02 at cantab.net (Alex Collins) Date: Wed, 22 Apr 2009 22:50:12 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090423061613.e1bbd3fb.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> <20090423061613.e1bbd3fb.taku@toi-planning.net> Message-ID: <955C51B4-8D3C-458A-A140-E6795D49DAFC@cantab.net> Taku, I'm still playing with fitting in the NoMethodError exception. I seem to break something wherever I place the check. Super work confirming it on both Linux and Vista. I've not yet fired up the virtual machines for this. I doubt that there is anything else to do - really it is up to Bret, I think. Alex On 22 Apr 2009, at 22:16, Taku Amano wrote: > Alex, > > Thank you for confirming and integrating. > And thank you very much for fixing of 1-4. > > I confirmed the test of this committing did not fail. >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > Confirmed in these environment. > -------------------------------- > OS: Debian GNU/Linux > Firefox: 3.0.7 > Ruby: 1.8.7 > -------------------------------- > OS: Windows Vista > Firefox: 3.0.9 > Ruby: 1.8.6 > -------------------------------- > > Is there anything I can do? > > Thanks, > > Taku > > On Wed, 22 Apr 2009 20:46:04 +0100 > Alex Collins wrote: > >> Taku, >> >> It wasn't a waste of my time at all. Glad you found the cause. >> Sorry I didn't have a chance to send more info - I had to get to a >> meeting. >> >> I have now integrated your code into my fork. I had a few issues >> although thankfully easy to resolve: >> >> 1) The new multibyte tests needed to be moved to their own class. >> Being in the same class (TC_Fields) and having the same method >> names, they 'overwrote' some other test methods that were failing. >> 2) Added a UTF-8 header to the HTML page - my default encoding >> meant it didn't get interpreted correctly. >> 3) Create separate fields in the HTML to avoid any execution order >> issues with the tests' actions. >> 4) Corrected the existing text_field tests which were failing - >> you'd added another text field for the new test so an index and >> count had changed. >> >> The only outstanding failure on my fork is the NoMethodError. I >> might look into implementing this shortly. >> >> Perhaps you could confirm that the multi byte code still works for >> you from my fork? >> >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 >> >> Alex >> >> >> On 22 Apr 2009, at 09:18, Taku Amano wrote: >> >>> Alex, >>> >>> Thank you for testing my code. >>> And I am sorry for wasting your time. >>> >>> The bug was included in the patch that I had sent ahead. >>> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >>> I did not notice because my development environment is ruby 1.8.7 >>> (Integer#ord backported to 1.8.7). >>> >>> Could you try this? >>> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >>> >>> Thanks, >>> >>> Taku >>> >>> On Wed, 22 Apr 2009 08:11:08 +0100 >>> Alex Collins wrote: >>> >>>> Taku, >>>> >>>> I get several unit test failures when running with these patches. >>>> Did you expect this? >>>> >>>> Alex >>>> >>>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>>> >>>>> Dear Bret, >>>>> >>>>> This patch enabled to insert multibyte characters into field. >>>>> >>>>> At FireWatir, multi byte character was not able to be inserted >>>>> into the text field due to the problem on the JSSh. >>>>> In this patch, that problem is solved by sending the character >>>>> that encodes URI, and restoring it with JavaScript's >>>>> decodeURIComponent. >>>>> I hope to be included into trunk for the improvement of the >>>>> portability though this patch becomes a mere overhead in the >>>>> environment that doesn't use multibyte character. >>>>> >>>>> Test: >>>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>>> >>>>> Handling of Multibyte characters: >>>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>>> >>>>> Thanks, >>>>> >>>>> -- >>>>> Name: Taku Amano >>>>> Mail: taku at toi-planning.net >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> Wtr-development at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From a.j.collins.02 at gmail.com Wed Apr 22 17:50:56 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Wed, 22 Apr 2009 22:50:56 +0100 Subject: [Wtr-development] Insert multibyte characters into field In-Reply-To: <20090423061613.e1bbd3fb.taku@toi-planning.net> References: <20090422101703.76d3575e.taku@toi-planning.net> <20090422171824.035f049c.taku@toi-planning.net> <20090423061613.e1bbd3fb.taku@toi-planning.net> Message-ID: <719FA674-87D5-4181-876B-129C9971C3DA@gmail.com> Taku, I'm still playing with fitting in the NoMethodError exception. I seem to break something wherever I place the check. Super work confirming it on both Linux and Vista. I've not yet fired up the virtual machines for this. I doubt that there is anything else to do - really it is up to Bret, I think. Alex On 22 Apr 2009, at 22:16, Taku Amano wrote: > Alex, > > Thank you for confirming and integrating. > And thank you very much for fixing of 1-4. > > I confirmed the test of this committing did not fail. >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 > Confirmed in these environment. > -------------------------------- > OS: Debian GNU/Linux > Firefox: 3.0.7 > Ruby: 1.8.7 > -------------------------------- > OS: Windows Vista > Firefox: 3.0.9 > Ruby: 1.8.6 > -------------------------------- > > Is there anything I can do? > > Thanks, > > Taku > > On Wed, 22 Apr 2009 20:46:04 +0100 > Alex Collins wrote: > >> Taku, >> >> It wasn't a waste of my time at all. Glad you found the cause. >> Sorry I didn't have a chance to send more info - I had to get to a >> meeting. >> >> I have now integrated your code into my fork. I had a few issues >> although thankfully easy to resolve: >> >> 1) The new multibyte tests needed to be moved to their own class. >> Being in the same class (TC_Fields) and having the same method >> names, they 'overwrote' some other test methods that were failing. >> 2) Added a UTF-8 header to the HTML page - my default encoding >> meant it didn't get interpreted correctly. >> 3) Create separate fields in the HTML to avoid any execution order >> issues with the tests' actions. >> 4) Corrected the existing text_field tests which were failing - >> you'd added another text field for the new test so an index and >> count had changed. >> >> The only outstanding failure on my fork is the NoMethodError. I >> might look into implementing this shortly. >> >> Perhaps you could confirm that the multi byte code still works for >> you from my fork? >> >> My commit: >> http://github.com/ajcollins/watir/commit/f9271bf6f5ab120f46cdaddb612623f0004a2db0 >> >> Alex >> >> >> On 22 Apr 2009, at 09:18, Taku Amano wrote: >> >>> Alex, >>> >>> Thank you for testing my code. >>> And I am sorry for wasting your time. >>> >>> The bug was included in the patch that I had sent ahead. >>> Integer#ord (ruby 1.9 feacture) used in TextField#doKeyPress. >>> I did not notice because my development environment is ruby 1.8.7 >>> (Integer#ord backported to 1.8.7). >>> >>> Could you try this? >>> http://github.com/usualoma/watir/commit/f62512516e0d2ffc1c71cf96ce39f6c21e07fc4c >>> >>> Thanks, >>> >>> Taku >>> >>> On Wed, 22 Apr 2009 08:11:08 +0100 >>> Alex Collins wrote: >>> >>>> Taku, >>>> >>>> I get several unit test failures when running with these patches. >>>> Did you expect this? >>>> >>>> Alex >>>> >>>> On 22 Apr 2009, at 02:17, Taku Amano wrote: >>>> >>>>> Dear Bret, >>>>> >>>>> This patch enabled to insert multibyte characters into field. >>>>> >>>>> At FireWatir, multi byte character was not able to be inserted >>>>> into the text field due to the problem on the JSSh. >>>>> In this patch, that problem is solved by sending the character >>>>> that encodes URI, and restoring it with JavaScript's >>>>> decodeURIComponent. >>>>> I hope to be included into trunk for the improvement of the >>>>> portability though this patch becomes a mere overhead in the >>>>> environment that doesn't use multibyte character. >>>>> >>>>> Test: >>>>> http://github.com/usualoma/watir/commit/676f2f60e1786cff5c7729da5712e3dead1d4aa9 >>>>> >>>>> Handling of Multibyte characters: >>>>> http://github.com/usualoma/watir/commit/51a008a467a4d0a17334dfa79683dc96880f58e9 >>>>> >>>>> Thanks, >>>>> >>>>> -- >>>>> Name: Taku Amano >>>>> Mail: taku at toi-planning.net >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> Wtr-development at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> Wtr-development at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >>> >>> -- >>> Name: Taku Amano >>> Mail: taku at toi-planning.net >>> _______________________________________________ >>> Wtr-development mailing list >>> Wtr-development at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/wtr-development >> >> _______________________________________________ >> Wtr-development mailing list >> Wtr-development at rubyforge.org >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development From taku at toi-planning.net Wed Apr 22 20:51:30 2009 From: taku at toi-planning.net (Taku Amano) Date: Thu, 23 Apr 2009 09:51:30 +0900 Subject: [Wtr-development] Fixed a method TC_Button#test_not_found_with_multi Message-ID: <20090423095130.8914c051.taku@toi-planning.net> This patch fixed a method TC_Button#test_not_found_with_multi At my environment (ruby 1.8.7), the original version of test_not_found_with_multi caused the following errors. --------------------------------------------------------------------------------------------------- 1) Failure: test_not_found_with_multi(TC_Button2) [/home/taku/watir/commonwatir/unittests/buttons_test.rb:204]: <"Unable to locate element, using {:index=>2, :value=>\"Click Me\"}"> expected but was <"Unable to locate element, using {:value=>\"Click Me\", :index=>2}">. --------------------------------------------------------------------------------------------------- This patch include the code from which dependence on the environment is removed. http://github.com/usualoma/watir/commit/bd534e98c3dbb05e46f51ecc86071465051e17e0 Taku -- Name: Taku Amano Mail: taku at toi-planning.net From bret at pettichord.com Wed Apr 22 23:37:21 2009 From: bret at pettichord.com (Bret Pettichord) Date: Wed, 22 Apr 2009 22:37:21 -0500 Subject: [Wtr-development] Helping with Patches Message-ID: I appreciate those of you who are working on Watir forks. I'm a bit behind on reviewing your work, but plan to catch up tomorrow. Today, I've been tagging Jira tickets, with a special eye for tickets that have patches attached. I would really appreciate help in reviewing these patches. Here is the list: http://jira.openqa.org/secure/IssueNavigator.jspa?mode=hide&requestId=10474 I would love it if you could A. Review the patch, try it out and see if you can confirm that it fixes the problem. Please add a comment with your findings. B. (Better yet), Sometimes, the patch is a code snippet with a lot of context, so if you could figure out how to apply it and supply a universal/context diff that would help even more. C. (Even better). I'm pretty reluctant to accept new features without tests. You could supply tests for the new feature. D. (Best). You could fork Watir on github and apply the patch to your fork and submit it that way. This is the easiest for me to handle. Bret -- Bret Pettichord CTO, WatirCraft LLC, www.watircraft.com Lead Developer, Watir, www.watir.com Blog, www.io.com/~wazmo/blog Twitter, www.twitter.com/bpettichord GTalk: bpettichord at gmail.com Ask Me About Watir Training www.watircraft.com/training -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at gmail.com Thu Apr 23 02:33:38 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Thu, 23 Apr 2009 07:33:38 +0100 Subject: [Wtr-development] Helping with Patches In-Reply-To: References: Message-ID: Bret, I'll take a look at the FireWatir patches as they could be affected by my changes. If they work, I'll push them into my fork. Alex On 23 Apr 2009, at 04:37, Bret Pettichord wrote: > I appreciate those of you who are working on Watir forks. I'm a bit > behind on reviewing your work, but plan to catch up tomorrow. > > Today, I've been tagging Jira tickets, with a special eye for > tickets that have patches attached. I would really appreciate help > in reviewing these patches. Here is the list: > http://jira.openqa.org/secure/IssueNavigator.jspa?mode=hide&requestId=10474 > > I would love it if you could > A. Review the patch, try it out and see if you can confirm that it > fixes the problem. Please add a comment with your findings. > B. (Better yet), Sometimes, the patch is a code snippet with a lot > of context, so if you could figure out how to apply it and supply a > universal/context diff that would help even more. > C. (Even better). I'm pretty reluctant to accept new features > without tests. You could supply tests for the new feature. > D. (Best). You could fork Watir on github and apply the patch to > your fork and submit it that way. This is the easiest for me to > handle. > > Bret > -- > Bret Pettichord > CTO, WatirCraft LLC, www.watircraft.com > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog > Twitter, www.twitter.com/bpettichord > GTalk: bpettichord at gmail.com > > Ask Me About Watir Training > www.watircraft.com/training > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.j.collins.02 at gmail.com Thu Apr 23 02:36:13 2009 From: a.j.collins.02 at gmail.com (Alex Collins) Date: Thu, 23 Apr 2009 07:36:13 +0100 Subject: [Wtr-development] Fixed a method TC_Button#test_not_found_with_multi In-Reply-To: <20090423095130.8914c051.taku@toi-planning.net> References: <20090423095130.8914c051.taku@toi-planning.net> Message-ID: Taku, Patch works fine for me on Ruby 1.8.6 / Mac OS X 10.5. Alex On 23 Apr 2009, at 01:51, Taku Amano wrote: > This patch fixed a method TC_Button#test_not_found_with_multi > > At my environment (ruby 1.8.7), the original version of > test_not_found_with_multi > caused the following errors. > --------------------------------------------------------------------------------------------------- > 1) Failure: > test_not_found_with_multi(TC_Button2) [/home/taku/watir/commonwatir/ > unittests/buttons_test.rb:204]: > <"Unable to locate element, using {:index=>2, :value=>\"Click Me > \"}"> expected but was > <"Unable to locate element, using {:value=>\"Click Me\", :index=>2}">. > --------------------------------------------------------------------------------------------------- > > This patch include the code from which dependence on the environment > is removed. > http://github.com/usualoma/watir/commit/bd534e98c3dbb05e46f51ecc86071465051e17e0 > > > Taku > > -- > Name: Taku Amano > Mail: taku at toi-planning.net > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development