[Wtr-development] [Wtr-core] Reuniting Watir

Bret Pettichord bret at pettichord.com
Thu May 8 10:43:59 EDT 2008


My suggestion would be to move FireWatir into the OpenQA Watir repository.
Previously we did this with a copy into trunk/watir/vendor, but I now think
this was the wrong place and instead it should be top-level, parallel with
Watir itself (trunk/firewatir).

We also would like to eventually migrate this repository (and jira,
confluence, etc) to a new host, Watir.com, but aren't ready to start on that
yet (just too busy with other stuff).

Bret

On Thu, May 8, 2008 at 1:15 AM, Angrez Singh <angrez at gmail.com> wrote:

> Bret,
>
> Any idea as in where we are having the SVN repository?
>
> - Angrez
>
>
> On Wed, May 7, 2008 at 9:11 PM, Bret Pettichord <bret at pettichord.com>
> wrote:
>
>> Angrez,
>>
>> What i would like to be able to do is refactor the two code bases,
>> step-by-step, and create common code used by both.
>>
>> The next step would be to move both code bases into the same SVN
>> repository, and make sure that committers on both projects had access to
>> both code bases. This allows us to incrementally refactor code, increasing
>> common code while keeping both tools working. I would like to set up a
>> continuous integration server (cruisecontrol.rb) that would automatically
>> execute the unit tests for each project as a way of publicly notifying us if
>> any changes break either implementation.
>>
>> For example, suppose that there are four identical methods in both
>> implementation's Container module. These could be extracted into a new mixin
>> and then included into each. We would have to create a common library that
>> would be used by both projects and the code would have to live there.
>> Anyway, because we would have the code under continuous integration, we
>> wouldn't have to work out all these details by email (which can be time
>> consuming). Instead, we could just use the tests to assure us that the
>> changes we're making don't break anything.
>>
>> Unless i hear principled objections to this plan, I am going to go ahead
>> and start working on the continuous integration server.
>>
>> Bret
>>
>>
>> On Tue, May 6, 2008 at 11:55 PM, Angrez Singh <angrez at gmail.com> wrote:
>>
>>> Hi Bret,
>>>
>>> I am all in for refactoring. What we did in Firewatir is that we have
>>> container class in separate file. All HTML element classes in separate file.
>>> Element location logic and logic for firing the events, getting values,
>>> doing operations on elements is there in another file.
>>>
>>> I don't think if we are diverting from Firewatir code base, I'll have a
>>> look at current watir code and will let you know how easy/difficult is it to
>>> be going further with integration.
>>>
>>> - Angrez
>>>
>>>
>>> On Wed, May 7, 2008 at 5:25 AM, Bret Pettichord <bret at pettichord.com>
>>> wrote:
>>>
>>>> Hi there. I was going through some old email and found this note from
>>>> Angrez from a year ago that I never responded to. This email came right
>>>> around the time that I was terminated and had to find a new job and I
>>>> neglected to responded then. My apologies.
>>>>
>>>> Since this email was written, there has been a lot of refactoring of the
>>>> Watir::Container class. In particular, locator methods have been refactored
>>>> into new strategy classes. We have also broken out most of the Watir classes
>>>> into separate files.
>>>>
>>>> There is certainly more refactoring that could be done to the Watir::IE
>>>> code base, but I am worried that it is only becoming more and more divergent
>>>> from the FireWatir code.
>>>>
>>>> What do you say Angrez? What about Amit and the rest of the FireWatir
>>>> team?
>>>>
>>>> Bret
>>>>
>>>>
>>>> On Thu, Jan 18, 2007 at 3:54 AM, Angrez Singh <angrez at gmail.com> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I just finished releasing FireWatir 1.0.1. I like the idea of merging
>>>>> or reuniting the project, but need to discuss it here with the FireWatir
>>>>> team. Also, its not as mature as Watir and it has its own limitations. I
>>>>> have the refactored code for the Watir code base 1.4.1. But I have
>>>>> made a lot of changes to that to be able to work with Firefox. Just wanted
>>>>> to evaluate the effort it requires to merge the code.
>>>>>
>>>>> Anyways, I am with the idea. Lets first refactor the WATIR::IE code and
>>>>> then we can move forward.
>>>>>
>>>>> Here's what I think:
>>>>> 1. Container module can be a separate module as it has nothing to do
>>>>> with IE, or Firefox, or Safari.
>>>>>
>>>>
>>>> 2. We can move out the classes for HTML elements to some file, as these
>>>>> classes are also browser independent.
>>>>>
>>>>> I think this can be the starting point.
>>>>>
>>>>> What do you say?
>>>>>
>>>>> - Angrez
>>>>>
>>>>>
>>>>> On 1/18/07, Bret Pettichord <bret at pettichord.com > wrote:
>>>>>>
>>>>>> I think the next step is to start refactoring the existing Watir::IE
>>>>>> code base to separate the IE and Windows specific code.
>>>>>>
>>>>>> Then Bob and I can start implementing the Watir::Selenium
>>>>>> (MineralWatir) code in the same code base.
>>>>>>
>>>>>> Then we can look into pulling in the SafariWatir and FireWatir
>>>>>> codebases. Assuming that Angrez likes this idea. (He's been busy finising
>>>>>> the FireWatir 1.0 release -- good for him.)
>>>>>>
>>>>>> But like Bob said, I need to focus on wrapping up Watir::IE 1.5 first.
>>>>>> I don't think we're ready yet for a Watir 2.0 conference call.
>>>>>>
>>>>>> Bret
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Bret Pettichord
>>>> CTO, WatirCraft LLC
>>>> Lead Developer, Watir, http://wtr.rubyforge.org
>>>> Blog (Essays), http://www.io.com/~wazmo/blog<http://www.io.com/%7Ewazmo/blog>
>>>> MiniBlog (Links), http://feeds.feedburner.com/bretshotlist
>>>
>>>
>>>
>>
>>
>> --
>> Bret Pettichord
>> CTO, WatirCraft LLC
>> Lead Developer, Watir, http://wtr.rubyforge.org
>> Blog (Essays), http://www.io.com/~wazmo/blog<http://www.io.com/%7Ewazmo/blog>
>> MiniBlog (Links), http://feeds.feedburner.com/bretshotlist
>>
>
>


-- 
Bret Pettichord
CTO, WatirCraft LLC
Lead Developer, Watir, http://wtr.rubyforge.org
Blog (Essays), http://www.io.com/~wazmo/blog
MiniBlog (Links), http://feeds.feedburner.com/bretshotlist
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/wtr-development/attachments/20080508/4b4644f7/attachment-0003.html>


More information about the Wtr-development mailing list