[Wtr-development] FireWatir Patch Files in SVN

[Angrez Singh]

Hi Bret,

I can see these patches are applied to the respective files. I think we are
not looking at the same source code. I am looking at revision 137, the
patches are there.

- Angrez

On Sat, Jun 14, 2008 at 1:58 AM, Bret Pettichord <bret at pettichord.com>
wrote:

> Angrez,
>
> After you said that the patch files checked into FireWatir-GoogleCode SVN
> had already been applied, I said that i would delete them.
>
> But before i did this, i double checked them and found that two of the five
> patch files did not look like they had actually been applied. I did this by
> inspecting the patch files and then manually checking the source to see if
> their changes were there.
>
> These are the files that did not appear to have been applied:
>
>   escaping_fix.patch
>   support-button.patch.txt
>
> These looked like they had been applied and are thus redundant:
>
>   dom_events.patch
>   patch
>   use_profile.patch
>
> I'm not sure how to proceed. I'm happy to apply the unapplied patches. Was
> there a reason they weren't applied in the first place? I haven't really
> looked into the reasons or implications of these changes, although I am
> happy to do so. Any suggestions?
>
> Bret
>
> --
> Bret Pettichord
> CTO, WatirCraft LLC
> Lead Developer, Watir, http://wtr.rubyforge.org
> Blog (Essays), http://www.io.com/~wazmo/blog<http://www.io.com/%7Ewazmo/blog>
> MiniBlog (Links), http://feeds.feedburner.com/bretshotlist
> _______________________________________________
> Wtr-development mailing list
> Wtr-development at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wtr-development
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/wtr-development/attachments/20080616/8e47cdee/attachment-0002.html>