[Win32utils-devel] windows-pr and 1.9.x test failures

[Daniel Berger]

Hi all,

I'm trying to get windows-pr compliant with Ruby 1.9.x. I've fixed a few
issues that Kendall brought up, but I'm still seeing 4 test failures in
tc_unicode.rb:

c:\Users\djberge\Repositories\windows-pr>c:\ruby19\bin\rake test:unicode
(in c:/Users/djberge/Repositories/windows-pr)
c:/ruby19/bin/ruby -w -Ic:/Users/djberge/Repositories/windows-pr/lib
"c:/ruby19/lib/ruby/1.9.1/rake/rake_test_loader.rb"
 "test/tc_unicode.rb"
Warning:c:/ruby19/lib/ruby/1.9.1/tmpdir.rb:14: Win32API is deprecated after
Ruby 1.9.1; use dl directly instead
Loaded suite c:/ruby19/lib/ruby/1.9.1/rake/rake_test_loader
Started
.E.E.E.E

  1) Error:
test_multi_to_wide(TC_Windows_Unicode):
ArgumentError: invalid byte sequence in UTF-8
    c:/ruby19/lib/ruby/1.9.1/pp.rb:287:in `pretty_print'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:154:in `block in pp'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:198:in `block (2 levels) in
group'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:225:in `nest'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:198:in `block in group'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:210:in `group_sub'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:197:in `group'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:154:in `pp'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:77:in `block in pp'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:121:in `guard_inspect_key'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:77:in `pp'
    test/tc_unicode.rb:49:in `test_multi_to_wide'

  2) Error:
test_multi_to_wide_with_encoding(TC_Windows_Unicode):
ArgumentError: invalid byte sequence in UTF-8
    c:/ruby19/lib/ruby/1.9.1/pp.rb:287:in `pretty_print'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:154:in `block in pp'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:198:in `block (2 levels) in
group'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:225:in `nest'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:198:in `block in group'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:210:in `group_sub'
    c:/ruby19/lib/ruby/1.9.1/prettyprint.rb:197:in `group'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:154:in `pp'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:77:in `block in pp'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:121:in `guard_inspect_key'
    c:/ruby19/lib/ruby/1.9.1/pp.rb:77:in `pp'
    test/tc_unicode.rb:54:in `test_multi_to_wide_with_encoding'

  3) Error:
test_wide_to_multi(TC_Windows_Unicode):
ArgumentError: invalid byte sequence in US-ASCII
    c:/Users/djberge/Repositories/windows-pr/lib/windows/unicode.rb:146:in
`[]'
    c:/Users/djberge/Repositories/windows-pr/lib/windows/unicode.rb:146:in
`wide_to_multi'
    test/tc_unicode.rb:66:in `test_wide_to_multi'

  4) Error:
test_wide_to_multi_with_encoding(TC_Windows_Unicode):
ArgumentError: invalid byte sequence in US-ASCII
    c:/Users/djberge/Repositories/windows-pr/lib/windows/unicode.rb:146:in
`[]'
    c:/Users/djberge/Repositories/windows-pr/lib/windows/unicode.rb:146:in
`wide_to_multi'
    test/tc_unicode.rb:71:in `test_wide_to_multi_with_encoding'

Finished in 0.035 seconds.

8 tests, 38 assertions, 0 failures, 4 errors, 0 pendings, 0 omissions, 0
notifications
50% passed
rake aborted!
Command failed with status (1): [c:/ruby19/bin/ruby -w
-Ic:/Users/djberge/R...]

(See full trace by running task with --trace)

What's the proper fix for multi_to_wide and wide_to_multi for Ruby 1.9.x?

Regards,

Dan