[Vpim-talk] Attachment for Patch #19685

[Max Jonas Werner]

Hi Sam,

On Friday 25 April 2008 08:56:46 Sam Roberts wrote:
> On Wed, Apr 23, 2008 at 4:47 AM, Max Jonas Werner
> <vpim-talk at maxwerner.de> wrote:
> > Hi,
> >
> >  it seems I forgot to attach my patch file for the reported patch. So I've
> >  attached it here.
> >
> >  Sam, what do you say?
> 
> What is it intended to solve?
> 
> It seems it changes the meaning of DTSTART. A meeting starting at 9AM
> in toronto, daily, 5 times shouldn't turn into a meeting at 6AM daily,
> which would happen if I called start.getlocal on the west coast.
> 
> Can you explain what you are trying to do? Maybe provide some sample
> data/unit tests, something?

I've tried to explaing what the patch does in the patch description: 
http://rubyforge.org/tracker/index.php?func=detail&aid=19685&group_id=218&atid=909

The problem is that if you don't set dtstart to start.getlocal, you have a 
date in whatever time zone it is saved in in the iCalendar file. But line 271 
creates a Time object in local time from the values in dtstart (implicitly) 
disregarding the actual time zone from the original DTSTART value from the 
iCalendar file.

Max