From orava at iki.fi Sun Oct 4 12:34:52 2009 From: orava at iki.fi (Petri Wessman) Date: Sun, 04 Oct 2009 19:34:52 +0300 Subject: [typo] comment create/prefix urls buggy in typo 5.3 (with url-prefix) Message-ID: <4AC8CEAC.4010205@iki.fi> Hi, just upgraded to 5.3 (from 5.0, I think) and noticed that my comments were no longer working. A bit of digging gave me the source: it seems that the urls for the comment creation (and preview) were not including the url-prefix (in typo config). So instead of /prefix/to/my/blog/comments?article_id=xxx, I was getting just /comments?article_id=xxx -- which failed obviously, since I run multiple Typo blogs on the server and need the prefix-url functionality. For now I patched it in a quick&dirty way in articles.rb (hardcoded some paths :), but that of course is no good long-term solution ;). Otherwise looks nice. My wife had some problems with the Atom feeds acting in a funky way, but that seems to have gone away now after some typo cache cleaning and a few Passenger restarts. -Petri From orava at iki.fi Mon Oct 5 04:45:52 2009 From: orava at iki.fi (Petri Wessman) Date: Mon, 05 Oct 2009 11:45:52 +0300 Subject: [typo] another tiny typo 5.3 bug Message-ID: <4AC9B240.1040703@iki.fi> While I'm at it: just noticed that even though I have the article filter set to be "Markdown with Smartypants" in the settings, when I go to write a new post the article filter is always set to "None" -- I have to manually change it every time. No huge deal, but thought I'd report it anyway. -Petri From pedzsan at gmail.com Mon Oct 5 10:22:38 2009 From: pedzsan at gmail.com (Perry Smith) Date: Mon, 5 Oct 2009 09:22:38 -0500 Subject: [typo] Ruby 1.9 questions Message-ID: Hi, I forked a copy of typo last night and dove in trying to make it work with Ruby 1.9 and I have a few questions that I probably should know the answers to but I don't... sorry. First, the code in vendor/plugins... are they plugins or are they part of typo? I don't know much how git works with submodules. I've heard the term but that is about it. Many of the changes are hitting the plugins. Second, am I the first explore of these here Typo, Ruby 1.9 netherlands? Anyone wanna combine efforts? Thanks, Perry Ease Software, Inc. ( http://www.easesoftware.com ) Low cost SATA Disk Systems for IBMs p5, pSeries, and RS/6000 AIX systems From cyril.mougel at gmail.com Mon Oct 5 10:30:00 2009 From: cyril.mougel at gmail.com (Cyril Mougel) Date: Mon, 05 Oct 2009 16:30:00 +0200 Subject: [typo] Ruby 1.9 questions In-Reply-To: References: Message-ID: <4ACA02E8.9080808@gmail.com> Perry Smith a ?crit : > Hi, > > I forked a copy of typo last night and dove in trying to make it work > with Ruby 1.9 and I have a few questions that I probably should know > the answers to but I don't... sorry. > > First, the code in vendor/plugins... are they plugins or are they part > of typo? I don't know much how git works with submodules. I've heard > the term but that is about it. Many of the changes are hitting the > plugins. We don't have some submodule now. All plugins are come from other project > > Second, am I the first explore of these here Typo, Ruby 1.9 > netherlands? Anyone wanna combine efforts? Rails 2.3.4 is not fullfuly ruby 1.9 compatible. So I think you can have some issue from Rails :( -- Cyril Mougel http://blog.shingara.fr/ From emiddleton at bebear.net Mon Oct 5 10:42:44 2009 From: emiddleton at bebear.net (Edward Middleton) Date: Mon, 05 Oct 2009 23:42:44 +0900 Subject: [typo] Ruby 1.9 questions In-Reply-To: References: Message-ID: <4ACA05E4.6070708@bebear.net> Perry Smith wrote: > Second, am I the first explore of these here Typo, Ruby 1.9 > netherlands? Anyone wanna combine efforts? I have pretty much finished porting to 1.9.1 but to get things working I needed to patch soap4r[1] actionwebservice[2] the mysql-ruby[3] driver, and actionpack to get things working. It also seems to be using about 70M as appose to 50M on 1.8. A lot of things aren't handling 1.9 string encodings properly and most of the proposed patches are nasty hack that just override the results rather then fixing the cause of the problem. Edward 1. http://github.com/emiddleton/soap4r 2. http://github.com/emiddleton/actionwebservice 3. http://github.com/emiddleton/mysql-ruby --- ./actionpack-2.3.4.orig/lib/action_view/template_handlers/erb.rb 2009-09-04 23:09:20.043938934 +0900 +++ ./actionpack-2.3.4/lib/action_view/template_handlers/erb.rb 2009-10-05 00:28:13.000000000 +0900 @@ -15,8 +15,24 @@ # Ruby 1.9 prepends an encoding to the source. However this is # useless because you can only set an encoding on the first line - RUBY_VERSION >= '1.9' ? src.sub(/\A#coding:.*\n/, '') : src + if RUBY_VERSION >= '1.9' + enc = detect_magic_comment(template.source) || Encoding.find('UTF-8') + src.force_encoding(enc).sub(/\A#coding:.*\n/, '') + else + src + end end + private + def detect_magic_comment(s) + if /\A<%#(.*)%>/ =~ s or (@percent and /\A%#(.*)/ =~ s) + comment = $1 + comment = $1 if comment[/-\*-\s*(.*?)\s*-*-$/] + if %r"coding\s*[=:]\s*([[:alnum:]\-_]+)" =~ comment + enc = $1.sub(/-(?:mac|dos|unix)/i, '') + enc = Encoding.find(enc) + end + end + end end end end From pedzsan at gmail.com Mon Oct 5 10:52:07 2009 From: pedzsan at gmail.com (Perry Smith) Date: Mon, 5 Oct 2009 09:52:07 -0500 Subject: [typo] Ruby 1.9 questions In-Reply-To: <4ACA05E4.6070708@bebear.net> References: <4ACA05E4.6070708@bebear.net> Message-ID: <0EA15826-CD86-4F5A-9CBE-E71083574314@gmail.com> On Oct 5, 2009, at 9:42 AM, Edward Middleton wrote: > Perry Smith wrote: >> Second, am I the first explore of these here Typo, Ruby 1.9 >> netherlands? Anyone wanna combine efforts? > > I have pretty much finished porting to 1.9.1 but Cool... your typo repository looks a bit stale right now. Do you plan to push your changes up soon? From emiddleton at bebear.net Mon Oct 5 11:04:52 2009 From: emiddleton at bebear.net (Edward Middleton) Date: Tue, 06 Oct 2009 00:04:52 +0900 Subject: [typo] Ruby 1.9 questions In-Reply-To: <0EA15826-CD86-4F5A-9CBE-E71083574314@gmail.com> References: <4ACA05E4.6070708@bebear.net> <0EA15826-CD86-4F5A-9CBE-E71083574314@gmail.com> Message-ID: <4ACA0B14.3050002@bebear.net> Perry Smith wrote: > Edward Middleton wrote: >> Perry Smith wrote: >>> Second, am I the first explore of these here Typo, Ruby 1.9 >>> netherlands? Anyone wanna combine efforts? >> >> I have pretty much finished porting to 1.9.1 but > > Cool... your typo repository looks a bit stale right now. Do you plan > to push your changes up soon? Will do when I get a chance, though I am heading to bed now because its 12:00am here ;) Edward From orava at iki.fi Thu Oct 8 05:24:21 2009 From: orava at iki.fi (Petri Wessman) Date: Thu, 08 Oct 2009 12:24:21 +0300 Subject: [typo] comment create/prefix urls buggy in typo 5.3 (with url-prefix) In-Reply-To: <4ACDAA96.2000809@matijs.net> References: <4AC8CEAC.4010205@iki.fi> <4ACDAA96.2000809@matijs.net> Message-ID: <4ACDAFC5.7080600@iki.fi> Matijs van Zuijlen wrote: > Petri Wessman wrote: >> Hi, just upgraded to 5.3 (from 5.0, I think) and noticed that my >> comments were no longer working. A bit of digging gave me the source: it >> seems that the urls for the comment creation (and preview) were not >> including the url-prefix (in typo config). >> >> So instead of /prefix/to/my/blog/comments?article_id=xxx, I was getting >> just /comments?article_id=xxx -- which failed obviously, since I run >> multiple Typo blogs on the server and need the prefix-url functionality. > > Are you by any chance using mongrel? No, I'm using Phusion Passenger (http://www.modrails.com) with Apache, it's pretty awesome. It's not like it cannot see the url-prefix conf setting in typo -- everything else except the comment URLs obeys that setting just fine. -Petri From orava at iki.fi Thu Oct 8 05:39:46 2009 From: orava at iki.fi (Petri Wessman) Date: Thu, 08 Oct 2009 12:39:46 +0300 Subject: [typo] comment create/prefix urls buggy in typo 5.3 (with url-prefix) In-Reply-To: <4ACDB00C.7080306@matijs.net> References: <4AC8CEAC.4010205@iki.fi> <4ACDAA96.2000809@matijs.net> <4ACDAFC5.7080600@iki.fi> <4ACDB00C.7080306@matijs.net> Message-ID: <4ACDB362.8070002@iki.fi> Matijs van Zuijlen wrote: > Petri Wessman wrote: >> It's not like it cannot see the url-prefix conf >> setting in typo -- everything else except the comment URLs obeys that >> setting just fine. > > I'll have a look at it: I have typo deployed in a sub-URL myself, so this > problem should be affecting me as well. Thanks. Looking at the theme (Scribbish), it seems that those URLs are generated by @article.comment_url and @article.preview_comment_url (in _comment_form.html.erb), which seem to be generating the URLs without the prefix. I hacked those in article.rb as a quick fix, but didn't know enough about Typo's internals to do it right. I also tried switching to some of the other themes, but all of them seemed to have the same problem. -Petri From orava at iki.fi Fri Oct 9 03:18:07 2009 From: orava at iki.fi (Petri Wessman) Date: Fri, 09 Oct 2009 10:18:07 +0300 Subject: [typo] comment create/prefix urls buggy in typo 5.3 (with url-prefix) In-Reply-To: <4ACDFC86.4040601@matijs.net> References: <4AC8CEAC.4010205@iki.fi> <4ACDAA96.2000809@matijs.net> <4ACDAFC5.7080600@iki.fi> <4ACDB00C.7080306@matijs.net> <4ACDB362.8070002@iki.fi> <4ACDFC86.4040601@matijs.net> Message-ID: <4ACEE3AF.1070209@iki.fi> Matijs van Zuijlen wrote: > This apparently is a known bug (although I didn't know :-) ): > > https://fdv.lighthouseapp.com/projects/11171/tickets/99-articlecomment_url-and-articlepreview_comment_url-dont-work-with-relative-url-roots Thanks for the pointers to the ticketing system, wasn't aware of that :). Ok, now I know where to check for bug reports and to possibly make some tickets of my own. -Petri From frederic at de-villamil.com Mon Oct 12 03:31:58 2009 From: frederic at de-villamil.com (=?iso-8859-1?Q?de_Villamil_Fr=E9d=E9ric?=) Date: Mon, 12 Oct 2009 09:31:58 +0200 Subject: [typo] another tiny typo 5.3 bug In-Reply-To: <4AC9B240.1040703@iki.fi> References: <4AC9B240.1040703@iki.fi> Message-ID: <18CDE1F1-E3FE-4FF9-8733-0B10071E67B4@de-villamil.com> Le 5 oct. 2009 ? 10:45, Petri Wessman a ?crit : > While I'm at it: just noticed that even though I have the article > filter > set to be "Markdown with Smartypants" in the settings, when I go to > write a new post the article filter is always set to "None" -- I > have to > manually change it every time. No huge deal, but thought I'd report it > anyway. > > -Petri > Hi Petri, Thank you for reporting this, this bug was already opened on our bug tracker at https://fdv.lighthouseapp.com/projects/11171/tickets/90-default-text-filter-ignored It was caused by the facts that the general setting was overriden by user's settings. General settings were only set up for new users, which was kinda stupid. It was fixed during the week-end. You don't have general settings for post text filters anymore, this is setup on a per users basis. Regards Fr?d?ric -- Fr?d?ric de Villamil "What's mine is mine. What's yours is still unsetteled" ? Go player proverb frederic at de-villamil.com tel: +33 (0)6 62 19 1337 http://t37.net Typo : http://typosphere.org