From noreply at rubyforge.org  Wed Jun 17 16:05:51 2009
From: noreply at rubyforge.org (noreply at rubyforge.org)
Date: Wed, 17 Jun 2009 16:05:51 -0400 (EDT)
Subject: [test-unit-tracker] [ test-unit-Patches-26268 ] Fix for
	add_assertion when current_result is Nil
Message-ID: <20090617200551.F329B1779932@rubyforge.org>

Patches item #26268, was opened at 2009-06-17 14:05
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Angelo Lakra (alakra)
Assigned to: Nobody (None)
Summary: Fix for add_assertion when current_result is Nil

Initial Comment:
I was receiving the following error when trying to run some tests for another project:

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/testcase.rb:356:in `add_assertion': undefined method `add_assertion' for nil:NilClass (NoMethodError)
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:52:in `add_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712:in `_wrap_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:48:in `assert_block'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:86:in `assert_equal'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:88:in `equal'
	from /home/angelo/downloads/test-spec-0.10.0/test/spec_testspec.rb:571:in `block (2 levels) in <top (required)>'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `instance_eval'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `block in call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:378:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:349:in `after_all'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:582:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnermediator.rb:48:in `run_suite'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:74:in `start_mediator'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:46:in `start'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnerutilities.rb:24:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/autorunner.rb:269:in `run'
	from bin/specrb:107:in `<main>'

---------------------------------

I've attached a patch that fixes my problem for when the result returned is Nil. The file in question is "trunk/lib/test/unit/testcase.rb"

Regards,

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

From noreply at rubyforge.org  Thu Jun 18 06:44:00 2009
From: noreply at rubyforge.org (noreply at rubyforge.org)
Date: Thu, 18 Jun 2009 06:44:00 -0400 (EDT)
Subject: [test-unit-tracker] [ test-unit-Patches-26268 ] Fix for
	add_assertion when current_result is Nil
Message-ID: <20090618104400.5679D185811E@rubyforge.org>

Patches item #26268, was opened at 2009-06-18 05:05
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Angelo Lakra (alakra)
Assigned to: Nobody (None)
Summary: Fix for add_assertion when current_result is Nil

Initial Comment:
I was receiving the following error when trying to run some tests for another project:

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/testcase.rb:356:in `add_assertion': undefined method `add_assertion' for nil:NilClass (NoMethodError)
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:52:in `add_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712:in `_wrap_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:48:in `assert_block'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:86:in `assert_equal'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:88:in `equal'
	from /home/angelo/downloads/test-spec-0.10.0/test/spec_testspec.rb:571:in `block (2 levels) in <top (required)>'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `instance_eval'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `block in call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:378:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:349:in `after_all'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:582:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnermediator.rb:48:in `run_suite'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:74:in `start_mediator'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:46:in `start'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnerutilities.rb:24:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/autorunner.rb:269:in `run'
	from bin/specrb:107:in `<main>'

---------------------------------

I've attached a patch that fixes my problem for when the result returned is Nil. The file in question is "trunk/lib/test/unit/testcase.rb"

Regards,

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

>Comment By: Kouhei Sutou (kou)
Date: 2009-06-18 19:44

Message:
Could you show us a test code that reproduces this problem?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

From noreply at rubyforge.org  Fri Jun 19 02:27:29 2009
From: noreply at rubyforge.org (noreply at rubyforge.org)
Date: Fri, 19 Jun 2009 02:27:29 -0400 (EDT)
Subject: [test-unit-tracker] [ test-unit-Patches-26268 ] Fix for
	add_assertion when current_result is Nil
Message-ID: <20090619062729.E251018581DD@rubyforge.org>

Patches item #26268, was opened at 2009-06-17 14:05
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

Category: None
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Angelo Lakra (alakra)
Assigned to: Nobody (None)
Summary: Fix for add_assertion when current_result is Nil

Initial Comment:
I was receiving the following error when trying to run some tests for another project:

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/testcase.rb:356:in `add_assertion': undefined method `add_assertion' for nil:NilClass (NoMethodError)
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:52:in `add_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712:in `_wrap_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:48:in `assert_block'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:86:in `assert_equal'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:88:in `equal'
	from /home/angelo/downloads/test-spec-0.10.0/test/spec_testspec.rb:571:in `block (2 levels) in <top (required)>'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `instance_eval'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `block in call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:378:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:349:in `after_all'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:582:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnermediator.rb:48:in `run_suite'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:74:in `start_mediator'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:46:in `start'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnerutilities.rb:24:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/autorunner.rb:269:in `run'
	from bin/specrb:107:in `<main>'

---------------------------------

I've attached a patch that fixes my problem for when the result returned is Nil. The file in question is "trunk/lib/test/unit/testcase.rb"

Regards,

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

>Comment By: Angelo Lakra (alakra)
Date: 2009-06-19 00:27

Message:
Here is the steps which I took that caused me to run into
the problem: 

1. Installed Ruby 1.9.1 (Patch 129)
2. Installed Rails 2.3.2 and associated gems via rubygems
3. Installed Rack 1.0.0 via rubygems
4. Noticed some issues with Rack, so rebuilt from version
control. (http://github.com/chneukirchen/rack/tree/master)
5. When running tests for Rack, it required test-spec. So I
also had to build this from source (version 0.10 from
http://rubyforge.org/projects/test-spec/)
6. As soon as I run rake, I got the error you see in the
original post.

However, as I'm looking at the code at 

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712

I can see what looks like an expectation on the author that
the user running the tests should include a rescue statement.

Looks like I found the problem and it's not your code. =)

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

Comment By: Kouhei Sutou (kou)
Date: 2009-06-18 04:44

Message:
Could you show us a test code that reproduces this problem?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

From noreply at rubyforge.org  Sun Jun 28 04:23:18 2009
From: noreply at rubyforge.org (noreply at rubyforge.org)
Date: Sun, 28 Jun 2009 04:23:18 -0400 (EDT)
Subject: [test-unit-tracker] [ test-unit-Patches-26268 ] Fix for
	add_assertion when current_result is Nil
Message-ID: <20090628082318.2D4721598075@rubyforge.org>

Patches item #26268, was opened at 2009-06-18 05:05
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650

Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 3
Submitted By: Angelo Lakra (alakra)
Assigned to: Nobody (None)
Summary: Fix for add_assertion when current_result is Nil

Initial Comment:
I was receiving the following error when trying to run some tests for another project:

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/testcase.rb:356:in `add_assertion': undefined method `add_assertion' for nil:NilClass (NoMethodError)
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:52:in `add_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712:in `_wrap_assertion'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:48:in `assert_block'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:86:in `assert_equal'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:88:in `equal'
	from /home/angelo/downloads/test-spec-0.10.0/test/spec_testspec.rb:571:in `block (2 levels) in <top (required)>'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `instance_eval'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `block in call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:377:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:378:in `call_methods_including_parents'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:349:in `after_all'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:582:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:580:in `block in run'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `each'
	from /home/angelo/downloads/test-spec-0.10.0/lib/test/spec.rb:579:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnermediator.rb:48:in `run_suite'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:74:in `start_mediator'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/console/testrunner.rb:46:in `start'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/ui/testrunnerutilities.rb:24:in `run'
	from /usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/autorunner.rb:269:in `run'
	from bin/specrb:107:in `<main>'

---------------------------------

I've attached a patch that fixes my problem for when the result returned is Nil. The file in question is "trunk/lib/test/unit/testcase.rb"

Regards,

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

>Comment By: Kouhei Sutou (kou)
Date: 2009-06-28 17:23

Message:
Thanks for additional information.
I could reproduce it.

I've added a workaround for test-spec in trunk.


----------------------------------------------------------------------

Comment By: Angelo Lakra (alakra)
Date: 2009-06-19 15:27

Message:
Here is the steps which I took that caused me to run into
the problem: 

1. Installed Ruby 1.9.1 (Patch 129)
2. Installed Rails 2.3.2 and associated gems via rubygems
3. Installed Rack 1.0.0 via rubygems
4. Noticed some issues with Rack, so rebuilt from version
control. (http://github.com/chneukirchen/rack/tree/master)
5. When running tests for Rack, it required test-spec. So I
also had to build this from source (version 0.10 from
http://rubyforge.org/projects/test-spec/)
6. As soon as I run rake, I got the error you see in the
original post.

However, as I'm looking at the code at 

/usr/local/lib/ruby/gems/1.9.1/gems/test-unit-2.0.2/lib/test/unit/assertions.rb:712

I can see what looks like an expectation on the author that
the user running the tests should include a rescue statement.

Looks like I found the problem and it's not your code. =)

Angelo Lakra (fozze)
angelo.lakra at gmail.com

----------------------------------------------------------------------

Comment By: Kouhei Sutou (kou)
Date: 2009-06-18 19:44

Message:
Could you show us a test code that reproduces this problem?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=21858&aid=26268&group_id=5650