[sup-talk] [PATCH] Fix uninitialized @name member in person.rb.
Carl Worth
cworth at cworth.org
Fri Sep 25 16:46:31 EDT 2009
Apparently a Person can be initialized with a nil name, (presumably
from a message where there's no name given), which before this commit
resulted in the following warning:
./lib/sup/person.rb:46: warning: instance variable @name not initialized
This warning was especially unpleasant since it appeared in the current
window, causing the terminal contents to incorrectly scroll up, (as
opposed to just appearing in the log or so).
---
lib/sup/person.rb | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/sup/person.rb b/lib/sup/person.rb
index c4f40a5..cd5b1ea 100644
--- a/lib/sup/person.rb
+++ b/lib/sup/person.rb
@@ -11,6 +11,8 @@ class Person
if @name =~ /^(['"]\s*)(.*?)(\s*["'])$/
@name = $2
end
+ else
+ @name = nil
end
@email = email.gsub(/^\s+|\s+$/, "").gsub(/\s+/, " ").downcase
--
1.6.4.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20090925/26a4d1df/attachment.bin>
More information about the sup-talk
mailing list