[sup-talk] Ignore killed messages in U screen
rlane at club.cc.cmu.edu
Thu Sep 3 15:25:03 EDT 2009
Excerpts from Edward Z. Yang's message of Thu Aug 27 11:56:32 -0400 2009:
> Excerpts from Edward Z. Yang's message of Thu Aug 27 11:36:28 -0400 2009:
> > - SearchResultsMode.spawn_from_query "is:unread"
> > + SearchResultsMode.spawn_from_query "is:unread !label:killed"
> I might have one legitimate objection to this patch, which is
> that searches should ignore killed tags unless explicitly told
> not to.
By default Index#load_messages_in_thread_for does skip killed threads,
so you should already have the behavior you want without modifying the
query (unless you're using an old xapian-index version that doesn't
support killed threads). Adding a !label:killed term will actually cause
threads that are "killed" (have at least one message labeled killed) but
also have a message not labeled killed that matches the query to be
displayed, which I don't think is the behavior you're looking for.
More information about the sup-talk