[sup-talk] [PATCH] detect and set charset on text/* attachments

Helge Titlestad helgedt at tihlde.org
Tue Nov 3 14:23:28 EST 2009


Excerpts from William Morgan's message of Tue Nov 03 18:16:32 +0100 2009:
> It looks like the chardet gem is unmaintained. But someone decided to
> make their own special version called rchardet which is completely
> equivalent version but *is* maintained. 
> 
> I suggest we use rchardet instead of chardet. Would you like to change
> the patch? If not, I will get to it at some point.

Here you go!

One thing I noticed when trying it out: It will set charset 'ascii' for ascii
text, which is allowed by the RFC but "US-ASCII" is preferred. I think I prefer
to not create a special case in the code to change it to US-ASCII or remove the
charset for ascii text, but other people might disagree.
-- 
alge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Detect-charset-for-text-file-attachments.patch
Type: application/octet-stream
Size: 1919 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20091103/bcbaa6d8/attachment.obj>


More information about the sup-talk mailing list