[sup-talk] [Patch] From auto completion

William Morgan wmorgan-sup at masanjin.net
Sat May 24 23:27:36 EDT 2008


Hi Tyberius,

Thanks for the patch. You can merge multiple commits together with git
rebase -i, or you can commit --amend each time to merge current changes
into the previous commit.

I like the idea of this patch, but instead of
AccountManager#user_accounts_autocompletion, could you add a
BufferManager#ask_for_account, similar to #ask_for_contact works? Then
the whole flow will be basically the same as editing the other fields.

Also note that you don't need semicolons at the end of statements in
Ruby. :)
-- 
William <wmorgan-sup at masanjin.net>


More information about the sup-talk mailing list