[sup-talk] mime-view

[William Morgan]

Reformatted excerpts from Daniel Wagner's message of 2008-02-18:
> Recently, activating attachments has stopped working.

You know, in reexamining this code, I think there is a silly bug here,
and I think it also caused the weirdness that John Bent was experiencing
a few weeks ago.

Can you try the latest (master/next) from git, or apply the following
patch:

diff --git a/lib/sup/message-chunks.rb b/lib/sup/message-chunks.rb
index 0606395..ba8b846 100644
--- a/lib/sup/message-chunks.rb
+++ b/lib/sup/message-chunks.rb
@@ -126,7 +126,7 @@ EOS
       path = write_to_disk
       ret = HookManager.run "mime-view", :content_type => @content_type,
                                          :filename => path
-      view_default! path unless ret
+      ret || view_default!(path)
     end
 
     def write_to_disk

> system "xmessage -default okay In the hook."
> system "see #{content_type}:#{filename}"
> return true

This looks fine, though I would change the last line to just
  $?.success?

which will evaluate to true iff the see command was successful. With
the above change, everything should Just Work (tm).

-- 
William <wmorgan-sup at masanjin.net>