[sup-talk] [PATCH] Fix for imap based sources
Marcus Williams
marcus-sup at quintic.co.uk
Thu Oct 25 06:25:39 EDT 2007
Hi -
Apply this one at your peril. This patch makes the unread status
correct on sources that arent mbox - unfortunately I cant test on
Maildir so if someone wants to confirm it still works that would be
good :)
If you implement a new source, it means you now have to add a
marked_read? method to your source as well. Argument is a message id.
message.rb now calls this when source_marked_read is called.
It also fixes what I think is a bug in the imap sup source - the imap
"/Seen" flag means a message has been read from the way I interpret the
RFC, the "/Recent" flag is what you need to check for "unreadness".
This fixes my problem with imap (in that all new messages were getting
marked as read). To get just this fix all you have to do is replace Seen
for Recent in the imap.rb. The line currently looks like:
labels = { :Seen => :unread,
and it should be
labels = { :Recent => :unread,
Marcus
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: imap-diffs
Url: http://rubyforge.org/pipermail/sup-talk/attachments/20071025/f4d9e120/attachment.pl
More information about the sup-talk
mailing list