[Rubyinstaller-devel] Re: [Rubyinstaller-users] Patch for installer version 13

Jos Backus jos at catnook.com
Thu May 27 13:11:29 EDT 2004


On Thu, May 27, 2004 at 07:17:31AM -0500, Curt Hibbs wrote:
> Hmmm... Try forwarding another copy to this list.
 
I didn't keep the original e-mail (I was under the assumption that the list
would send it back to me anyway :-). Here's the guts of the mail:

<quote>
On Windows, xmlparser is being compiled in C-mode which causes cl.exe to
complain:

C:\src\installer\devel\download\xmlparser>nmake /NOLOGO
        cl -nologo -MD -Zi -O2b2xg- -G6 -I.
-IC:/src/installer/devel/lib/ruby/1.
8/i386-mswin32 -IC:/src/installer/devel/lib/ruby/1.8/i386-mswin32 -I.
-DHAVE_EXP
AT_H -DHAVE_XML_SETNOTSTANDALONEHANDLER -DHAVE_XML_SETPARAMENTITYPARSING
-DHAVE_
XML_SETDOCTYPEDECLHANDLER -DHAVE_XML_PARSERRESET
-DHAVE_XML_SETSKIPPEDENTITYHAND
LER -DHAVE_XML_GETFEATURELIST -DHAVE_XML_USEFOREIGNDTD
-DHAVE_XML_GETIDATTRIBUTE
INDEX -IC:/src/installer/devel/download/Expat-1.95.7/Source/lib -I.
-I./.. -I./.
./missing -DNEW_EXPAT -DXML_DTD -c -Tcxmlparser.c
xmlparser.c
xmlparser.c(530) : error C2143: syntax error : missing ';' before 'type'
xmlparser.c(533) : error C2065: 'content' : undeclared identifier
xmlparser.c(933) : error C2143: syntax error : missing ';' before 'type'
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.

The fix is simple:

--- xmlparser.c.orig    2004-05-26 16:35:38.000000000 -0700
+++ xmlparser.c 2004-05-26 16:33:45.000000000 -0700
@@ -526,8 +526,9 @@
                       XML_Content *model)
 {
   XMLParser* parser;
+  VALUE content;
   GET_PARSER(recv, parser);
-  VALUE content = makeContentArray(parser, model);
+  content = makeContentArray(parser, model);
   rb_yield(rb_ary_new3(4, symELEMENT_DECL,
                       TO_(rb_str_new2(name)),
                       content, recv));
@@ -929,8 +930,9 @@
                     XML_Content *model)
 {
   XMLParser* parser;
+  VALUE content;
   GET_PARSER(recv, parser);
-  VALUE content = makeContentArray(parser, model);
+  content = makeContentArray(parser, model);
   rb_funcall((VALUE)recv, id_elementDeclHandler, 2,
             TO_(rb_str_new2(name)), content);
 }

Please consider importing this fix into the next xmlparser release.
</quote>

> At least TortoiseCVS makes it more manageable. I've been using Subversion
> (through TortoiseSVN) locally and I like it a lot. I hope it starts
> replacing CVS in the open source world.

Me too. Subversion may not be perfect but it's a definitive improvement over
CVS.

-- 
Jos Backus                       _/  _/_/_/      Sunnyvale, CA
                                _/  _/   _/
                               _/  _/_/_/
                          _/  _/  _/    _/
jos at catnook.com        _/_/   _/_/_/          require 'std/disclaimer'


More information about the Rubyinstaller-devel mailing list