[Rubygems-developers] gem lock

Luis Lavena luislavena at gmail.com
Wed Sep 29 17:55:15 EDT 2010


On Wed, Sep 29, 2010 at 6:51 PM, James Tucker <jftucker at gmail.com> wrote:
>
> On 29 Sep 2010, at 18:31, Luis Lavena wrote:
>>
>> But, if you want it fixed, you can fork it and send the pull request,
>> I would love to review it and if it works, happy to merge it.
>
> I would be wary to merge in any update to this feature that doesn't fix the issues of the style I just highlighted. In fact, it should pass all of the dependency collision spec examples that you might find in the bundler resolver tests. If it doesn't, it's basically broken.
>
> As we don't have users using this feature, and it's broken, I would suggest it should be removed by the next major release unless someone has fixed it.

Point taken, I believe it was obvious but just to clarify: review will
use bundler complex dependency resolution as comparison for approval.

-- 
Luis Lavena
AREA 17
-
Perfection in design is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.
Antoine de Saint-Exupéry


More information about the Rubygems-developers mailing list