[Rubygems-developers] [ rubygems-Patches-28747 ] patch for Gem::SilentUI and yes/no defaulted methods

noreply at rubyforge.org noreply at rubyforge.org
Tue Nov 23 05:02:40 EST 2010


Patches item #28747, was opened at 2010-11-23 02:01
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=577&aid=28747&group_id=126

Category: other
Group: future
Status: Open
Resolution: None
Priority: 3
Submitted By: Erik Hollensbe (erikh)
Assigned to: Nobody (None)
Summary: patch for Gem::SilentUI and yes/no defaulted methods

Initial Comment:
Attached is a patch to have proper support for Gem::SilentUI. Currently, this class does not inherit from any of the other UI classes and has a basic method_missing wrapper. This causes things like bundler to improperly answer questions even if defaults are supplied.

Gem::StreamUI already has support for handling non-tty scenarios, so this patch makes Gem::SilentUI inherit from it with some additional initializer logic to have it call the superclass initializer with handles to /dev/null (nil on windows, but this is untested).

Additionally, as requested by Eric, there are two new methods to specify the defaults to yes/no questions, with the default answer supplied as upper-case: ask_Yes_no and ask_yes_No. These are just shims for ask_yes_no with the optional third argument.

There will be an additional patch to bundler for its complete support of this feature, I will comment here once it's filed so that if accepted, releases can be coordinated.


----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=577&aid=28747&group_id=126


More information about the Rubygems-developers mailing list