[Rubygems-developers] [ rubygems-Patches-27677 ] fixes many JRuby tests (ensure_gem_subdirectories ordering in test/gemutilities.rb)

noreply at rubyforge.org noreply at rubyforge.org
Sat Jan 9 15:11:20 EST 2010


Patches item #27677, was opened at 2010-01-09 20:11
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=577&aid=27677&group_id=126

Category: other
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Colin Jones (trptcolin)
Assigned to: Nobody (None)
Summary: fixes many JRuby tests (ensure_gem_subdirectories ordering in test/gemutilities.rb)

Initial Comment:
This patch fixes ~225 failing tests under JRuby.  MRI tests are not affected.

In test/gemutilities.rb, we have both: 
Gem.ensure_gem_subdirectories @gemhome
and 
FileUtils.mkdir_p @gemhome

but the mkdir_p previously came last, so if the directory didn't already exist, Gem.ensure_gem_subdirectories would never do its job.

I've just switched the order so that the subdirectories are properly verified regardless of whether @gemhome already existed.

Thanks,
Colin Jones
trptcolin AT gmail

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=577&aid=27677&group_id=126


More information about the Rubygems-developers mailing list