[Rubygems-developers] [ rubygems-Bugs-28399 ] rubygems should use RbConfig::CONFIG['make-prog']

noreply at rubyforge.org noreply at rubyforge.org
Fri Dec 31 20:32:28 EST 2010


Bugs item #28399, was opened at 2010-07-17 22:38
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=28399&group_id=126

Category: None
Group: None
>Status: Closed
Resolution: Accepted
Priority: 3
Submitted By: Greg Hazel (ghazel)
Assigned to: Luis Lavena (luislavena)
Summary: rubygems should use RbConfig::CONFIG['make-prog']

Initial Comment:
Similar to mkmf.rb, rubygems should use Config['make-prog'] if it is set. This allows per-ruby configuration of which "make" to use.


mkmf.rb does:

$make = with_config("make-prog", ENV["MAKE"] || "make")
make, = Shellwords.shellwords($make)
$nmake = nil
case
when $mswin
  $nmake = ?m if /nmake/i =~ make
when $bccwin
  $nmake = ?b if /Borland/i =~ `#{make} -h`
end


rubygems/ext/builder.rb does:

make_program = ENV['make']
unless make_program then
  make_program = (/mswin/ =~ RUBY_PLATFORM) ? 'nmake' : 'make'
end


I believe they should be the same, and that the mkmf.rb method is preferable.

----------------------------------------------------------------------

>Comment By: Luis Lavena (luislavena)
Date: 2010-12-31 22:32

Message:
Hello,

What mkmf with_config does is parse Ruby own configure arguments RbConfig::CONFIG['configure_args'] and extract them.

A trivial approach was added, but I'm worry that will break other stuff.

The commit is 4bb1149:

https://github.com/rubygems/rubygems/commit/4bb1149d10a95ec8c33de1ebaf4b90ce11d0cbee

Please verify that works as expected under your environment and report it back.

Closing this now, please send a comment to let us know the results.

Thank you for your report and happy new year!

----------------------------------------------------------------------

Comment By: James Tucker (raggi)
Date: 2010-07-18 09:23

Message:
+1

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=28399&group_id=126


More information about the Rubygems-developers mailing list