[Rubygems-developers] download-reporter branch for review

Eric Hodel drbrain at segment7.net
Wed Dec 29 04:51:20 EST 2010


On Dec 27, 2010, at 07:10, Luis Lavena wrote:

> Hello,
> 
> I've reimplemented the original proposal from Ryan Melt:
> 
> https://github.com/rubygems/rubygems/pull/2
> 
> Into 'download-reporter' branch:
> 
> https://github.com/rubygems/rubygems/tree/download-reporter
> 
> Basically I've created a SilentDownloadReporter and
> VerboseDownloadReporter to mimic *ProgressReporter.
> 
> I've also made it non-tty friendly, so deployment logs do not generate
> lot of noise due redirections.

Typo in lib/rubygems/remote_fetcher.rb: incomplete_respose

Please indent 'private' in class VerboseDownloadReporter in lib/rubygems/user_interaction.rb to the same level as def.

> If nobody objects, will merge it into master.
> 
> Looking forward for your comments and suggestions. Perhaps the API can
> be cleaned up.

We trust your work.  In the future, Just Do It™ ☺


More information about the Rubygems-developers mailing list