[Rubygems-developers] Contributing to Ruby Projects

Jon jon.forums at gmail.com
Thu Dec 9 12:33:22 EST 2010

> I would like some constructive appraisal. I recently offered some
> patches to RubyGems. I feel I was making my best effort to contribute
> some functionality to the code base that would be useful to
> developers. But in this process, rather then feel a part of a
> community effort, even if only a minor part, I felt rather skewered...
>   https://github.com/rubygems/rubygems/pull/14
>   (above in context https://github.com/trans/rubygems/commit/b61fd7cb577a8df6be2feb1a35983e9846d31b3c)
>   https://github.com/rubygems/rubygems/pull/12
>   https://github.com/rubygems/rubygems/pull/8
> I'm not sure why anyone would contribute to a Ruby project if it
> transpires like this. But then maybe thats the way it is? Is this
> really what one should expect?

Since you explicitly asked for some constructive appraisal, IMO your email is as out-of-place on this developer list as http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/19349 was on the ruby-core list.

After rerereading the comments, I came away with a vastly different impression than you must have.  While the comments were frank and direct, I was especially impressed with the amount of detail from Eric.

I'm guessing Ryan's comment to 14 combined with the history between between you two made the overall comments feel more aggressive than they appeared to me.  While we all have different styles, I do think Ryan gave you valuable feedback in his comment.

Rather than combining three different, yet related, issues (community contributions, feedback style and status request as to your patches) into one email, you may have been better served to focus on the status update request in your email to this developer list while trying to work any personal issues offline directly with Ryan and Eric.

Both Chad and John B's responses are some of the wisest and most constructive I've seen in a long time.



More information about the Rubygems-developers mailing list