[Rubygems-developers] RubyGems setup.rb --destdir patch

Luis Lavena luislavena at gmail.com
Thu Mar 12 09:26:02 EDT 2009


On Thu, Mar 12, 2009 at 3:51 AM, Richard Brown <rbrown at exherbo.org> wrote:
> On Mon, Mar 9, 2009 at 22:33, Luis Lavena <luislavena at gmail.com> wrote:
>>
>> Forgot to mention if those patches do not clash on Windows drive
>> letters, I'm cool with them
>>
>
> This gist contains two patches against trunk. The first patch fixes
> some option names that I think got mangled in the refactoring of
> setup.rb. The second patch makes destdir to what I think it should do,
> and to make it work on windows, I've just called
> .gsub(/^[a-zA-Z]:/,'') on paths being joined to destdir to remove a
> drive letter if present. Is this too hacky?
>
> http://gist.github.com/77950
>

Hmn, that smells pretty aggressive patch, at least in relation to Windows paths.

I'll check this later and see what are the outcome on Windows.

-- 
Luis Lavena
AREA 17
-
Perfection in design is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.
Antoine de Saint-Exupéry


More information about the Rubygems-developers mailing list