[Rubygems-developers] [ rubygems-Bugs-25493 ] Feature: Make trailing zeroes in gem version significant

noreply at rubyforge.org noreply at rubyforge.org
Wed Apr 22 18:28:55 EDT 2009


Bugs item #25493, was opened at 2009-04-16 02:15
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=25493&group_id=126

Category: #gem and #require methods
Group: v1.3.x
Status: Open
Resolution: None
Priority: 3
Submitted By: Yossef Mendelssohn (ymendel)
Assigned to: Phil Hagelberg (technomancy)
Summary: Feature: Make trailing zeroes in gem version significant

Initial Comment:
I'd like for 1.0.0 to be seen as > 1.0

Patch (diffs from git show) and flog/reek output before/after the change can be seen at http://gist.github.com/96284

You can see a few specs had to change because they assume the trailing zeroes don't matter. If this is a hard requirement, then obviously my patch cannot be accepted, at least not without some transition and deprecation warning period.

The flog and reek output is included to show that as far as overall complexity and smell goes, the code is improved by this change. Only the Gem::Version#balance utility method takes a hit as its flog score jumps from 15.4 to 25.1

----------------------------------------------------------------------

>Comment By: Yossef Mendelssohn (ymendel)
Date: 2009-04-22 17:28

Message:
To be perfectly honest, I mostly want this change so I can
release updates to truthy with version numbers converging on
an important constant. Other people and programs have used
pi and e, but I'm shooting for 1.0 (or 1.0.0.0.0.0.0.0.0.0).

Given how many of the tests specifically point out (or
pointed out prior to this patch) that trailing zeroes are
not significant, maybe it's not that great an idea after
all. I could have almost as much fun using silly 1.0.1
prereleases.

Really, I was convinced that the flog output would be enough
to get this accepted without any deliberation.

----------------------------------------------------------------------

Comment By: Eric Hodel (drbrain)
Date: 2009-04-16 15:43

Message:
Echoing Austin's comments from the rubygems-developers list, what's the benefit to the users of RubyGems with this change?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=25493&group_id=126


More information about the Rubygems-developers mailing list