[Rubygems-developers] [ rubygems-Bugs-25493 ] Feature: Make trailing zeroes in gem version significant

noreply at rubyforge.org noreply at rubyforge.org
Thu Apr 16 16:43:52 EDT 2009


Bugs item #25493, was opened at 2009-04-16 00:15
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=25493&group_id=126

Category: #gem and #require methods
Group: v1.3.x
Status: Open
Resolution: None
Priority: 3
Submitted By: Yossef Mendelssohn (ymendel)
Assigned to: Phil Hagelberg (technomancy)
Summary: Feature: Make trailing zeroes in gem version significant

Initial Comment:
I'd like for 1.0.0 to be seen as > 1.0

Patch (diffs from git show) and flog/reek output before/after the change can be seen at http://gist.github.com/96284

You can see a few specs had to change because they assume the trailing zeroes don't matter. If this is a hard requirement, then obviously my patch cannot be accepted, at least not without some transition and deprecation warning period.

The flog and reek output is included to show that as far as overall complexity and smell goes, the code is improved by this change. Only the Gem::Version#balance utility method takes a hit as its flog score jumps from 15.4 to 25.1

----------------------------------------------------------------------

>Comment By: Eric Hodel (drbrain)
Date: 2009-04-16 13:43

Message:
Echoing Austin's comments from the rubygems-developers list, what's the benefit to the users of RubyGems with this change?

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=575&aid=25493&group_id=126


More information about the Rubygems-developers mailing list