[Rubygems-developers] Please test for a 1.3.1

Eric Hodel drbrain at segment7.net
Wed Oct 22 01:39:01 EDT 2008


On Oct 21, 2008, at 13:36 PM, Berger, Daniel wrote:
>>> Are you making minitest a requirement even for 1.8.x? That's how it
>>> seems to be now:
>>
>> Yes.
>
> How will that work in practice if I do "gem update --system"? Will  
> it go
> out and automatically grab minitest for me? Or is it pre-bundled
> somehow? Just curious.

It is only a requirement for people running RubyGems' tests, which  
don't run when updating RubyGems (it would be nice to run them, but  
then people would freak out like the world was on fire when they  
fail).  On installation of a new RubyGems nothing will happen that  
didn't happen before.

>>> C:\Documents and Settings\djberge\workspace\rubygems>rake test (in
>>> C:/Documents and Settings/djberge/workspace/rubygems)
>>> C:0:Warning: Gem::manage_gems is deprecated and will be
>> removed on or
>>> after March 2009.
>>>
>>> The Warning line (and format) is strange, too.
>>
>> Gem::location_of_caller is insufficient for windows paths :/
>
> How does this look?
>
> C:\>diff -u rubygems.orig rubygems.rb
> --- rubygems.orig       Mon Sep 29 08:01:06 2008
> +++ rubygems.rb Tue Oct 21 14:29:27 2008
> @@ -479,8 +479,9 @@
>   # The file name and line number of the caller of the caller of this
> method.
>
>   def self.location_of_caller
> -    file, lineno = caller[1].split(':')
> -    lineno = lineno.to_i
> +    caller[1] =~ /(.*?)\:(\d+)$/i
> +    file = $1
> +    lineno = $2.to_i
>     [file, lineno]
>   end

Looks good, I will use it.


More information about the Rubygems-developers mailing list