[Rubygems-developers] Please test for a 1.3.1

Luis Lavena luislavena at gmail.com
Tue Oct 21 16:57:53 EDT 2008


On Tue, Oct 21, 2008 at 5:36 PM, Berger, Daniel <Daniel.Berger at qwest.com> wrote:
> Hi,
>
> <snip>
>
>> >> Silencing the PATH warning for unpack Fixes for
>> Gem.inflate, deflate,
>> >> etc.
>> >> Switched to MiniTest for 1.9 compatibility Gem.dir reads
>> >
>> > Are you making minitest a requirement even for 1.8.x? That's how it
>> > seems to be now:
>>
>> Yes.
>
> How will that work in practice if I do "gem update --system"? Will it go
> out and automatically grab minitest for me? Or is it pre-bundled
> somehow? Just curious.
>

Is a dev dependency, so it only affects you if you checkout rubygems
source and perform "rake test"

>> > C:\Documents and Settings\djberge\workspace\rubygems>rake test (in
>> > C:/Documents and Settings/djberge/workspace/rubygems)
>> > C:0:Warning: Gem::manage_gems is deprecated and will be
>> removed on or
>> > after March 2009.
>> >
>> > The Warning line (and format) is strange, too.
>>
>> Gem::location_of_caller is insufficient for windows paths :/
>
> How does this look?
>
> C:\>diff -u rubygems.orig rubygems.rb
> --- rubygems.orig       Mon Sep 29 08:01:06 2008
> +++ rubygems.rb Tue Oct 21 14:29:27 2008
> @@ -479,8 +479,9 @@
>   # The file name and line number of the caller of the caller of this
> method.
>
>   def self.location_of_caller
> -    file, lineno = caller[1].split(':')
> -    lineno = lineno.to_i
> +    caller[1] =~ /(.*?)\:(\d+)$/i
> +    file = $1
> +    lineno = $2.to_i
>     [file, lineno]
>   end
>
> Regards,
>

Bummer, you beat me, hate bad internet wireless connections...

I did something similar but one liner for Thor:

http://github.com/luislavena/thor/commit/e66b67a684200ccd915d5808cb415ea6e5fe08c6

And of course, for the ones didn't noticed it, I suck at regexp :-P
-- 
Luis Lavena
AREA 17
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams


More information about the Rubygems-developers mailing list