[Rubygems-developers] RubyGems 1.2.0 release in less than one week

Luis Lavena luislavena at gmail.com
Thu Jun 19 05:00:27 EDT 2008


On Thu, Jun 19, 2008 at 1:13 AM, Eric Hodel <drbrain at segment7.net> wrote:
> On Jun 18, 2008, at 01:08 AM, Luis Lavena wrote:
>>
>> ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mswin32]
>> 661 tests, 1938 assertions, 1 failures, 2 errors
>> http://pastie.org/private/ynl4opd4xgjcidkzgxna
>>
>> ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mingw32]
>> 661 tests, 1944 assertions, 1 failures, 2 errors
>> http://pastie.org/private/lnmlvoney68rmy5etnnodq
>
> 1) Failure: test_install_dual_repository(TestGemDependencyInstaller)
> [./test/test_gem_dependency_installer.rb:383]:
> <["b-1"]> expected but was
> <["a-1", "b-1"]>.
>
> I'm not sure I fixed this.  I committed this change:
>
> Index: test/test_gem_dependency_installer.rb
> ===================================================================
> --- test/test_gem_dependency_installer.rb       (revision 1781)
> +++ test/test_gem_dependency_installer.rb       (working copy)
> @@ -372,7 +372,7 @@ class TestGemDependencyInstaller < RubyG
>     end
>
>     ENV['GEM_HOME'] = @gemhome
> -    ENV['GEM_PATH'] = [@gemhome, gemhome2].join ':'
> +    ENV['GEM_PATH'] = [@gemhome, gemhome2].join File::PATH_SEPARATOR
>     Gem.clear_paths
>
>     Dir.chdir @tempdir do
>
>
> but it may not be correct.
>

Actually, is correct, if you're joining two paths must always use the
platform implementation. If you're joining a directory structure to a
file, you must always use File.join or join with File::SEPARATOR, just
to be sure that will work across platforms.

>> Just a reminder: directory or filenames in Windows cannot contain ':'
>> as part of it (since double colons are used as drive letter
>> separator). So the port in the spec cache is getting in our way. Can
>> we change (gsub) using . (dot) instead? will impose other complexity?
>
> I chose %, is that ok?  It seems to be a valid filesystem character for all
> platforms.

Yes, it's great!

%, used from the command line (the console) must be quoted since can
be interpreted as batch command, but called from programs is ok.

ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mswin32]
664 tests, 1948 assertions, 0 failures, 0 errors

ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mingw32]
664 tests, 1954 assertions, 0 failures, 0 errors

I think we only need GemInstaller regression tests to get pass and we
are good to go. I'll check during weekend the functionality on
Windows.

Looks like we are ok now :-)
-- 
Luis Lavena
AREA 17
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams


More information about the Rubygems-developers mailing list