[Rubygems-developers] RubyGems 1.2.0 release in less than one week

[Eric Hodel]

On Jun 18, 2008, at 01:08 AM, Luis Lavena wrote:
> ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mswin32]
> 661 tests, 1938 assertions, 1 failures, 2 errors
> http://pastie.org/private/ynl4opd4xgjcidkzgxna
>
> ruby 1.8.6 (2008-03-03 patchlevel 114) [i386-mingw32]
> 661 tests, 1944 assertions, 1 failures, 2 errors
> http://pastie.org/private/lnmlvoney68rmy5etnnodq

1) Failure: test_install_dual_repository(TestGemDependencyInstaller)  
[./test/test_gem_dependency_installer.rb:383]:
<["b-1"]> expected but was
<["a-1", "b-1"]>.

I'm not sure I fixed this.  I committed this change:

Index: test/test_gem_dependency_installer.rb
===================================================================
--- test/test_gem_dependency_installer.rb       (revision 1781)
+++ test/test_gem_dependency_installer.rb       (working copy)
@@ -372,7 +372,7 @@ class TestGemDependencyInstaller < RubyG
      end

      ENV['GEM_HOME'] = @gemhome
-    ENV['GEM_PATH'] = [@gemhome, gemhome2].join ':'
+    ENV['GEM_PATH'] = [@gemhome, gemhome2].join File::PATH_SEPARATOR
      Gem.clear_paths

      Dir.chdir @tempdir do


but it may not be correct.

> Just a reminder: directory or filenames in Windows cannot contain ':'
> as part of it (since double colons are used as drive letter
> separator). So the port in the spec cache is getting in our way. Can
> we change (gsub) using . (dot) instead? will impose other complexity?

I chose %, is that ok?  It seems to be a valid filesystem character  
for all platforms.