[Rubygems-developers] [PATCH] Two changes to the gem list command
Bjørn Arild Mæland
bjorn.maeland at gmail.com
Sat Aug 2 17:08:51 EDT 2008
Thanks for your feedback. You're right, the diffs are not correctly
formatted for SVN, sorry about that. I've made the output from `svn diff`
available here: http://pastie.org/246285 (includes both patches)
About the return code, I'm not entirely sure on 1 either. I saw 2 and 4 were
used elsewere in the source - I'll leave that decision to someone else. The
important thing is that it doesn't return 0, though.
2008/8/2 Chad Woolley <thewoolleyman at gmail.com>
> On Fri, Aug 1, 2008 at 5:39 PM, Chad Woolley <thewoolleyman at gmail.com>
> > I haven't looked closely, but I think these are good patches.
> I tried these, and they don't appear to break my API interaction or
> the rubygems test suite. They gave some minor problems applying, I
> don't know if this is the way github makes diffs or what.
> Anway, they seem good to apply, if Eric thinks so.
> -- Chad
> Rubygems-developers mailing list
> Rubygems-developers at rubyforge.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Rubygems-developers