[Rubygems-developers] extconf.rb fix

Ryan Davis ryand-ruby at zenspider.com
Wed Jul 18 03:08:11 EDT 2007


Review Please...

On Jul 10, 2007, at 20:15 , Ryan Davis wrote:

> I think we've got a bug for extension when there is a subdir in the
> path (eg "ext/extconf.rb"). I'm pretty sure the following patch fixes
> this situation, but Aaron has grown too cranky to apply and test it.
>
> Index: installer.rb
> ===================================================================
> --- installer.rb	(revision 1259)
> +++ installer.rb	(working copy)
> @@ -642,12 +642,15 @@
>     class ExtExtConfBuilder < ExtBuilder
>       def self.build(extension, directory, dest_path, results)
> -      cmd = "#{Gem.ruby} #{File.basename extension}"
> -      cmd << " #{ARGV.join " "}" unless ARGV.empty?
> +      dir, ext = File.split extension
> +      Dir.chdir dir do
> +        cmd = "#{Gem.ruby} #{ext}"
> +        cmd << " #{ARGV.join " "}" unless ARGV.empty?
> -      run cmd, results
> +        run cmd, results
> -      make dest_path, results
> +        make dest_path, results
> +      end
>         results
>       end
>
> _______________________________________________
> Rubygems-developers mailing list
> Rubygems-developers at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rubygems-developers



More information about the Rubygems-developers mailing list