[Rubygems-developers] Proxy auth fix (Was: ri generation patch for Rubygems)

Eric Hodel drbrain at segment7.net
Sun Feb 26 07:09:46 EST 2006


On Feb 26, 2006, at 1:51 AM, Anatol Pomozov wrote:

> On 2/26/06, Eric Hodel <drbrain at segment7.net > wrote:
>
>> In the future, please use CVS diff or include proper diff headers.
>> Also, unified diffs are easier to read and verify.
>
> I could provide cvs diff's. But RubyGems sources have a lot of TABs  
> so after editing I have zillion of changes TAB->4 spaces (I have  
> editor option to force removing TABS).
> So to make diff cleaner I decide to use gnu diff with ignore  
> whitespace option.

cvs diff supports the ignore-whitespace option, I believe it just  
uses your system's diff:

$ cvs diff post-install.rb
Index: post-install.rb
===================================================================
RCS file: /var/cvs/rubygems/rubygems/post-install.rb,v
retrieving revision 1.6
diff -u -r1.6 post-install.rb
--- post-install.rb     9 Jul 2005 23:18:32 -0000       1.6
+++ post-install.rb     26 Feb 2006 11:53:16 -0000
@@ -59,7 +59,7 @@
end
def install_sources
-  $: << "lib"
+$: << "lib"
    require 'rubygems'
    Gem::manage_gems
    Dir.chdir("pkgs/sources") do
$ cvs diff -w
Index: post-install.rb
===================================================================
RCS file: /var/cvs/rubygems/rubygems/post-install.rb,v
retrieving revision 1.6
diff -u -w -r1.6 post-install.rb
$

> Could you please format sources to make others developers life easier.

I'm not about to check in a bunch of whitespace changes.  I've seen  
it raise far more controversy than I'm willing to deal with,  
especially with a commit bit fresh out of the wrapper.

FWIW, I always expand tabs in ruby sources I edit.

-- 
Eric Hodel - drbrain at segment7.net - http://blog.segment7.net
This implementation is HODEL-HASH-9600 compliant

http://trackmap.robotcoop.com




More information about the Rubygems-developers mailing list