[Rubygems-developers] [rubygems] Build still broken (#1149)

Anatol Pomozov anatol.pomozov at gmail.com
Thu Dec 21 06:05:19 EST 2006


Hi, Eric.

First of all thanks for your RubyGems improvements. You and other developers
are doing great job.

On 12/20/06, Cerberus <anatol.pomozov at gmail.com> wrote:
>
> ------------------------------------------------------------------------
> r1149 | drbrain | 2006-12-20 12:57:32 +0300 | 3 lines
> Changed paths:
>    M /trunk/test/test_gem_ext_configure_builder.rb
>    M /trunk/test/test_gem_ext_ext_conf_builder.rb
>
> Remove test_class_build_extconf_bad, cross-compiler behavior is not
> constant.
> PLATFORM not VERSION, you idiot.
>
> ------------------------------------------------------------------------
>
> (in C:/Documents and Settings/anatol/.cerberus/work/rubygems/sources)
> Loaded suite c:/PROGRA~1/ruby/lib/ruby/gems/1.8/gems/rake-0.7.1
> /lib/rake/rake_test_loader
> Started
> ..............................................................................................F.......................................................................................F..............................................................................................
>
> Finished in 56.359 seconds.
>
>   1) Failure:
> test_class_build_fail(TestGemExtRakeBuilder)
> [./test/test_gem_ext_rake_builder.rb:46]:
> <Gem::InstallError> exception expected but none was thrown.


As I see RubyGems could not correctly define that Rake finished with error
This is what RubyGems do
      unless $?.exitstatus.zero? then
        raise Gem::InstallError, "#{class_name} failed:\n\n#{results.join"\n"}"
      end

But Rake finishes with return code == 0 on windows even if some error
present. I dunno why, better to ask Rake developers.

Anyway this is how I define that rake finished with error in Cerberus.

  def successful?
    $?.exitstatus == 0 and not @output.include?("rake aborted!")
  end

I dont think that it is very elegant (what if user would print this message
from Rake code) but it works both on Windoze and *nix.

Any comments on this subject?

  2) Failure:
> test_source_index_hash(TestRemoteInstaller)
> [./test/test_remote_installer.rb:87]:
> <1> expected but was
> <6>.


puts source_hash

gives me following output

http://gems.rubyforge.org#<Gem::SourceIndex:0x788f3b8>
http://onestepback.org/betagems#<Gem::SourceIndex:0x63184f0>
code.whytheluckystiff.net#<Gem::SourceIndex:0x63085d8>
http://gems.example.com#<Gem::SourceIndex:0x788f7c0>http://gems.rubyonrails.org#
<Gem::SourceIndex:0x62db140>

looks like test uses also my own gem-repositories (not only
http://gems.example.com)



277 tests, 982 assertions, 2 failures, 0 errors
> rake aborted!
> Command failed with status (1): [c:/PROGRA~1/ruby/bin/ruby -w -Ilib
> "c:/PRO...]
>
> (See full trace by running task with --trace)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/rubygems-developers/attachments/20061221/810f3611/attachment.html 


More information about the Rubygems-developers mailing list