[Rubygems-developers] Patch that fixes Proxy authorization problem (407)

Austin Ziegler halostatue at gmail.com
Thu Dec 15 17:41:37 EST 2005


On 15/12/05, Anatol Pomozov <anatol.pomozov at gmail.com> wrote:
> On 12/15/05, Jim Weirich <jim.weirich at gmail.com> wrote:
> > On 12/15/05, Anatol Pomozov <anatol.pomozov at gmail.com> wrote:
> > > I have response from one guy who tried it. And it says that storing
> login
> > > and password in HTTP_PROXY makes collision with Perl Package Manager
> format
> > > that expect have following EnvVariables
> > >   HTTP_PROXY, HTTP_PROXY_USER, HTTP_PROXY_PASS
> > >
> > > So I suggest redo a little my patch and use following algorithm
> > >   http_proxy = options() || ENV['HTTP_PROXY']
> > >   if http_proxy contains login and lassword
> > >     proxy_user = extract login from http_proxy
> > >      proxy_password = extract password from http_proxy
> > >   else
> > >     proxy_user = HTTP['http_proxy_user']
> > >     proxy_password = ENV['http_proxy_pass']
> > >   end
> >
> > I'm going to request a unit or functional test for this logic.  Thanks.

Might I suggest that this won't work on Windows?

irb(main):001:0> ENV['path']
=> "C:\\Program Files\\ActiveState Komodo 3.5\\..."
irb(main):002:0> ENV['PATH']
=> "C:\\Program Files\\ActiveState Komodo 3.5\\..."
irb(main):003:0>

I think another solution is in order.

-austin
--
Austin Ziegler * halostatue at gmail.com
               * Alternate: austin at halostatue.ca



More information about the Rubygems-developers mailing list