From liming.lian at oracle.com  Fri Feb  1 21:48:44 2008
From: liming.lian at oracle.com (Liming Lian)
Date: Sat, 02 Feb 2008 10:48:44 +0800
Subject: [ruby-oci8-devel] Array DML patch
Message-ID: <47A3DA0C.2020008@oracle.com>

Hi Kubo,

You may have seen my patch about Array DML submitted through Chris. 
Start this thread to discuss the patch issues public on mail list.

I am not sure this patch is the best approach to implement Array DML for 
ruby-oci8. I hope you can review the code and make changes according to 
your expertise.  You may notice, I have changed the order of requiring 
testcase file in the test_all.rb. I don't know why it leads to a 
"segmentation fault" if I don't put the "test_oradate" at the end of the 
require list after applying my patch. I don't know whether it will 
happen on your installation.

Any feedback is welcome!

Liming




From kubo at jiubao.org  Tue Feb  5 08:06:59 2008
From: kubo at jiubao.org (KUBO Takehiro)
Date: Tue, 5 Feb 2008 22:06:59 +0900
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <47A3DA0C.2020008@oracle.com>
References: <47A3DA0C.2020008@oracle.com>
Message-ID: <5d847bcd0802050506p1d123e47xa0b2d45479ef51a0@mail.gmail.com>

Hi Liming,

Sorry too late to reply you.
Well, I'll check it next Saturday.

On Feb 2, 2008 11:48 AM, Liming Lian <liming.lian at oracle.com> wrote:
> Hi Kubo,
>
> You may have seen my patch about Array DML submitted through Chris.
> Start this thread to discuss the patch issues public on mail list.
>
> I am not sure this patch is the best approach to implement Array DML for
> ruby-oci8. I hope you can review the code and make changes according to
> your expertise.  You may notice, I have changed the order of requiring
> testcase file in the test_all.rb. I don't know why it leads to a
> "segmentation fault" if I don't put the "test_oradate" at the end of the
> require list after applying my patch. I don't know whether it will
> happen on your installation.
>
> Any feedback is welcome!
>
> Liming

From kubo at jiubao.org  Thu Feb 21 09:53:37 2008
From: kubo at jiubao.org (KUBO Takehiro)
Date: Thu, 21 Feb 2008 23:53:37 +0900
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <47A3DA0C.2020008@oracle.com>
References: <47A3DA0C.2020008@oracle.com>
Message-ID: <5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>

Hi Liming,

Sorry too many time to make you wait.

On Sat, Feb 2, 2008 at 11:48 AM, Liming Lian <liming.lian at oracle.com> wrote:
> Hi Kubo,
>
>  You may have seen my patch about Array DML submitted through Chris.
>  Start this thread to discuss the patch issues public on mail list.

One thing, please rename id_actual_array_size and id_max_array_size
to id_at_actual_array_size and id_at_max_array_size respectively,
because they are IDs of @actual_array_size and @max_array_size.

Let's me know your username in rubyforge. I'll give you permission
to commit SVN repository. Feel free to commit your code. If it comes
out that it is not proper, we can fix it later.

After I add you to ruby-oci8 developers at rubyforge, you can commit
as follows.
1. check out
   svn checkout
svn+ssh://YOUR_NAME at rubyforge.org/var/svn/ruby-oci8/trunk/ruby-oci8
2. apply your changes.
3. (optional) fix indentations by astyle.
   1. install astyle <URL:http://astyle.sourceforge.net/>
   2. run 'make format_c_source'.
4. add GNU-style ChangeLog to the ChangeLog file.
   YYYY-MM-DD your_name <mail-address>
   <TAB>* comma_sprarated_filenames: reason of changes.
5. commit your changes with message written in ChangeLog
   except YYYY-MM-DD line and tabs at the beginning of lines.

From kubo at jiubao.org  Sat Feb 23 08:29:38 2008
From: kubo at jiubao.org (KUBO Takehiro)
Date: Sat, 23 Feb 2008 22:29:38 +0900
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <47A3DA0C.2020008@oracle.com>
References: <47A3DA0C.2020008@oracle.com>
Message-ID: <5d847bcd0802230529u44f15a25q5034e218bfd09ddc@mail.gmail.com>

Hi,

On Sat, Feb 2, 2008 at 11:48 AM, Liming Lian <liming.lian at oracle.com> wrote:
>  You may notice, I have changed the order of requiring
>  testcase file in the test_all.rb. I don't know why it leads to a
>  "segmentation fault" if I don't put the "test_oradate" at the end of the
>  require list after applying my patch. I don't know whether it will
>  happen on your installation.

It happened on my linux box and I found that It had been fixed on svn 241
committed on January 14th. Now your patch works fine without changing
the location of 'test_oradate'.

From liming.lian at oracle.com  Sun Feb 24 21:37:41 2008
From: liming.lian at oracle.com (Liming Lian)
Date: Mon, 25 Feb 2008 10:37:41 +0800
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
References: <47A3DA0C.2020008@oracle.com>
	<5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
Message-ID: <47C229F5.6010609@oracle.com>

Hi Kubo,

My username in rubyforge is "limlian". Thanks for the suggestions and 
detail steps of committing patches, which is really helpful to me.

Liming
> Hi Liming,
>
> Sorry too many time to make you wait.
>
> On Sat, Feb 2, 2008 at 11:48 AM, Liming Lian <liming.lian at oracle.com> wrote:
>   
>> Hi Kubo,
>>
>>  You may have seen my patch about Array DML submitted through Chris.
>>  Start this thread to discuss the patch issues public on mail list.
>>     
>
> One thing, please rename id_actual_array_size and id_max_array_size
> to id_at_actual_array_size and id_at_max_array_size respectively,
> because they are IDs of @actual_array_size and @max_array_size.
>
> Let's me know your username in rubyforge. I'll give you permission
> to commit SVN repository. Feel free to commit your code. If it comes
> out that it is not proper, we can fix it later.
>
> After I add you to ruby-oci8 developers at rubyforge, you can commit
> as follows.
> 1. check out
>    svn checkout
> svn+ssh://YOUR_NAME at rubyforge.org/var/svn/ruby-oci8/trunk/ruby-oci8
> 2. apply your changes.
> 3. (optional) fix indentations by astyle.
>    1. install astyle <URL:http://astyle.sourceforge.net/>
>    2. run 'make format_c_source'.
> 4. add GNU-style ChangeLog to the ChangeLog file.
>    YYYY-MM-DD your_name <mail-address>
>    <TAB>* comma_sprarated_filenames: reason of changes.
> 5. commit your changes with message written in ChangeLog
>    except YYYY-MM-DD line and tabs at the beginning of lines.
> _______________________________________________
> ruby-oci8-devel mailing list
> ruby-oci8-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ruby-oci8-devel
>   


From kubo at jiubao.org  Mon Feb 25 08:49:30 2008
From: kubo at jiubao.org (KUBO Takehiro)
Date: Mon, 25 Feb 2008 22:49:30 +0900
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <47C229F5.6010609@oracle.com>
References: <47A3DA0C.2020008@oracle.com>
	<5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
	<47C229F5.6010609@oracle.com>
Message-ID: <5d847bcd0802250549v1eac971cwc01d0d6f7d0d7072@mail.gmail.com>

Hi Liming,

On Mon, Feb 25, 2008 at 11:37 AM, Liming Lian <liming.lian at oracle.com> wrote:
> Hi Kubo,
>
>  My username in rubyforge is "limlian". Thanks for the suggestions and
>  detail steps of committing patches, which is really helpful to me.

Thanks. I added your username limilian to ruby-oci8 developers.
You have write access right to SCM.

From liming.lian at oracle.com  Tue Feb 26 04:32:45 2008
From: liming.lian at oracle.com (Liming Lian)
Date: Tue, 26 Feb 2008 17:32:45 +0800
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
References: <47A3DA0C.2020008@oracle.com>
	<5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
Message-ID: <47C3DCBD.1010708@oracle.com>

Hi Kubo,
> 3. (optional) fix indentations by astyle.
>    1. install astyle <URL:http://astyle.sourceforge.net/>
>    2. run 'make format_c_source'.
>   

Any suggestion on specifying the options for running astyle? I have read 
the page "Intent Style in C" on website, I am wondering if there are any 
other special options needed for Ruby-OCI8's C files. I am using emacs 
and have added your recommendation code to .emacs.

Liming

From liming.lian at oracle.com  Tue Feb 26 21:36:00 2008
From: liming.lian at oracle.com (Liming Lian)
Date: Wed, 27 Feb 2008 10:36:00 +0800
Subject: [ruby-oci8-devel] Array DML patch
In-Reply-To: <47C3DCBD.1010708@oracle.com>
References: <47A3DA0C.2020008@oracle.com>	<5d847bcd0802210653r641c853fx926080bc214a50df@mail.gmail.com>
	<47C3DCBD.1010708@oracle.com>
Message-ID: <47C4CC90.4050300@oracle.com>


> Any suggestion on specifying the options for running astyle? I have read 
> the page "Intent Style in C" on website, I am wondering if there are any 
> other special options needed for Ruby-OCI8's C files. I am using emacs 
> and have added your recommendation code to .emacs.
>   

I got the answer of my previous question. I just found the command line 
options for astyle in the latest ChangeLog, it is:

astyle --style=linux --indent=spaces=4 --brackets=linux ext/oci8/*.[ch]

Liming