[ruby-oci8-commit] [296] trunk/ruby-oci8: * ext/oci8/stmt.c: fix comment.

nobody at rubyforge.org nobody at rubyforge.org
Sun Dec 14 03:07:01 EST 2008


Revision: 296
Author:   kubo
Date:     2008-12-14 03:07:01 -0500 (Sun, 14 Dec 2008)

Log Message:
-----------
* ext/oci8/stmt.c: fix comment.
* test/test_rowid.rb: add one assertion as ruby-oci8 1.0 branch does.

Modified Paths:
--------------
    trunk/ruby-oci8/ChangeLog
    trunk/ruby-oci8/ext/oci8/stmt.c
    trunk/ruby-oci8/test/test_rowid.rb

Modified: trunk/ruby-oci8/ChangeLog
===================================================================
--- trunk/ruby-oci8/ChangeLog	2008-12-14 08:03:02 UTC (rev 295)
+++ trunk/ruby-oci8/ChangeLog	2008-12-14 08:07:01 UTC (rev 296)
@@ -1,3 +1,7 @@
+2008-12-14  KUBO Takehiro  <kubo at jiubao.org>
+	* ext/oci8/stmt.c: fix comment.
+	* test/test_rowid.rb: add one assertion as ruby-oci8 1.0 branch does.
+
 2008-09-10  KUBO Takehiro  <kubo at jiubao.org>
 	* ext/oci8/ocidatetime.c: use session time zone when time zone
 	    is not specified to set bind objects of timestamp with time

Modified: trunk/ruby-oci8/ext/oci8/stmt.c
===================================================================
--- trunk/ruby-oci8/ext/oci8/stmt.c	2008-12-14 08:03:02 UTC (rev 295)
+++ trunk/ruby-oci8/ext/oci8/stmt.c	2008-12-14 08:07:01 UTC (rev 296)
@@ -539,10 +539,10 @@
  *   cursor.exec
  *   cursor.rowid # => the inserted row's rowid
  *
- * <em>Changes between ruby-oci8 1.0 and 2.0.</em>
+ * <em>Changes between ruby-oci8 1.0.3 and 1.0.4.</em>
  *
- * [ruby-oci8 2.0] The return value is a String.
- * [ruby-oci8 1.0] It returns an OCIRowid object which is available only as a bind value.
+ * [ruby-oci8 1.0.4 or upper] The return value is a String.
+ * [ruby-oci8 1.0.3 or lower] It returns an OCIRowid object.
  */
 static VALUE oci8_stmt_get_rowid(VALUE self)
 {

Modified: trunk/ruby-oci8/test/test_rowid.rb
===================================================================
--- trunk/ruby-oci8/test/test_rowid.rb	2008-12-14 08:03:02 UTC (rev 295)
+++ trunk/ruby-oci8/test/test_rowid.rb	2008-12-14 08:07:01 UTC (rev 296)
@@ -17,6 +17,7 @@
     cursor = @conn.parse("INSERT INTO test_table values(1)");
     cursor.exec
     rid1 = cursor.rowid
+    assert_instance_of(String, rid1)
     cursor.close
     rid2 = nil
     @conn.exec('select rowid from test_table where rowid = :1', rid1) do |row|




More information about the ruby-oci8-commit mailing list