<div dir="ltr">Ian White has just submitted a patch for this. Thanks Ian. <a href="http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/516">http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/516</a><br><br>
Tim.<br><br><div class="gmail_quote">On Wed, Sep 3, 2008 at 10:41 AM, Tim Haines <span dir="ltr"><<a href="mailto:tmhaines@gmail.com">tmhaines@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div dir="ltr">Hi guys,<br><br>After updating to edge rails I've just struck this problem too. I've just grabbed fresh updates of rspec, rspec-rails, and rails and I'm receiving a few controller spec failures related to view rendering when views shouldn't be rendered (failures relate to mock objects not having expected attributes and methods).<br>
<br>I've logged this in lighthouse -> <a href="http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/516" target="_blank">http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/516</a><br><br>Here's a copy of the full backtrace of one of the fails:<br>
<br> vendor/rails/actionpack/lib/action_controller/routing/route_set.rb:376:in `raise_named_route_error'<br> vendor/rails/actionpack/lib/action_controller/routing/route_set.rb:340:in `generate'<br> vendor/rails/actionpack/lib/action_controller/url_rewriter.rb:208:in `rewrite_path'<br>
vendor/rails/actionpack/lib/action_controller/url_rewriter.rb:187:in `rewrite_url'<br> vendor/rails/actionpack/lib/action_controller/url_rewriter.rb:165:in `rewrite'<br> vendor/rails/actionpack/lib/action_controller/base.rb:630:in `url_for'<br>
vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb:85:in `send'<br> vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb:85:in `url_for'<br> (eval):15:in `user_path'<br> vendor/rails/actionpack/lib/action_controller/polymorphic_routes.rb:111:in `__send__'<br>
vendor/rails/actionpack/lib/action_controller/polymorphic_routes.rb:111:in `polymorphic_url'<br> vendor/rails/actionpack/lib/action_controller/polymorphic_routes.rb:118:in `polymorphic_path'<br> vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb:91:in `url_for'<br>
vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb:228:in `link_to'<br> app/views/home/index.html.erb:5<br> app/views/home/index.html.erb:4:in `each'<br> app/views/home/index.html.erb:4<br>
vendor/rails/actionpack/lib/action_view/renderable.rb:35:in `send'<br> vendor/rails/actionpack/lib/action_view/renderable.rb:35:in `render'<br> vendor/rails/actionpack/lib/action_view/template.rb:68:in `render_template'<br>
vendor/rails/actionpack/lib/action_view/base.rb:266:in `orig_render'<br> vendor/plugins/rspec-rails/lib/spec/rails/extensions/action_view/base.rb:26:in `render'<br> vendor/rails/actionpack/lib/action_view/base.rb:369:in `_render_with_layout'<br>
vendor/rails/actionpack/lib/action_view/base.rb:260:in `orig_render'<br> vendor/plugins/rspec-rails/lib/spec/rails/extensions/action_view/base.rb:26:in `render'<br> vendor/rails/actionpack/lib/action_controller/base.rb:1118:in `render_for_file'<br>
vendor/rails/actionpack/lib/action_controller/base.rb:881:in `render_without_benchmark'<br> vendor/rails/actionpack/lib/action_controller/benchmarking.rb:51:in `render'<br> vendor/rails/activesupport/lib/active_support/core_ext/benchmark.rb:8:in `realtime'<br>
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:51:in `render'<br> vendor/plugins/rspec-rails/lib/spec/rails/example/controller_example_group.rb:213:in `render'<br> vendor/rails/actionpack/lib/action_controller/base.rb:853:in `render_without_benchmark'<br>
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:51:in `render'<br> vendor/rails/activesupport/lib/active_support/core_ext/benchmark.rb:8:in `realtime'<br> vendor/rails/actionpack/lib/action_controller/benchmarking.rb:51:in `render'<br>
vendor/plugins/rspec-rails/lib/spec/rails/example/controller_example_group.rb:213:in `render'<br> vendor/rails/actionpack/lib/action_controller/base.rb:1170:in `default_render'<br> vendor/rails/actionpack/lib/action_controller/base.rb:1176:in `perform_action_without_filters'<br>
vendor/rails/actionpack/lib/action_controller/filters.rb:617:in `call_filters'<br> vendor/rails/actionpack/lib/action_controller/filters.rb:610:in `perform_action_without_benchmark'<br> vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'<br>
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'<br> vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'<br>
vendor/rails/actionpack/lib/action_controller/rescue.rb:202:in `perform_action_without_caching'<br> vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'<br> vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:48:in `cache'<br>
vendor/rails/activerecord/lib/active_record/query_cache.rb:8:in `cache'<br> vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'<br> vendor/rails/actionpack/lib/action_controller/base.rb:535:in `send'<br>
vendor/rails/actionpack/lib/action_controller/base.rb:535:in `process_without_filters'<br> /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/monitor.rb:242:in `synchronize'<br> vendor/rails/actionpack/lib/action_controller/base.rb:535:in `process_without_filters'<br>
vendor/rails/actionpack/lib/action_controller/filters.rb:606:in `process_without_session_management_support'<br> vendor/rails/actionpack/lib/action_controller/session_management.rb:130:in `process_without_test'<br>
vendor/rails/actionpack/lib/action_controller/test_process.rb:18:in `process'<br> vendor/rails/actionpack/lib/action_controller/test_process.rb:400:in `process'<br> vendor/rails/actionpack/lib/action_controller/test_process.rb:371:in `get'<br>
controllers/home_controller_spec.rb:12<br> vendor/plugins/rspec/lib/spec/example/example_methods.rb:83:in `instance_eval'<br> vendor/plugins/rspec/lib/spec/example/example_methods.rb:83:in `eval_block'<br>
vendor/plugins/rspec/lib/spec/example/example_methods.rb:21:in `execute'<br> /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/timeout.rb:48:in `timeout'<br> vendor/plugins/rspec/lib/spec/example/example_methods.rb:18:in `execute'<br>
vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:305:in `execute_examples'<br> vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:304:in `each'<br> vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:304:in `execute_examples'<br>
vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:132:in `run'<br> vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:22:in `run'<br> vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `each'<br>
vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `run'<br> vendor/plugins/rspec/lib/spec/runner/options.rb:115:in `run_examples'<br> vendor/plugins/rspec/lib/spec.rb:21:in `run'<br>
vendor/plugins/rspec/lib/spec/runner.rb:192:in `register_at_exit_hook'<br> controllers/home_controller_spec <br><div><div></div><div class="Wj3C7c"><br><div class="gmail_quote">On Sun, Aug 24, 2008 at 8:57 AM, Sven Fuchs <span dir="ltr"><<a href="mailto:svenfuchs@artweb-design.de" target="_blank">svenfuchs@artweb-design.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Ok, done.<br>
<br>
<a href="http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/508-recent-changes-in-actionpack-break-controller-specs" target="_blank">http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/508-recent-changes-in-actionpack-break-controller-specs</a><br>
<br>
Thanks!<div><div></div><div><br>
<br>
On 23.08.2008, at 16:28, David Chelimsky wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
There are a number of changes to action pack recently that are<br>
incompatible with rspec. Please report these to lighthouse.<br>
<br>
Thanks,<br>
David<br>
<br>
On Sat, Aug 23, 2008 at 6:12 AM, Sven Fuchs <<a href="mailto:svenfuchs@artweb-design.de" target="_blank">svenfuchs@artweb-design.de</a>> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Trying to port an existing app to current Rails edge I've seen similar<br>
things yesterday. I've also updated RSpec/Rails to recent edge.<br>
<br>
Here are two workarounds I've come up with for two of the problems. I'm not<br>
sure if they cause other problems themselves, but maybe they're still useful<br>
as a hint.<br>
<br>
<a href="http://pastie.org/private/5ueehxiqhdgok0d8udksa" target="_blank">http://pastie.org/private/5ueehxiqhdgok0d8udksa</a><br>
<br>
I don't feel familiar enough with RSpec's guts to provide a patch.<br>
<br>
#render_partial on ActionView::Base seems to break because the method<br>
signature has changed.<br>
#render on ControllerExampleGroup seems to break because #render_file<br>
apparently has been removed.<br>
<br>
<br>
<br>
On 23.08.2008, at 00:30, John Reilly wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hello,<br>
<br>
I think I may have found a bug between rspec and edge rails... But I'm<br>
new to this so I'm hoping someone else can confirm before I go filing<br>
bug reports.<br>
<br>
Basically, I'm seeing what "appears" to be my controller specs<br>
deciding to load the views, even though I haven't called<br>
integrate_views. When I generate a default rspec_scaffold, the specs<br>
fail with an ActionView::TemplateError:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
% script/generate rspec_scaffold Bike name:string sku:string<br>
...<br>
rake spec<br>
...<br>
Mock 'Bike_1017' received unexpected message :name with (no args)<br>
On line #11 of app/views/index.html.erb<br>
</blockquote>
<br>
If I modify the generated index spec like this, the spec passes:<br>
<br>
...snip...<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
it "should expose all bikes as @bikes" do<br>
Bike.should_receive(:find).with(:all).and_return([mock_bike])<br>
<br>
# adding these lines cause the spec to pass...<br>
mock_bike.should_receive(:name)<br>
mock_bike.should_receive(:sku)<br>
<br>
get :index<br>
assigns[:bikes].should == [mock_bike]<br>
end<br>
</blockquote>
<br>
...snip...<br>
<br>
While this "fixes" the failures, it's no longer an isolated test of<br>
the controller.<br>
<br>
After spending some time with git-bisect, it looks like this problem<br>
was introduced in a commit to edge rails:<br>
<br>
<a href="http://github.com/rails/rails/commit/1129a24caff9f1804c2bff6569c0cbd8598dfa86" target="_blank">http://github.com/rails/rails/commit/1129a24caff9f1804c2bff6569c0cbd8598dfa86</a><br>
<br>
The default rspec_scaffold tests pass before this commit, and fail<br>
after this commit.<br>
<br>
More details here:<br>
<a href="http://johnreilly.tumblr.com/post/47016047/rspec-is-mocking-me" target="_blank">http://johnreilly.tumblr.com/post/47016047/rspec-is-mocking-me</a><br>
<br>
Am I insane? Or does this happen for anyone else? :-)<br>
<br>
Thanks,<br>
-- John Reilly<br>
<br>
_______________________________________________<br>
rspec-users mailing list<br>
<a href="mailto:rspec-users@rubyforge.org" target="_blank">rspec-users@rubyforge.org</a><br>
<a href="http://rubyforge.org/mailman/listinfo/rspec-users" target="_blank">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
</blockquote>
<br>
--<br>
sven fuchs <a href="mailto:svenfuchs@artweb-design.de" target="_blank">svenfuchs@artweb-design.de</a><br>
artweb design <a href="http://www.artweb-design.de" target="_blank">http://www.artweb-design.de</a><br>
grünberger 65 + 49 (0) 30 - 47 98 69 96 (phone)<br>
d-10245 berlin + 49 (0) 171 - 35 20 38 4 (mobile)<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
rspec-users mailing list<br>
<a href="mailto:rspec-users@rubyforge.org" target="_blank">rspec-users@rubyforge.org</a><br>
<a href="http://rubyforge.org/mailman/listinfo/rspec-users" target="_blank">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
<br>
</blockquote>
_______________________________________________<br>
rspec-users mailing list<br>
<a href="mailto:rspec-users@rubyforge.org" target="_blank">rspec-users@rubyforge.org</a><br>
<a href="http://rubyforge.org/mailman/listinfo/rspec-users" target="_blank">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
</blockquote>
<br>
--<br>
sven fuchs <a href="mailto:svenfuchs@artweb-design.de" target="_blank">svenfuchs@artweb-design.de</a><br>
artweb design <a href="http://www.artweb-design.de" target="_blank">http://www.artweb-design.de</a><br>
grünberger 65 + 49 (0) 30 - 47 98 69 96 (phone)<br>
d-10245 berlin + 49 (0) 171 - 35 20 38 4 (mobile)<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
rspec-users mailing list<br>
<a href="mailto:rspec-users@rubyforge.org" target="_blank">rspec-users@rubyforge.org</a><br>
<a href="http://rubyforge.org/mailman/listinfo/rspec-users" target="_blank">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div>