Done, thanks everyone.<br><br><div><span class="gmail_quote">On 14/02/2008, <b class="gmail_sendername">David Chelimsky</b> <<a href="mailto:dchelimsky@gmail.com">dchelimsky@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Thu, Feb 14, 2008 at 10:16 AM, Max Williams<br> <br><<a href="mailto:toastkid.williams@gmail.com">toastkid.williams@gmail.com</a>> wrote:<br> <br>> I'm new to rspec (and coding in general) but would it break a lot of<br>
> people's tests if redirect_to was changed to do this by default? It's what<br> > i expected it to do, personally, that is to pass if the given :action and<br> > :controller match up. If i pass a url string, and it's missing the params,<br>
> then it seems fair that it should fail, but if for example i just specify a<br> > controller, and that controller is called (with any action) i'd expect it to<br> > pass as well.<br> ><br> > Like i say i'm a newb with no idea of the impact of this to existing tests<br>
> :)<br> <br> <br>It is conceivable that existing examples could break, but the docs do<br> set out the same expectation that you have.<br> <br> Can you file a bug at <a href="http://rspec.lighthouseapp.com">http://rspec.lighthouseapp.com</a> so we can get it<br>
in the queue?<br> <br><br> <br> > On 14/02/2008, Rick DeNatale <<a href="mailto:rick.denatale@gmail.com">rick.denatale@gmail.com</a>> wrote:<br> > > On 2/14/08, David Chelimsky <<a href="mailto:dchelimsky@gmail.com">dchelimsky@gmail.com</a>> wrote:<br>
> > > On Thu, Feb 14, 2008 at 9:48 AM, Rick DeNatale <<a href="mailto:rick.denatale@gmail.com">rick.denatale@gmail.com</a>><br> > wrote:<br> > > > > On 2/14/08, David Chelimsky <<a href="mailto:dchelimsky@gmail.com">dchelimsky@gmail.com</a>> wrote:<br>
> > > > > On Thu, Feb 14, 2008 at 8:22 AM, Rick DeNatale<br> > <<a href="mailto:rick.denatale@gmail.com">rick.denatale@gmail.com</a>> wrote:<br> > ><br> > > > > > I don't have the cycles to add this anytime soon, so if you like<br>
> the<br> > > > > > idea, feel free to submit a patch to the tracker.<br> > > > ><br> > > > > I'd be happy to do that, although I'm not entirely convinced that<br> > > > > redirect_with is the right name, not that I've got a better<br>
> > > > alternative.<br> > > ><br> > > ><br> > > > redirect_with_options?<br> > ><br> > ><br> > > I think I like that.<br> > ><br> > ><br> > ><br>
> > > How about something added to the existing call?<br> > > ><br> > > > response.should redirect_to(:controller => 'foo', :action =><br> > > > 'bar').ignoring_other_options<br>
> ><br> > ><br> > > This seems too wordy.<br> > ><br> > ><br> > ><br> > > --<br> > ><br> > > Rick DeNatale<br> > ><br> > > My blog on Ruby<br> > > <a href="http://talklikeaduck.denhaven2.com/">http://talklikeaduck.denhaven2.com/</a><br>
> > _______________________________________________<br> > > rspec-users mailing list<br> > > <a href="mailto:rspec-users@rubyforge.org">rspec-users@rubyforge.org</a><br> > > <a href="http://rubyforge.org/mailman/listinfo/rspec-users">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
> ><br> ><br> ><br> > _______________________________________________<br> > rspec-users mailing list<br> > <a href="mailto:rspec-users@rubyforge.org">rspec-users@rubyforge.org</a><br> > <a href="http://rubyforge.org/mailman/listinfo/rspec-users">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
><br> _______________________________________________<br> rspec-users mailing list<br> <a href="mailto:rspec-users@rubyforge.org">rspec-users@rubyforge.org</a><br> <a href="http://rubyforge.org/mailman/listinfo/rspec-users">http://rubyforge.org/mailman/listinfo/rspec-users</a><br>
</blockquote></div><br>